Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 27, 2015, 7:22 p.m.) Review request for hive. Changes ---

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review74315 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review74159 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

> On Feb. 20, 2015, 1:38 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java, > > line 143 > > > > > > In 99% of the cases arg[1] will be constant > > you ca

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 25, 2015, 11:35 p.m.) Review request for hive. Changes ---

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

> On Feb. 20, 2015, 9:21 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java, > > line 94 > > > > > > We do this same check in so many different date functions .. we shoul

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review73391 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 21, 2015, 2:54 a.m.) Review request for hive. Changes ---

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 21, 2015, 12:49 a.m.) Review request for hive. Changes ---

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

> On Feb. 20, 2015, 9:21 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java, > > line 94 > > > > > > We do this same check in so many different date functions .. we shoul

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

> On Feb. 20, 2015, 9:21 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java, > > line 73 > > > > > > If you are only going to support a single format string for month, I

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review73309 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review73240 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 20, 2015, 1:18 a.m.) Review request for hive. Changes ---

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review71345 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review71344 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review71342 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.j

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 5, 2015, 11:33 p.m.) Review request for hive. Repository: hive-

Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 5, 2015, 11:27 p.m.) Review request for hive. Summary (updated)