-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30782/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-9412
https://issues.apache.org/jira/browse/HIVE-9412
Repository: hive-git
Description
-------
When window clause with ROWS is used between two proper PRECEDING boundaries,
Hive reports syntax errors as following examples.
--For example 1
SELECT name, dept_num, salary,
MAX(salary) OVER (PARTITION BY dept_num ORDER BY
name ROWS BETWEEN 2 PRECEDING AND 1 PRECEDING) win4_alter
FROM employee_contract;
Error: Error while compiling statement: FAILED: SemanticException Failed to
breakup Windowing invocations into Groups. At least 1 group must only depend on
input columns. Also check for circular dependencies.
Underlying error: Window range invalid, start boundary is greater than end
boundary: window(start=range(2 PRECEDING), end=range(1 PRECEDING))
(state=42000,code=40000)
--For example 2
SELECT name, dept_num, salary,
MAX(salary) OVER (PARTITION BY dept_num ORDER BY
name ROWS BETWEEN UNBOUNDED PRECEDING AND 1 PRECEDING) win1
FROM employee_contract;
Error: Error while compiling statement: FAILED: SemanticException End of a
WindowFrame cannot be UNBOUNDED PRECEDING (state=42000,code=40000)
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java e95505c
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 28afc6b
ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFunctionDef.java e4ea358
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java
12a327f
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFFirstValue.java
f679387
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLastValue.java
e099154
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMax.java a153818
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMin.java d931d52
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStreamingEvaluator.java
d68c085
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java ffb7093
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java
903a9b0
ql/src/test/queries/clientpositive/windowing_windowspec.q 6d8ce67
ql/src/test/results/clientpositive/windowing_windowspec.q.out 00af6b8
Diff: https://reviews.apache.org/r/30782/diff/
Testing
-------
Thanks,
Navis Ryu
