Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread chengxiang li
> On 五月 18, 2015, 2:37 a.m., chengxiang li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 88 > > > > > > Just curious, it looks to me that AtomaticBoolean wor

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread chengxiang li
> On 五月 18, 2015, 2:26 a.m., chengxiang li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 96 > > > > > > SparkClientFactory.initialize would be invoked only o

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread Jimmy Xiang
> On May 18, 2015, 2:37 a.m., chengxiang li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 88 > > > > > > Just curious, it looks to me that AtomaticBoolean wo

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread Jimmy Xiang
> On May 18, 2015, 2:26 a.m., chengxiang li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 96 > > > > > > SparkClientFactory.initialize would be invoked only

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34293/#review84096 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessi

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-17 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34293/#review84094 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessi

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-15 Thread Jimmy Xiang
> On May 15, 2015, 10:19 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 169 > > > > > > Any concurrency issue for this, or it doesn't matte

Re: Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-15 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34293/#review83990 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessi

Review Request 34293: HIVE-10721 SparkSessionManagerImpl leaks SparkSessions [Spark Branch]

2015-05-15 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34293/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-10721 https://issues.ap