Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated June 15, 2015, 11:03 p.m.) Review request for hive. Repository:

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-04 Thread Thejas Nair
On June 4, 2015, 10:31 p.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java, line 55 https://reviews.apache.org/r/34776/diff/5/?file=976068#file976068line55 HiveSessionProxy is the one that does the doAs(). I

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-04 Thread Sergey Shelukhin
On June 4, 2015, 10:31 p.m., Thejas Nair wrote: ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java, line 184 https://reviews.apache.org/r/34776/diff/5-6/?file=976065#file976065line184 shoudl this also be static ? no, see class comment - tests override it On June 4,

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-04 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/#review86727 --- ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-02 Thread Sergey Shelukhin
On June 2, 2015, 2:37 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java, line 55 https://reviews.apache.org/r/34776/diff/5/?file=976068#file976068line55 I think this approach will cause the bug in HIVE-6245. If new

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated June 2, 2015, 7:07 p.m.) Review request for hive. Repository:

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated June 1, 2015, 8:25 p.m.) Review request for hive. Repository:

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/#review86129 ---

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/#review86130 ---

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Sergey Shelukhin
On June 2, 2015, 12:23 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, line 103 https://reviews.apache.org/r/34776/diff/4/?file=975858#file975858line103 would it be possible to use a synchronized set instead ? That would be

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated June 2, 2015, 12:53 a.m.) Review request for hive. Repository:

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Thejas Nair
On June 2, 2015, 12:23 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, line 103 https://reviews.apache.org/r/34776/diff/4/?file=975858#file975858line103 would it be possible to use a synchronized set instead ? That would be

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-06-01 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/#review86144 --- ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-05-29 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/#review85703 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-05-29 Thread Thejas Nair
On May 29, 2015, 10:34 a.m., Carl Steinbach wrote: ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1133 https://reviews.apache.org/r/34776/diff/2/?file=973800#file973800line1133 This: if (isParallelEnabled LOG.isDebugEnabled()) {

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-05-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated May 29, 2015, 7:56 p.m.) Review request for hive. Repository:

Re: Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-05-28 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- (Updated May 28, 2015, 9:31 p.m.) Review request for hive. Repository:

Review Request 34776: HIVE-4239 : Remove lock on compilation stage

2015-05-28 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34776/ --- Review request for hive. Repository: hive-git Description --- see jira