Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- (Updated Dec. 18, 2015, 5:28 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111254 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111247 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111255 --- ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java (line

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111248 ---

Re: Review Request 41457: HIVE-11865

> On Dec. 18, 2015, 7:59 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java, > > line 1 > > > > > > These seems cosmetic, do we need these? These

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review111288 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java

Re: Review Request 41457: HIVE-11865

> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492 > > > > > > This is fragile; i.e reusing the flag whether to run CBO or not for >

Re: Review Request 41457: HIVE-11865

> On Dec. 18, 2015, 7:52 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java, line 112 > > > > > > In the CBO Success path the additional const prop seems unnecessary. >

Re: Review Request 41457: HIVE-11865

> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492 > > > > > > This is fragile; i.e reusing the flag whether to run CBO or not for >

Re: Review Request 41457: HIVE-11865

> On Dec. 18, 2015, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java, line 167 > > > > > > This is fragile. > > State will have to be maintained; i.e unset if a

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- (Updated Dec. 18, 2015, 10:19 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 41457: HIVE-11865

> On Dec. 17, 2015, 1:45 a.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java, line 106 > > > > > > What about const propagation? I had been doing tests adding/removing

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- (Updated Dec. 17, 2015, 3:21 p.m.) Review request for hive, Ashutosh Chauhan

Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/ --- Review request for hive, Ashutosh Chauhan and John Pullokkaran. Bugs:

Re: Review Request 41457: HIVE-11865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41457/#review110839 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java