Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review135251 --- Ship it! Looks good. Could you please add a timeout annotation

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review135121 ---

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/ --- (Updated May 27, 2016, 12:39 a.m.) Review request for hive, Gunther

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review134615 --- Fix it, then Ship it! Looks good, after addressing the 2 minor

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/ --- (Updated May 23, 2016, 10:22 p.m.) Review request for hive, Gunther

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java, > > line 290 > > > > > > What user is expected over here. > > 1.

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java, > > line 290 > > > > > > What user is expected over here. > > 1.

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java, > > line 290 > > > > > > What user is expected over here. > > 1.

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review134430 --- Still needs some tests.

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java, > > line 134 > > > > > > Can a second login be avoided. I'm guessing this is

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java, > > line 267 > > > > > > A follow up jira may be to limit the age of

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/ --- (Updated May 21, 2016, 12:07 a.m.) Review request for hive, Gunther

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java, > > line 25 > > > > > > Think the patch which added Pair/ImmutablePair may

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2698-2699 > > > > > > Is this primarily for config ? Rename to have a positive connotation >

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review134076 --- Think it will be useful to add some tests around 1) signing /

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/ --- (Updated May 18, 2016, 8:36 p.m.) Review request for hive, Gunther Hagleitner,

Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/ --- Review request for hive, Gunther Hagleitner, Jason Dere, and Siddharth Seth.