Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/#review147482 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Aug. 31, 2016

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Jesús Camacho Rodríguez
> On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 286 > > > > > > Will STRUCT with all constants inside e.g. (x,

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Sergey Shelukhin
> On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 286 > > > > > > Will STRUCT with all constants inside e.g. (x,

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/ --- (Updated Aug. 31, 2016, 7:38 p.m.) Review request for hive and Jesús Camacho Ro

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Jesús Camacho Rodríguez
> On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 375 > > > > > > WalkState.CONSTANT or WalkState.UNKNOWN? (I thi

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Sergey Shelukhin
> On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 286 > > > > > > Will STRUCT with all constants inside e.g. (x,

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/ --- (Updated Aug. 31, 2016, 6:42 p.m.) Review request for hive and Jesús Camacho Ro

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-31 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/#review147456 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFa

Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/ --- (Updated Aug. 30, 2016, 9:56 p.m.) Review request for hive and Jesús Camacho Ro

Review Request 51542: HIVE-14652 incorrect results for not in on partition columns

2016-08-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/ --- Review request for hive and Jesús Camacho Rodríguez. Summary (updated)