Re: Review Request 53983: HIVE-14582 : Add trunc(numeric) udf

2016-11-30 Thread Chinna Rao Lalam
> On Dec. 1, 2016, 12:05 a.m., Vineet Garg wrote: > > ql/src/test/queries/clientnegative/udf_trunc_error3.q, line 1 > > > > > > I think it'll be good to add tests with negative numbers as well as > > no-op (e.g.

Re: Review Request 53983: HIVE-14582 : Add trunc(numeric) udf

2016-11-30 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53983/#review157471 --- ql/src/test/queries/clientnegative/udf_trunc_error3.q (line 1)

Re: Review Request 53983: HIVE-14582 : Add trunc(numeric) udf

2016-11-30 Thread chinnarao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53983/ --- (Updated Nov. 30, 2016, 7:04 p.m.) Review request for hive and Ashutosh

Review Request 53983: HIVE-14582 : Add trunc(numeric) udf

2016-11-22 Thread chinnarao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53983/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git