Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-15 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/ --- (Updated Dec. 16, 2016, 1:54 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-15 Thread Vineet Garg
> On Dec. 13, 2016, 1:51 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveReplicatedRelBuilder.java, > > line 111 > > > > > > Add a TODO about removing this class once we

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-14 Thread Vineet Garg
> On Dec. 13, 2016, 1:51 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lib/SubQueryWalker.java, line 27 > > > > > > Better name: Expression walker? Updated class name to ExpressionWalker >

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-14 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/#review159181 --- Also, Hive uses Sun's style guide. http://www.oracle.com/technetw

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/#review158889 --- ql/src/java/org/apache/hadoop/hive/ql/lib/SubQueryWalker.java (li

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-12 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/ --- (Updated Dec. 12, 2016, 6:17 p.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-10 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/ --- (Updated Dec. 11, 2016, 2:30 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-07 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/ --- (Updated Dec. 8, 2016, 1:49 a.m.) Review request for hive and Ashutosh Chauhan.

Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-07 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54517/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-15192 https://issu