Re: Review Request 59402: HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to Ptest

2017-08-16 Thread Barna Zsombor Klara
> On July 28, 2017, 7:01 p.m., Sahil Takiar wrote: > > Overall it looks good. What about other Maven options though? Would it be > > difficult to update this patch so that any option for `mvn` can be passed > > in? Not just options specified by `-D`? Sorry for the very late reply Sahil. I'm

Re: Review Request 59402: HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to Ptest

2017-07-28 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59402/#review181710 --- Overall it looks good. What about other Maven options though?

Re: Review Request 59402: HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to Ptest

2017-05-20 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59402/#review175590 --- Ship it! Thanks for the patch Zsombor! +1 LGTM(non-binding) -

Review Request 59402: HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to Ptest

2017-05-19 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59402/ --- Review request for hive, Sergio Pena and Sahil Takiar. Bugs: HIVE-16718