Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-26 Thread Zsolt Fekete
> On May 25, 2017, 11:51 p.m., Zoltan Haindrich wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/metatool/BlockRetrieverIterable.java > > Lines 8 (patched) > > > > > > it seems to me that this "iterable"

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-26 Thread Peter Vary
> On May 22, 2017, 11:50 a.m., Peter Vary wrote: > > Thanks for the patch Zsolt! > > > > It is important to be able to check the data even if does not fit into > > memory! Thanks for the catch! > > > > As for the patch, few comments from YETUS: > > - Checkstyle: I will not put all of them

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-26 Thread Zsolt Fekete
> On May 22, 2017, 11:50 a.m., Peter Vary wrote: > > Thanks for the patch Zsolt! > > > > It is important to be able to check the data even if does not fit into > > memory! Thanks for the catch! > > > > As for the patch, few comments from YETUS: > > - Checkstyle: I will not put all of them

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-25 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/#review176142 ---

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-22 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/#review175622 --- Thanks for the patch Zsolt! It is important to be able to check

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-19 Thread Zsolt Fekete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/ --- (Updated May 19, 2017, 5:05 p.m.) Review request for hive. Repository:

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-19 Thread Zsolt Fekete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/ --- (Updated May 19, 2017, 4:38 p.m.) Review request for hive. Repository:

Re: Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-19 Thread Zsolt Fekete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/#review175521 --- - Zsolt Fekete On May 19, 2017, 4:32 p.m., Zsolt Fekete wrote:

Review Request 59408: HIVE-16719 HiveMetaTool fails when the data does not fit in memory

2017-05-19 Thread Zsolt Fekete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59408/ --- Review request for hive. Repository: hive-git Description ---