Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59654/ --- (Updated May 30, 2017, 11:22 p.m.) Review request for hive, Naveen Gangam, Serg

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59654/#review176375 --- Ship it! The patch looks good. I agree this needs more refactor

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59654/#review176369 --- Fix it, then Ship it! Overall, LGTM. beeline/src/java/org/apa

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59654/ --- (Updated May 30, 2017, 9:43 p.m.) Review request for hive, Naveen Gangam, Sergi

Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59654/ --- Review request for hive, Naveen Gangam, Sergio Pena, and Sahil Takiar. Reposito