Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-09-12 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/ --- (Updated Sept. 13, 2017, 1:58 a.m.) Review request for hive, Gopal V and

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-09-12 Thread Sergey Shelukhin
> On Sept. 8, 2017, 6:24 p.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ParquetMetadataCacheImpl.java > > Lines 52 (patched) > > > > > > This file looks renamed from Parquet

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-09-08 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/#review184992 ---

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-08-31 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/ --- (Updated Sept. 1, 2017, 12:41 a.m.) Review request for hive, Gopal V and

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-07-25 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/ --- (Updated July 25, 2017, 9:32 p.m.) Review request for hive, Gopal V and

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-29 Thread Sergey Shelukhin
> On June 29, 2017, 6:38 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > > Lines 614 (patched) > > > > > > can this all be baked in OrcFileMetadata

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/ --- (Updated June 29, 2017, 9:21 p.m.) Review request for hive, Gopal V and

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-29 Thread Sergey Shelukhin
> On June 29, 2017, 6:38 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > > Lines 1685 (patched) > > > > > > This looks complicated. It will be better if ORC

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-29 Thread Sergey Shelukhin
> On June 29, 2017, 6:38 a.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 2974 (original) > > > > > > Do we need this for offheap cache? For smaller cache, we don't

Re: Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-29 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/#review179152 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line

Review Request 60289: HIVE-15665 LLAP: OrcFileMetadata objects in cache can impact heap usage

2017-06-21 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60289/ --- Review request for hive, Gopal V and Prasanth_J. Repository: hive-git