Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-12 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review197282 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 9, 2018, 9:46 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > stupid RB won't let me edit my own

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > stupid RB won't let me edit my own

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-08 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 9, 2018, 1:52 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 7, 2018, 10:34 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-07 Thread Sergey Shelukhin
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-07 Thread Eugene Koifman
> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-07 Thread Eugene Koifman
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > > > > > is 'job' cloned somewhere between

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-07 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196904 --- ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 6, 2018, 3:29 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Sergey Shelukhin
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > > > > > is 'job' cloned somewhere between invocations?

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196819 --- ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Lines

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-02 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196778 ---

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-01-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Jan. 29, 2018, 11:12 p.m.) Review request for hive and Eugene

Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-01-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- Review request for hive and Eugene Koifman. Repository: hive-git Description