Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-21 Thread Peter Vary via Review Board
> On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > > Thanks a lot for the changes. Mostly looks good to me. Couple of minor > > suggestions. Thanks for the review Vihang! > On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > >

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-21 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 21, 2018, 8 de) Review request for hive, Alexander Kolbasov and

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-20 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review205084 --- Fix it, then Ship it! Thanks a lot for the changes. Mostly

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-19 Thread Peter Vary via Review Board
> On jún. 13, 2018, 4:50 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 2545 (original), 2538 (patched) > > > > > > My concern

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-19 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 19, 2018, 12:23 du) Review request for hive, Alexander Kolbasov

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-14 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 14, 2018, 10:57 de) Review request for hive, Alexander Kolbasov

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-14 Thread Peter Vary via Review Board
> On jún. 13, 2018, 4:50 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 2545 (original), 2538 (patched) > > > > > > My concern

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-13 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review204700 ---

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review204512 --- Ship it! Ship It! - Alexander Kolbasov On June 7, 2018,

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-07 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated June 7, 2018, 10:31 a.m.) Review request for hive, Alexander Kolbasov

Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

2018-06-07 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs: