Re: Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209055 --- Good overall, some small things below.

Re: Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209037 --- Please put JIRA ID in the header and also in the Bug field on the

Re: Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-26 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209031 --- Code looks clean, but I have some scary questions.

Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- Review request for hive and Alexander Kolbasov. Repository: hive-git