Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 7:59 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 25, 2019, 7:41 p.m., Vihang Karajgaonkar wrote: > > Some minor comments related to logs. Rest looks good. Thanks for the feedback > On Jan. 25, 2019, 7:41 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212345 --- Fix it, then Ship it! Some minor comments related to logs.

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 25, 2019, 5:08 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > > Line 1082 (original) > > > > > > Add a test

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 7:22 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212335 ---

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 24, 2019, 11:21 p.m., Karthik Manamcheri wrote: > > Thanks for the feedback > On Jan. 24, 2019, 11:21 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Line 465 (original), 466

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 1:38 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 1:38 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212295 ---

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 24, 2019, 11:16 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 24, 2019, 11:13 p.m.) Review request for hive, Adam Holley,

Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- Review request for hive, Adam Holley, Karthik Manamcheri, Na Li, and Vihang