Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-15 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/#review221005 --- Ship it! Ship It! - Marta Kuczora On June 8, 2020, 10:58

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-10 Thread Karen Coppage via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/#review220990 --- Ship it! Ship It! - Karen Coppage On June 8, 2020, 10:58

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-10 Thread Karen Coppage via Review Board
> On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 1411 (original) > > > > > > Are these originals not needed, or collected elsewhere? > > Peter

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-08 Thread Peter Varga via Review Board
> On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > LGTM, a few minor suggestions. > > (Non-binding) Thanks for the review. > On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 1411 (original) > >

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-08 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- (Updated June 8, 2020, 10:58 a.m.) Review request for hive, Karen Coppage,

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-06-05 Thread Karen Coppage via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/#review220956 --- LGTM, a few minor suggestions. (Non-binding)

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-05-21 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- (Updated May 21, 2020, 1:23 p.m.) Review request for hive, Karen Coppage and

Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- Review request for hive, Karen Coppage and Peter Vary. Repository: hive-git