Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-13 Thread Lefty Leverenz
> On May 12, 2017, 3:01 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3357-3361 (patched) > > > > > > Looks good, just some minor suggestions: > > > >

[GitHub] hive pull request #176: HIVE-16530: Improve execution logs for REPL commands

2017-05-13 Thread sankarh
Github user sankarh closed the pull request at: https://github.com/apache/hive/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] hive pull request #180: HIVE-13652: Import table change order of dynamic par...

2017-05-13 Thread sankarh
Github user sankarh closed the pull request at: https://github.com/apache/hive/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 56140: Can't order by an unselected column

2017-05-13 Thread pengcheng xiong
> On May 3, 2017, 4:24 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cp_sel.q.out > > Line 46 (original), 50 (patched) > > > > > > Is this expected? > > Seems like this may generate wrong

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-13 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 5:19 a.m.) Review request for hive, Daniel Dai and

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-13 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 2:21 a.m.) Review request for hive, Daniel Dai and

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-13 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review174896 --- Ship it! Ship It! - Aihua Xu On May 12, 2017, 9:35 p.m.,

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-13 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 1:28 a.m.) Review request for hive, Daniel Dai and