Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-11 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67023/ --- (Updated May 11, 2018, 11:38 p.m.) Review request for hive and Sahil Takiar.

Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

2018-05-11 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66862/ --- (Updated May 11, 2018, 11:37 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

2018-05-11 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 12, 2018, 12:30 a.m.) Review request for hive, Sahil Takiar and

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-11 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67023/#review202981 --- ql/src/test/queries/clientpositive/erasure_simple.q Lines 33

[GitHub] hive pull request #342: HIVE-19248: REPL LOAD couldn't copy file from source...

2018-05-11 Thread sankarh
Github user sankarh closed the pull request at: https://github.com/apache/hive/pull/342 ---

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

2018-05-11 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202911 --- All of my other comments are fixed. Thanks, Peter

[jira] [Created] (HIVE-19499) Bootstrap REPL LOAD shall add tasks to create checkpoints for tables/partitions.

2018-05-11 Thread Sankar Hariappan (JIRA)
Sankar Hariappan created HIVE-19499: --- Summary: Bootstrap REPL LOAD shall add tasks to create checkpoints for tables/partitions. Key: HIVE-19499 URL: https://issues.apache.org/jira/browse/HIVE-19499

REMINDER: Apache EU Roadshow 2018 schedule announced!

2018-05-11 Thread sharan
Hello Apache Supporters and Enthusiasts This is a reminder that the schedule for the Apache EU Roadshow 2018 in Berlin has been announced. http://apachecon.com/euroadshow18/schedule.html Please note that we will not be running an ApacheCon in Europe this year which means that this Apache EU

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202907 --- Hi Bharath, Thanks for the patch! Few quick questions there (not

[jira] [Created] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions

2018-05-11 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-19500: --- Summary: Prevent multiple selectivity estimations for the same variable in conjuctions Key: HIVE-19500 URL: https://issues.apache.org/jira/browse/HIVE-19500

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202942 --- common/src/java/org/apache/hive/common/util/DateUtils.java Lines

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

2018-05-11 Thread Peter Vary via Review Board
> On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > > Do you have some way of testing that all the objects are actually deleted > > from the DB? I will create an followup jira to find a way to do this. HIVE-19503 > On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

2018-05-11 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated May 11, 2018, 2:13 p.m.) Review request for hive, Alexander Kolbasov,

[jira] [Created] (HIVE-19501) Fix HyperLogLog to be threadsafe

2018-05-11 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-19501: --- Summary: Fix HyperLogLog to be threadsafe Key: HIVE-19501 URL: https://issues.apache.org/jira/browse/HIVE-19501 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-19502) Unable to insert values into table stored by JdbcStorageHandler

2018-05-11 Thread Alexey (JIRA)
Alexey created HIVE-19502: - Summary: Unable to insert values into table stored by JdbcStorageHandler Key: HIVE-19502 URL: https://issues.apache.org/jira/browse/HIVE-19502 Project: Hive Issue Type:

[jira] [Created] (HIVE-19503) Create a test that checks that every table is empty after a dropTable happened with directSql

2018-05-11 Thread Peter Vary (JIRA)
Peter Vary created HIVE-19503: - Summary: Create a test that checks that every table is empty after a dropTable happened with directSql Key: HIVE-19503 URL: https://issues.apache.org/jira/browse/HIVE-19503

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On May 11, 2018, 10:08 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > > Lines 74 (patched) > > > > > > Do we think this is a better approach then the one

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On May 11, 2018, 3:22 p.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/DateUtils.java > > Lines 39 (patched) > > > > > > why does this need to be `ThreadLocal`? there doesn't seem to be >

[jira] [Created] (HIVE-19504) Change default value for hive.auto.convert.join.shuffle.max.size property

2018-05-11 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-19504: -- Summary: Change default value for hive.auto.convert.join.shuffle.max.size property Key: HIVE-19504 URL: https://issues.apache.org/jira/browse/HIVE-19504

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Sahil Takiar
> On May 11, 2018, 3:22 p.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/DateUtils.java > > Lines 39 (patched) > > > > > > why does this need to be `ThreadLocal`? there doesn't seem to be >

[DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Jesus Camacho Rodriguez
I believe we have reached a state (maybe we did reach it a while ago) that is not sustainable anymore, as there are so many tests failing / timing out that it is not possible to verify whether a patch is breaking some critical parts of the system or not. It also seems to me that due to the

[jira] [Created] (HIVE-19505) Increase number of parallel runs from 2 per node to 4

2018-05-11 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19505: -- Summary: Increase number of parallel runs from 2 per node to 4 Key: HIVE-19505 URL: https://issues.apache.org/jira/browse/HIVE-19505 Project: Hive

[GitHub] hive pull request #339: HIVE 18193:Migrate existing ACID tables to use write...

2018-05-11 Thread sankarh
Github user sankarh closed the pull request at: https://github.com/apache/hive/pull/339 ---

[jira] [Created] (HIVE-19506) Test suites timing out

2018-05-11 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-19506: -- Summary: Test suites timing out Key: HIVE-19506 URL: https://issues.apache.org/jira/browse/HIVE-19506 Project: Hive Issue Type: Bug Reporter: Vineet

Re: [DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Vihang Karajgaonkar
+1 There are many problems with the test infrastructure and in my opinion it has not become number one bottleneck for the project. I was looking at the infrastructure yesterday and I think the current infrastructure (even its own set of problems) is still under-utilized. I am planning to increase

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

2018-05-11 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202965 --- Should I handle String inputs like 2018-05-10 12:20:10 to retain

Re: [DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Vihang Karajgaonkar
correction in my email below. I meant "in my opinion it *has now* become number one bottleneck for the project" (worst place for a typo I guess) On Fri, May 11, 2018 at 1:46 PM, Vihang Karajgaonkar wrote: > +1 There are many problems with the test infrastructure and in my

Re: [DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Vineet Garg
+1. I strongly vote for freezing commits and getting our testing coverage in acceptable state. We have been struggling to stabilize branch-3 due to test failures and releasing Hive 3.0 in current state would be unacceptable. Currently there are quite a few test suites which are not even

Re: [DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Jesus Camacho Rodriguez
Bq. For the short term green runs, I think we should @Ignore the tests which are known to be failing since many runs. They are anyways not being addressed as such. If people think they are important to be run we should fix them and only then re-enable them. I think that is a good idea, as we

Re: [DISCUSS] Unsustainable situation with ptests

2018-05-11 Thread Vihang Karajgaonkar
In order to understand the end-to-end precommit flow I would like to get access to the PreCommit-HIVE-Build jenkins script. Does anyone one know how can I get that? On Fri, May 11, 2018 at 2:03 PM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > Bq. For the short term green runs, I think

[jira] [Created] (HIVE-19507) Ptest queue size is 5 which doesn't make any sense

2018-05-11 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19507: -- Summary: Ptest queue size is 5 which doesn't make any sense Key: HIVE-19507 URL: https://issues.apache.org/jira/browse/HIVE-19507 Project: Hive

[jira] [Created] (HIVE-19508) SparkJobMonitor getReport doesn't print stage progress in order

2018-05-11 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-19508: --- Summary: SparkJobMonitor getReport doesn't print stage progress in order Key: HIVE-19508 URL: https://issues.apache.org/jira/browse/HIVE-19508 Project: Hive

Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work with information schema

2018-05-11 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67102/ --- Review request for hive. Repository: hive-git Description --- See