[jira] [Created] (HIVE-22541) Inconsistent decimal precision/scale of resultset schema in analyzer.genLogicalPlan() as compared to analyzer.analyze()

2019-11-25 Thread Shubham Chaurasia (Jira)
Shubham Chaurasia created HIVE-22541:


 Summary: Inconsistent decimal precision/scale of resultset schema 
in analyzer.genLogicalPlan() as compared to analyzer.analyze()
 Key: HIVE-22541
 URL: https://issues.apache.org/jira/browse/HIVE-22541
 Project: Hive
  Issue Type: Bug
  Components: Query Planning
Affects Versions: 4.0.0
Reporter: Shubham Chaurasia
Assignee: Shubham Chaurasia


https://issues.apache.org/jira/browse/HIVE-21641 handles decimal 
scale/precision inconsistencies when we query using llap external client.

[HIVE-21641 
changes|https://issues.apache.org/jira/secure/attachment/12968006/HIVE-21641.4.patch]
 {{analyzer.genLogicalPlan(ast)}} to {{analyzer.analyze(ast, ctx)}} to handle 
this. However we should fix {{analyzer.genLogicalPlan(ast)}} to return correct 
decimal precision/scale. 
Please see 
[this|https://issues.apache.org/jira/browse/HIVE-21641?focusedCommentId=16981513=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16981513]
 and 
[this|https://issues.apache.org/jira/browse/HIVE-21641?focusedCommentId=16982053=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16982053]
 comment for more.

cc [~jcamachorodriguez] [~kgyrtkirk]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HIVE-22540) Vectorization: Decimal64 columns don't work with VectorizedBatchUtil.makeLikeColumnVector(ColumnVector)

2019-11-25 Thread Gopal Vijayaraghavan (Jira)
Gopal Vijayaraghavan created HIVE-22540:
---

 Summary: Vectorization: Decimal64 columns don't work with 
VectorizedBatchUtil.makeLikeColumnVector(ColumnVector)
 Key: HIVE-22540
 URL: https://issues.apache.org/jira/browse/HIVE-22540
 Project: Hive
  Issue Type: Bug
  Components: Vectorization
Reporter: Gopal Vijayaraghavan


{code}
if (source instanceof Decimal64ColumnVector) {
  Decimal64ColumnVector dec64ColVector = (Decimal64ColumnVector) source;
  return new DecimalColumnVector(dec64ColVector.vector.length,
  dec64ColVector.precision,
  dec64ColVector.scale);
}
{code}

This means that the operators need to change between the original and copy of 
the vector shapes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 71779: HIVE-22507

2019-11-25 Thread Krisztian Kasa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71779/
---

Review request for hive, Jesús Camacho Rodríguez and Zoltan Haindrich.


Bugs: HIVE-22507
https://issues.apache.org/jira/browse/HIVE-22507


Repository: hive-git


Description
---

KeyWrapper comparator create field comparator instances at every comparison


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java b3ab7015b7 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
 ab1cfdcdb5 


Diff: https://reviews.apache.org/r/71779/diff/1/


Testing
---

Run topnkey.q using TestMiniLlapLocalCliDriver


Thanks,

Krisztian Kasa



[jira] [Created] (HIVE-22539) HiveServer2 SPNEGO authentication should skip if header is empty

2019-11-25 Thread Kevin Risden (Jira)
Kevin Risden created HIVE-22539:
---

 Summary: HiveServer2 SPNEGO authentication should skip if header 
is empty
 Key: HIVE-22539
 URL: https://issues.apache.org/jira/browse/HIVE-22539
 Project: Hive
  Issue Type: Improvement
Reporter: Kevin Risden
Assignee: Kevin Risden


Currently HiveServer2 SPNEGO authentication waits until setting up Kerberos 
before checking header. This can be checked up front to avoid doing any 
Kerberos related work if the header is empty. This is helpful in a lot of cases 
since typically the first request is empty with the client waiting for a 401 
before returning the Authorization header.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2019-11-25 Thread Jesus Camacho Rodriguez (Jira)
Jesus Camacho Rodriguez created HIVE-22538:
--

 Summary: RS deduplication does not always enforce 
hive.optimize.reducededuplication.min.reducer
 Key: HIVE-22538
 URL: https://issues.apache.org/jira/browse/HIVE-22538
 Project: Hive
  Issue Type: Bug
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


For transactional tables, that property might be overriden to 1, which can lead 
to merging final aggregation into a single stage (hence leading to performance 
degradation). For instance, when autogather column stats is enabled, this can 
happen for the following query:

{code}
set hive.support.concurrency=true;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;

EXPLAIN
CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
SELECT * FROM SRC x CLUSTER BY x.key;
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Making a storage-api 2.7.1 release

2019-11-25 Thread Jesus Camacho Rodriguez
I went through the list of changes that were pushed to storage-api since
last release and there does not seem to be anything that is critical to
backport.

Thanks,
-Jesús

On Mon, Nov 25, 2019 at 8:43 AM Owen O'Malley 
wrote:

> All,
>I'd like to make a storage-api 2.7.1 release with HIVE-22405. Does
> anyone have any other patches that they'd like to include?
>
> Thanks,
>Owen
>


[jira] [Created] (HIVE-22537) getAcidState() not saving directory snapshot causes multiple calls to S3 api

2019-11-25 Thread Mustafa Iman (Jira)
Mustafa Iman created HIVE-22537:
---

 Summary: getAcidState() not saving directory snapshot causes 
multiple calls to S3 api
 Key: HIVE-22537
 URL: https://issues.apache.org/jira/browse/HIVE-22537
 Project: Hive
  Issue Type: Bug
Affects Versions: 4.0.0
Reporter: Mustafa Iman
Assignee: Mustafa Iman


Fix for HIVE-21225 is not enabled in query coordinator codepath. The last 
argument (generateDirSnapshots) for getAcidState() is set to false when invoked 
by callInternal(). Also, snapshot is not used for file exists calls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Making a storage-api 2.7.1 release

2019-11-25 Thread Owen O'Malley
All,
   I'd like to make a storage-api 2.7.1 release with HIVE-22405. Does
anyone have any other patches that they'd like to include?

Thanks,
   Owen


[jira] [Created] (HIVE-22536) Improve return path enabling/disabling

2019-11-25 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-22536:
-

 Summary: Improve return path enabling/disabling
 Key: HIVE-22536
 URL: https://issues.apache.org/jira/browse/HIVE-22536
 Project: Hive
  Issue Type: Sub-task
  Components: Hive
Reporter: Miklos Gergely
Assignee: Miklos Gergely
 Fix For: 4.0.0


Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
on/off/supported. In case of "supported" it should be used for a subset of 
commands which are already verified to be able to work with return path. This 
is a temporary solution for the time while we are developing return path, 
before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HIVE-22535) ACID: Check for already running compactions in Worker

2019-11-25 Thread Laszlo Pinter (Jira)
Laszlo Pinter created HIVE-22535:


 Summary: ACID: Check for already running compactions in Worker 
 Key: HIVE-22535
 URL: https://issues.apache.org/jira/browse/HIVE-22535
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Laszlo Pinter
Assignee: Laszlo Pinter


Compactor worker doesn't check if a compaction is already running for a given 
resource. Initiator does this, but in case of manual compaction, this check is 
missing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

2019-11-25 Thread Laszlo Pinter via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71812/
---

Review request for hive, Denys Kuzmenko and Peter Vary.


Repository: hive-git


Description
---

HIVE-22534: ACID: Improve Compactor thread logging


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 
ee2c0f3e23ed716f3de0a2740a96a7ec39251bc2 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java 
10681c0202a32c338e58b3e2eede03657a00774f 
  
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java 
f7e0a85c1f595bb4f112aa051779db3f00c8e572 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java 
80119de22f602d9e3cb7a1f60b48e05a37c6a047 
  
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java 
41cb4b64fbc79dcf81919769c567b26a2e18cfe5 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java 
3270175a80992e0efb1e0bfd1f33ffd8a96fcf87 


Diff: https://reviews.apache.org/r/71812/diff/1/


Testing
---


Thanks,

Laszlo Pinter



[jira] [Created] (HIVE-22534) ACID: Improve Compactor thread logging

2019-11-25 Thread Laszlo Pinter (Jira)
Laszlo Pinter created HIVE-22534:


 Summary: ACID: Improve Compactor thread logging
 Key: HIVE-22534
 URL: https://issues.apache.org/jira/browse/HIVE-22534
 Project: Hive
  Issue Type: Bug
Reporter: Laszlo Pinter
Assignee: Laszlo Pinter


Make sure that it is easy to find issues when one of the compactor thread fails.

Maybe:
 * MDC - with iteration / threadname - so we can easily grep the logs for a 
given run
 * MDC with table/partition data on which the worker is working



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HIVE-22533) Fix possible LLAP daemon web UI vulnerabilities

2019-11-25 Thread Jira
Ádám Szita created HIVE-22533:
-

 Summary: Fix possible LLAP daemon web UI vulnerabilities
 Key: HIVE-22533
 URL: https://issues.apache.org/jira/browse/HIVE-22533
 Project: Hive
  Issue Type: Improvement
  Components: llap
Reporter: Ádám Szita
Assignee: Ádám Szita


Security tools that look for possible vulnerabilities find issues with LLAP 
daemon web UI:
 * *dir listing* for _images,css,js_ folders 

 * *missing X-Frame-Options response header* in the response

Similarly we should disable dir listing on HS2 web UI /static page too, as it 
is of no use anyway.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 71811: Extract Compiler from Driver

2019-11-25 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71811/
---

Review request for hive and Zoltan Haindrich.


Bugs: HIVE-22526
https://issues.apache.org/jira/browse/HIVE-22526


Repository: hive-git


Description
---

The Driver class contains ~600 lines of code responsible for compiling the 
command. That means that from the command String a Plan needs to be created, 
and also a transaction needs to be started (in most of the cases). This is a 
thing done by the compile function, which has a lot of sub functions to help 
this task, while itself is also really big. All these codes should be put into 
a separate class, where it can do it's job without getting mixed with the other 
codes in the Driver.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/Compiler.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java bb41c15bb4 
  ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1afcfc8969 


Diff: https://reviews.apache.org/r/71811/diff/1/


Testing
---

All the tests are still running fine.


Thanks,

Miklos Gergely