[jira] [Created] (HIVE-2111) NullPointerException on select * with table using RegexSerDe and partitions

2011-04-12 Thread Marc Harris (JIRA)
NullPointerException on select * with table using RegexSerDe and partitions
---

 Key: HIVE-2111
 URL: https://issues.apache.org/jira/browse/HIVE-2111
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Affects Versions: 0.7.0
 Environment: Amazon Elastic Mapreduce
Reporter: Marc Harris


When querying against a table that is partitioned, and uses RegexSerde, select 
with explicit columns works, but select * results in a NullPointerException

To reproduce:

1) create a table containing the following text (notice the blank line):
start
fillerdatafillerdatafiller

fillerdata2fillerdata2filler
=end=

2) copy the file to hdfs:
hadoop dfs -put foo.txt test/part1=x/foo.txt

3) run the following hive commands to create a table:

add jar s3://elasticmapreduce/samples/hive/jars/hive_contrib.jar;

drop table test;

create external table test(col1 STRING, col2 STRING) 
partitioned by (part1 STRING) 
row format serde 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' 
with serdeproperties ( input.regex = ^\(.*data\)(.*data\).*$) 
stored as textfile 
location 'hdfs:///user/hadoop/test';

alter table test add partition (part1='x');

4) select from it with explicit columns:
select part1, col1, col2 from test;
outputs:
OK
x   fillerdata  fillerdata
x   NULLNULL
x   fillerdata  2fillerdata

5) select from it with * columns
select * from test;
outputs:

Failed with exception java.io.IOException:java.lang.NullPointerException
11/04/12 14:28:27 ERROR CliDriver: Failed with exception 
java.io.IOException:java.lang.NullPointerException
java.io.IOException: java.lang.NullPointerException
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:149)
at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1039)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:172)
at 
org.apache.hadoop.hive.cli.CliDriver.processLineInternal(CliDriver.java:228)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:209)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:398)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
Caused by: java.lang.NullPointerException
at java.util.ArrayList.addAll(ArrayList.java:472)
at 
org.apache.hadoop.hive.serde2.objectinspector.UnionStructObjectInspector.getStructFieldsDataAsList(UnionStructObjectInspector.java:144)
at 
org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:357)
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:141)
... 10 more


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2111) NullPointerException on select * with table using RegexSerDe and partitions

2011-04-12 Thread Marc Harris (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marc Harris updated HIVE-2111:
--

Description: 
When querying against a table that is partitioned, and uses RegexSerde, select 
with explicit columns works, but select * results in a NullPointerException

To reproduce:

1) create a table containing the following text (notice the blank line):
start
fillerdatafillerdatafiller

fillerdata2fillerdata2filler
=end=

2) copy the file to hdfs:
hadoop dfs -put foo.txt test/part1=x/foo.txt

3) run the following hive commands to create a table:

add jar s3://elasticmapreduce/samples/hive/jars/hive_contrib.jar;

drop table test;

create external table test(col1 STRING, col2 STRING) 
partitioned by (part1 STRING) 
row format serde 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' 
with serdeproperties ( input.regex = ^\(.*data\)\(.*data\).*$) 
stored as textfile 
location 'hdfs:///user/hadoop/test';

alter table test add partition (part1='x');

(Note that the text processor seems to have mangled the regex a bit. Inside 
each pair of parentheses should be dot star data. After the second pair of 
parentheses should be dot start dollar).

4) select from it with explicit columns:
select part1, col1, col2 from test;
outputs:
OK
x   fillerdata  fillerdata
x   NULLNULL
x   fillerdata  2fillerdata

5) select from it with * columns
select * from test;
outputs:

Failed with exception java.io.IOException:java.lang.NullPointerException
11/04/12 14:28:27 ERROR CliDriver: Failed with exception 
java.io.IOException:java.lang.NullPointerException
java.io.IOException: java.lang.NullPointerException
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:149)
at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1039)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:172)
at 
org.apache.hadoop.hive.cli.CliDriver.processLineInternal(CliDriver.java:228)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:209)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:398)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
Caused by: java.lang.NullPointerException
at java.util.ArrayList.addAll(ArrayList.java:472)
at 
org.apache.hadoop.hive.serde2.objectinspector.UnionStructObjectInspector.getStructFieldsDataAsList(UnionStructObjectInspector.java:144)
at 
org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:357)
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:141)
... 10 more


  was:
When querying against a table that is partitioned, and uses RegexSerde, select 
with explicit columns works, but select * results in a NullPointerException

To reproduce:

1) create a table containing the following text (notice the blank line):
start
fillerdatafillerdatafiller

fillerdata2fillerdata2filler
=end=

2) copy the file to hdfs:
hadoop dfs -put foo.txt test/part1=x/foo.txt

3) run the following hive commands to create a table:

add jar s3://elasticmapreduce/samples/hive/jars/hive_contrib.jar;

drop table test;

create external table test(col1 STRING, col2 STRING) 
partitioned by (part1 STRING) 
row format serde 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' 
with serdeproperties ( input.regex = ^\(.*data\)(.*data\).*$) 
stored as textfile 
location 'hdfs:///user/hadoop/test';

alter table test add partition (part1='x');

4) select from it with explicit columns:
select part1, col1, col2 from test;
outputs:
OK
x   fillerdata  fillerdata
x   NULLNULL
x   fillerdata  2fillerdata

5) select from it with * columns
select * from test;
outputs:

Failed with exception java.io.IOException:java.lang.NullPointerException
11/04/12 14:28:27 ERROR CliDriver: Failed with exception 
java.io.IOException:java.lang.NullPointerException
java.io.IOException: java.lang.NullPointerException
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:149)
at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1039)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:172)
at 
org.apache.hadoop.hive.cli.CliDriver.processLineInternal(CliDriver.java:228)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:209)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:398)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 

[jira] [Commented] (HIVE-2038) Metastore listener

2011-04-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018877#comment-13018877
 ] 

jirapos...@reviews.apache.org commented on HIVE-2038:
-



bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, 
line 999
bq.   https://reviews.apache.org/r/581/diff/1/?file=15625#file15625line999
bq.  
bq.   Unrelated bugfix?

Related bugfix, I will say : ) Without it, when drop partition returns from 
object store, partition object doesn't contain partition values. 


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 180
bq.   https://reviews.apache.org/r/581/diff/1/?file=15621#file15621line180
bq.  
bq.   Please add this property to hive-default.xml along with a 
description of what it does.
bq.  

Will add it in hive-default.xml.


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, 
line 955
bq.   https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line955
bq.  
bq.   Please run checkstyle and correct any violations included in your 
patch.

Will run checkstyle to check for any style violations.


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
 line 27
bq.   https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line27
bq.  
bq.   Please add some javadoc explaining the intended use of this 
interface. 
bq.   
bq.   * Are the methods called before or after an action completes? What 
happens if a metastore operation fails?
bq.   
bq.   * Are the methods allowed to block? Are they run in a separate 
thread?
bq.   
bq.   * Are the methods allowed to modify the catalog objects that are 
passed in as parameters?

Will also add in javadoc.
 
 * Methods are called after action completes. Only if action succeeds. They are 
not called if operation fails since in that case nothing has actually changed 
in metastore.

 * This is upto implementation. They can run in same thread, or they can 
schedule there work in separate thread and return immediately. 

 * I don't see a reason to disallow modification of passed in parameter 
objects. But, its mostly irrelevant here since methods are called after change 
has already been persisted on metastore. So, modifying these objects can't 
change any state on metastore. 


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
 line 29
bq.   https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line29
bq.  
bq.   Instead of passing in raw Table/Partition/Database objects it may be 
better to instead wrap these objects in containers, e.g. CreateTableEvent, 
DropTableEvent, etc. Eventually this interface will probably include 
onAlterTable() and onAlterPartition(), and programmers will probably want to 
access both the before and after versions of a Table/Partition, etc.

Whats the advantage of wrapper container objects?


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, 
line 1446
bq.   https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line1446
bq.  
bq.   No need to reference this, right?

Right. Though, I think using this in such cases improves code readability. 


bq.  On 2011-04-12 03:07:54, Carl Steinbach wrote:
bq.   
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
 line 26
bq.   https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line26
bq.  
bq.   What do you think about changing the name to MetaStoreEventListener 
or CatalogEventListener?

MetaStoreEventListener is fine too.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/581/#review428
---


On 2011-04-12 01:29:41, Ashutosh Chauhan wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/581/
bq.  ---
bq.  
bq.  (Updated 2011-04-12 01:29:41)
bq.  
bq.  
bq.  Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Review request for HIVE-2038
bq.  
bq.  
bq.  This addresses bug HIVE-2038.
bq.  https://issues.apache.org/jira/browse/HIVE-2038
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575 
bq.

Re: Review Request: Review request for HIVE-2038

2011-04-12 Thread Ashutosh Chauhan


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, 
  line 999
  https://reviews.apache.org/r/581/diff/1/?file=15625#file15625line999
 
  Unrelated bugfix?

Related bugfix, I will say : ) Without it, when drop partition returns from 
object store, partition object doesn't contain partition values. 


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 180
  https://reviews.apache.org/r/581/diff/1/?file=15621#file15621line180
 
  Please add this property to hive-default.xml along with a description 
  of what it does.
 

Will add it in hive-default.xml.


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
   line 955
  https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line955
 
  Please run checkstyle and correct any violations included in your patch.

Will run checkstyle to check for any style violations.


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
   line 27
  https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line27
 
  Please add some javadoc explaining the intended use of this interface. 
  
  * Are the methods called before or after an action completes? What 
  happens if a metastore operation fails?
  
  * Are the methods allowed to block? Are they run in a separate thread?
  
  * Are the methods allowed to modify the catalog objects that are passed 
  in as parameters?

Will also add in javadoc.
 
 * Methods are called after action completes. Only if action succeeds. They are 
not called if operation fails since in that case nothing has actually changed 
in metastore.

 * This is upto implementation. They can run in same thread, or they can 
schedule there work in separate thread and return immediately. 

 * I don't see a reason to disallow modification of passed in parameter 
objects. But, its mostly irrelevant here since methods are called after change 
has already been persisted on metastore. So, modifying these objects can't 
change any state on metastore. 


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
   line 29
  https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line29
 
  Instead of passing in raw Table/Partition/Database objects it may be 
  better to instead wrap these objects in containers, e.g. CreateTableEvent, 
  DropTableEvent, etc. Eventually this interface will probably include 
  onAlterTable() and onAlterPartition(), and programmers will probably want 
  to access both the before and after versions of a Table/Partition, etc.

Whats the advantage of wrapper container objects?


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
   line 1446
  https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line1446
 
  No need to reference this, right?

Right. Though, I think using this in such cases improves code readability. 


 On 2011-04-12 03:07:54, Carl Steinbach wrote:
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java,
   line 26
  https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line26
 
  What do you think about changing the name to MetaStoreEventListener or 
  CatalogEventListener?

MetaStoreEventListener is fine too.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/581/#review428
---


On 2011-04-12 01:29:41, Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/581/
 ---
 
 (Updated 2011-04-12 01:29:41)
 
 
 Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.
 
 
 Summary
 ---
 
 Review request for HIVE-2038
 
 
 This addresses bug HIVE-2038.
 https://issues.apache.org/jira/browse/HIVE-2038
 
 
 Diffs
 -
 
   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
 1079575 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
  PRE-CREATION 
   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java 
 PRE-CREATION 
   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
 1079575 
   
 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 
 PRE-CREATION 
   
 

[jira] [Updated] (HIVE-1803) Implement bitmap indexing in Hive

2011-04-12 Thread Marquis Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marquis Wang updated HIVE-1803:
---

Attachment: unit-tests.3.patch

New patch for unit tests that hopefully shouldn't conflict this time.

I looked into changing the code so that the outputColumnNames in explains are 
not affected by virtual columns, but didn't really get anywhere. Besides, 
wouldn't I have the same problem with commits since the unit tests were changed 
for the first two virtual columns added?

I figured I'd go ahead and submit this patch again and if you thought I should 
keep on looking into that you can not accept it. :-)

 Implement bitmap indexing in Hive
 -

 Key: HIVE-1803
 URL: https://issues.apache.org/jira/browse/HIVE-1803
 Project: Hive
  Issue Type: New Feature
  Components: Indexing
Reporter: Marquis Wang
Assignee: Marquis Wang
 Attachments: HIVE-1803.1.patch, HIVE-1803.10.patch, 
 HIVE-1803.11.patch, HIVE-1803.2.patch, HIVE-1803.3.patch, HIVE-1803.4.patch, 
 HIVE-1803.5.patch, HIVE-1803.6.patch, HIVE-1803.7.patch, HIVE-1803.8.patch, 
 HIVE-1803.9.patch, JavaEWAH_20110304.zip, bitmap_index_1.png, 
 bitmap_index_2.png, javaewah.jar, javaewah.jar, unit-tests.2.patch, 
 unit-tests.3.patch, unit-tests.patch


 Implement bitmap index handler to complement compact indexing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1803) Implement bitmap indexing in Hive

2011-04-12 Thread Marquis Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marquis Wang updated HIVE-1803:
---

Status: Patch Available  (was: Open)

 Implement bitmap indexing in Hive
 -

 Key: HIVE-1803
 URL: https://issues.apache.org/jira/browse/HIVE-1803
 Project: Hive
  Issue Type: New Feature
  Components: Indexing
Reporter: Marquis Wang
Assignee: Marquis Wang
 Attachments: HIVE-1803.1.patch, HIVE-1803.10.patch, 
 HIVE-1803.11.patch, HIVE-1803.2.patch, HIVE-1803.3.patch, HIVE-1803.4.patch, 
 HIVE-1803.5.patch, HIVE-1803.6.patch, HIVE-1803.7.patch, HIVE-1803.8.patch, 
 HIVE-1803.9.patch, JavaEWAH_20110304.zip, bitmap_index_1.png, 
 bitmap_index_2.png, javaewah.jar, javaewah.jar, unit-tests.2.patch, 
 unit-tests.3.patch, unit-tests.patch


 Implement bitmap index handler to complement compact indexing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Hive Client is indefenitely waiting for reading from Socket

2011-04-12 Thread Chinna
Hi All,

Hive Client is indefinitely waiting for reading from Socket. Thread dump is
added below.

Cause is:
 
In the HiveClient, when client socket is created, the read timeout
is mentioned is 0. So the socket will indefinitely wait when the machine
where Hive Server is running is shutdown or network is unplugged. The
same may not happen if the HiveServer alone is killed or gracefully
shutdown. At this time, client will get connection reset exception. 

Code in HiveConnection
---
transport = new TSocket(host, port);
TProtocol protocol = new TBinaryProtocol(transport); client = new
HiveClient(protocol);

In the Client side, they send the query and wait for the response
send_execute(query, id); recv_execute(); // place where client waiting is
initiated

Here we cannot give a time out for socket also, because Query may execute
for long time. The query execution time cannot be predetermined. 

Any suggestions for fixing this issue.

For this I have raised an issue HIVE-2110.

Thread dump:

main prio=10 tid=0x40111000 nid=0x3641 runnable
[0x7f0d73f29000]
java.lang.Thread.State: RUNNABLE
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:129)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:218)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:258)
at java.io.BufferedInputStream.read(BufferedInputStream.java:317) 

locked 0x7f0d5d3f0828 (a java.io.BufferedInputStream)
at
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:
125)
at
org.apache.thrift.transport.TTransport.readAll(TTransport.java:84)
at
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:314)
at
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:262)
at
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.
java:192)
at
org.apache.hadoop.hive.service.ThriftHive$Client.recv_execute(ThriftHive.jav
a:130)
at
org.apache.hadoop.hive.service.ThriftHive$Client.execute(ThriftHive.java:109
) 
locked 0x7f0d5d3f0878 (a org.apache.thrift.transport.TSocket)
at
org.apache.hadoop.hive.jdbc.HiveStatement.executeQuery(HiveStatement.java:21
8)
at
org.apache.hadoop.hive.jdbc.HiveStatement.execute(HiveStatement.java:154)
at com.huawei.isap.i3.HiveJdbcClient.main(HiveJdbcClient.java:114)


Thanks  Regards,
Chinna Rao Lalam




[jira] [Updated] (HIVE-2107) Log4J initialization info should not be printed out if -S is specified

2011-04-12 Thread Namit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Namit Jain updated HIVE-2107:
-

  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

Committed. Thanks Ning

 Log4J initialization info should not be printed out if -S is specified
 --

 Key: HIVE-2107
 URL: https://issues.apache.org/jira/browse/HIVE-2107
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
Priority: Minor
 Attachments: HIVE-2107.patch


 SessionState.initHiveLog4j() is called before hive command argument -S is 
 parsed, so initHiveLog4j will printed out the init info even though -S is 
 specified.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1803) Implement bitmap indexing in Hive

2011-04-12 Thread John Sichi (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13018988#comment-13018988
 ] 

John Sichi commented on HIVE-1803:
--

I'm already seeing at least one test failures:  auto_join28.q, which recently 
got its log updated (Friday) so you probably rebased before that.  It's really 
difficult to get something like this through without locking down svn for a few 
days...

You have a point about the unit tests; we would have to special-case the new 
column and leaving the existing ones as is.  Ugly any way you slice it.


 Implement bitmap indexing in Hive
 -

 Key: HIVE-1803
 URL: https://issues.apache.org/jira/browse/HIVE-1803
 Project: Hive
  Issue Type: New Feature
  Components: Indexing
Reporter: Marquis Wang
Assignee: Marquis Wang
 Attachments: HIVE-1803.1.patch, HIVE-1803.10.patch, 
 HIVE-1803.11.patch, HIVE-1803.2.patch, HIVE-1803.3.patch, HIVE-1803.4.patch, 
 HIVE-1803.5.patch, HIVE-1803.6.patch, HIVE-1803.7.patch, HIVE-1803.8.patch, 
 HIVE-1803.9.patch, JavaEWAH_20110304.zip, bitmap_index_1.png, 
 bitmap_index_2.png, javaewah.jar, javaewah.jar, unit-tests.2.patch, 
 unit-tests.3.patch, unit-tests.patch


 Implement bitmap index handler to complement compact indexing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Build failed in Jenkins: Hive-trunk-h0.20 #668

2011-04-12 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/Hive-trunk-h0.20/668/

--
Started by an SCM change
Building remotely on ubuntu1
FATAL: cannot assign instance of hudson.model.StreamBuildListener to field 
hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type 
hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask
java.lang.ClassCastException: cannot assign instance of 
hudson.model.StreamBuildListener to field 
hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type 
hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask
at 
java.io.ObjectStreamClass$FieldReflector.setObjFieldValues(ObjectStreamClass.java:2056)
at 
java.io.ObjectStreamClass.setObjFieldValues(ObjectStreamClass.java:1229)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1969)
at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963)
at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:368)
at hudson.remoting.UserRequest.deserialize(UserRequest.java:178)
at hudson.remoting.UserRequest.perform(UserRequest.java:98)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:636)



Jenkins build is back to normal : Hive-0.7.0-h0.20 #74

2011-04-12 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/Hive-0.7.0-h0.20/74/




[jira] [Updated] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data

2011-04-12 Thread Devaraj Das (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devaraj Das updated HIVE-1943:
--

Assignee: Devaraj Das
 Summary: Metastore operations (like drop_partition) could be improved in 
terms of maintaining consistency of metadata and data  (was: Metastore 
operations should do a 'rollback' for HDFS failures)

 Metastore operations (like drop_partition) could be improved in terms of 
 maintaining consistency of metadata and data
 -

 Key: HIVE-1943
 URL: https://issues.apache.org/jira/browse/HIVE-1943
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Devaraj Das
Assignee: Devaraj Das

 Currently, metastore operations with associated hdfs operations like 
 drop_partition doesn't do a rollback if the hdfs operation fails. The 
 metastore first updates the metadata, and then tries to do hdfs operation. If 
 the hdfs operation fails for any reason, the data on the hdfs will be 
 orphaned. We should improve the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data

2011-04-12 Thread Devaraj Das (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019083#comment-13019083
 ] 

Devaraj Das commented on HIVE-1943:
---

Created a reviewboard review request - https://reviews.apache.org/r/586/

The patch basically adds checks before updating metadata during operations like 
drop_table, drop_database, etc. The checks are at the Warehouse layer to see 
whether the associated data can be really deleted by the user in question. If 
the data can't be deleted then the metadata operation is not done. 

This check is configurable and can be disabled.

 Metastore operations (like drop_partition) could be improved in terms of 
 maintaining consistency of metadata and data
 -

 Key: HIVE-1943
 URL: https://issues.apache.org/jira/browse/HIVE-1943
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Devaraj Das
Assignee: Devaraj Das

 Currently, metastore operations with associated hdfs operations like 
 drop_partition doesn't do a rollback if the hdfs operation fails. The 
 metastore first updates the metadata, and then tries to do hdfs operation. If 
 the hdfs operation fails for any reason, the data on the hdfs will be 
 orphaned. We should improve the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data

2011-04-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019086#comment-13019086
 ] 

jirapos...@reviews.apache.org commented on HIVE-1943:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/
---

Review request for hive.


Summary
---

This is a patch to handle the issue described in HIVE-1943


This addresses bug HIVE-1943.
https://issues.apache.org/jira/browse/HIVE-1943


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 1090038 
  http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
 1090038 

Diff: https://reviews.apache.org/r/586/diff


Testing
---

Unit tests added.


Thanks,

Devaraj



 Metastore operations (like drop_partition) could be improved in terms of 
 maintaining consistency of metadata and data
 -

 Key: HIVE-1943
 URL: https://issues.apache.org/jira/browse/HIVE-1943
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Devaraj Das
Assignee: Devaraj Das

 Currently, metastore operations with associated hdfs operations like 
 drop_partition doesn't do a rollback if the hdfs operation fails. The 
 metastore first updates the metadata, and then tries to do hdfs operation. If 
 the hdfs operation fails for any reason, the data on the hdfs will be 
 orphaned. We should improve the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Review Request: HIVE-1943

2011-04-12 Thread Devaraj Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/
---

Review request for hive.


Summary
---

This is a patch to handle the issue described in HIVE-1943


This addresses bug HIVE-1943.
https://issues.apache.org/jira/browse/HIVE-1943


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 1090038 
  http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
 1090038 
  
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
 1090038 

Diff: https://reviews.apache.org/r/586/diff


Testing
---

Unit tests added.


Thanks,

Devaraj



[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019119#comment-13019119
 ] 

He Yongqiang commented on HIVE-2090:


2 nitpick:

1, do not remove the existing  constructor DropDatabaseDesc(String 
databaseName, boolean ifExists) {

2, remove TOK_RESTRICT if it has the same meaning with TOK_CASCADE. Use just 
one of them.  if (null != ast.getFirstChildWithType(TOK_CASCADE)) seems only 
checked TOK_CASCADE. 

3. there is no testcase?

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019120#comment-13019120
 ] 

He Yongqiang commented on HIVE-2090:


sorry, just noticed that there is one testcase. pls ignore 3.

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019134#comment-13019134
 ] 

He Yongqiang commented on HIVE-2090:


ok. got that TOK_RESTRICT has different meaning with TOK_CASCADE.

will start running tests.

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread Carl Steinbach (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Steinbach updated HIVE-2090:
-

Component/s: Metastore

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission

2011-04-12 Thread Carl Steinbach (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Steinbach updated HIVE-2093:
-

Component/s: Security
 Metastore

 create/drop database should populate inputs/outputs and check concurrency and 
 user permission
 -

 Key: HIVE-2093
 URL: https://issues.apache.org/jira/browse/HIVE-2093
 Project: Hive
  Issue Type: Bug
  Components: Metastore, Security
Reporter: Namit Jain
Assignee: Siying Dong
 Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch


 concurrency and authorization are needed for create/drop table. Also to make 
 concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS 
 DATABASE

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread Siying Dong (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siying Dong updated HIVE-2090:
--

Attachment: HIVE-2090.4.patch

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread Siying Dong (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siying Dong updated HIVE-2090:
--

Status: Patch Available  (was: Open)

add constructor DropdatabaseDesc(String databaseName, boolean ifExists) and 
rebase.

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: Review Request: HIVE-2090: Add DROP DATABASE ... FORCE

2011-04-12 Thread Carl Steinbach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/#review393
---



trunk/metastore/if/hive_metastore.thrift
https://reviews.apache.org/r/551/#comment743

Does changing the Thrift IDL like this break backwards compatibility with 
older clients?



trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
https://reviews.apache.org/r/551/#comment744

Missing @param force...



- Carl


On 2011-04-06 01:01:26, Carl Steinbach wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/551/
 ---
 
 (Updated 2011-04-06 01:01:26)
 
 
 Review request for hive.
 
 
 Summary
 ---
 
 https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
 
 
 This addresses bug HIVE-2090.
 https://issues.apache.org/jira/browse/HIVE-2090
 
 
 Diffs
 -
 
   trunk/metastore/if/hive_metastore.thrift 1088810 
   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1088810 
   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1088810 
   
 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
  1088810 
   
 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
  1088810 
   
 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
 1088810 
   
 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
  1088810 
   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
 1088810 
   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1088810 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
 1088810 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
  1088810 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
  1088810 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1088810 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1088810 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
 1088810 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1088810 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 
 1088810 
   trunk/ql/src/test/queries/clientpositive/database.q 1088810 
   trunk/ql/src/test/results/clientpositive/database.q.out 1088810 
 
 Diff: https://reviews.apache.org/r/551/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Carl
 




[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019147#comment-13019147
 ] 

jirapos...@reviews.apache.org commented on HIVE-2090:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/#review393
---



trunk/metastore/if/hive_metastore.thrift
https://reviews.apache.org/r/551/#comment743

Does changing the Thrift IDL like this break backwards compatibility with 
older clients?



trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
https://reviews.apache.org/r/551/#comment744

Missing @param force...



- Carl


On 2011-04-06 01:01:26, Carl Steinbach wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/551/
bq.  ---
bq.  
bq.  (Updated 2011-04-06 01:01:26)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
bq.  
bq.  
bq.  This addresses bug HIVE-2090.
bq.  https://issues.apache.org/jira/browse/HIVE-2090
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/metastore/if/hive_metastore.thrift 1088810 
bq.trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1088810 
bq.trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1088810 
bq.
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1088810 
bq.
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1088810 
bq.
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1088810 
bq.
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1088810 
bq.
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1088810 
bq.trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1088810 
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1088810 
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1088810 
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1088810 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1088810 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1088810 
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1088810 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1088810 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 
1088810 
bq.trunk/ql/src/test/queries/clientpositive/database.q 1088810 
bq.trunk/ql/src/test/results/clientpositive/database.q.out 1088810 
bq.  
bq.  Diff: https://reviews.apache.org/r/551/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Carl
bq.  
bq.



 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread Siying Dong (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siying Dong updated HIVE-2090:
--

Attachment: HIVE-2090.5.patch

add parameter description in comment of dropDatabase()

 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch, HIVE-2090.5.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: Review Request: HIVE-2090: Add DROP DATABASE ... FORCE

2011-04-12 Thread Carl Steinbach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
---

(Updated 2011-04-13 01:04:53.612739)


Review request for hive.


Changes
---

Updating diff with 
https://issues.apache.org/jira/secure/attachment/12476195/HIVE-2090.4.patch


Summary
---

https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch


This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090


Diffs (updated)
-

  trunk/metastore/if/hive_metastore.thrift 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1091617 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1091617 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1091617 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1091617 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1091617 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 
1091617 
  trunk/ql/src/test/queries/clientpositive/database.q 1091617 
  trunk/ql/src/test/results/clientpositive/database.q.out 1091617 

Diff: https://reviews.apache.org/r/551/diff


Testing
---


Thanks,

Carl



[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE

2011-04-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019158#comment-13019158
 ] 

jirapos...@reviews.apache.org commented on HIVE-2090:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
---

(Updated 2011-04-13 01:04:53.612739)


Review request for hive.


Changes
---

Updating diff with 
https://issues.apache.org/jira/secure/attachment/12476195/HIVE-2090.4.patch


Summary
---

https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch


This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090


Diffs (updated)
-

  trunk/metastore/if/hive_metastore.thrift 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1091617 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1091617 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1091617 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1091617 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1091617 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 
1091617 
  trunk/ql/src/test/queries/clientpositive/database.q 1091617 
  trunk/ql/src/test/results/clientpositive/database.q.out 1091617 

Diff: https://reviews.apache.org/r/551/diff


Testing
---


Thanks,

Carl



 Add DROP DATABASE ... FORCE
 -

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch, HIVE-2090.5.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira