[jira] [Created] (HIVE-10665) Continue to make udaf_percentile_approx_23.q test more stable

2015-05-09 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10665:
--

 Summary: Continue to make udaf_percentile_approx_23.q test more 
stable
 Key: HIVE-10665
 URL: https://issues.apache.org/jira/browse/HIVE-10665
 Project: Hive
  Issue Type: Bug
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor


HIVE-10059 fixed line 628 in q.out
Similar issue exists on line 567 and should be fixed as well.
{code}
Running: diff -a 
/home/hiveptest/54.159.254.207-hiveptest-2/apache-github-source-source/itests/qtest/../../itests/qtest/target/qfile-results/clientpositive/udaf_percentile_approx_23.q.out
 
/home/hiveptest/54.159.254.207-hiveptest-2/apache-github-source-source/itests/qtest/../../ql/src/test/results/clientpositive/udaf_percentile_approx_23.q.out
567c567
 342.0
---
 341.5
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Window function possible perf improvement

2015-05-09 Thread Sivaramakrishnan Narayanan
Thanks, I'll take a look at latest changes in more detail. I'd only looked
at the specific function in trunk and it seemed unchanged from 0.13.

On Thu, May 7, 2015 at 7:50 PM, Ashutosh Chauhan hashut...@apache.org
wrote:

 Harish has done some good work for popular use-case of windowing on
 https://issues.apache.org/jira/browse/HIVE-7062 which are available from
 0.14 onwards. Will that be useful in your scenario? Or, are you targeting
 non-windowing PTFs?

 Thanks,
 Ashutosh

 On Thu, May 7, 2015 at 6:43 AM, Sivaramakrishnan Narayanan 
 tarb...@gmail.com wrote:

  Hi,
 
  I was reading through the PTFOperator and related code and was wondering
 if
  there is an opportunity to optimize this function in
  WindowingTableFunction.java
 
public void execute(PTFPartitionIteratorObject pItr, PTFPartition
  outP) throws HiveException {
 
   This guy iterates over the input partition once to compute
 outputColumns.
  This causes a full read of input partition.
 
  It then iterates over input partition again to append newly computed
  values. This causes another read of input partition and a write to output
  partition.
 
  I was wondering if it may be more efficient to append to the output
  partition as soon as window expressions have been computed. This will
 avoid
  one scan of the input partition.
 
  FYI - I've been looking at hive 0.13 code mostly but a glance at trunk
  suggests this logic is the same there.
 
  Thanks,
 
  Siva
 



[DISCUSS] Hive/HBase Integration

2015-05-09 Thread kulkarni.swar...@gmail.com
Hello all,

So last week, Myself, Brock Noland and Nick Dimiduk got a chance to present
some of the work we have been doing in the Hive/HBase integration space at
HBaseCon 2015 (slides here[1] for anyone interested). One of the
interesting things that we noted at this conference was that even though
this was an HBase conference, *SQL on HBase* was by far the most popular
theme with talks on Apache Phoenix, Trafodion, Apache Kylin, Apache Drill
and a SQL-On-HBase panel to compare these and other technologies.

I personally feel that with the existing work, we have come a long way but
still have work to do and would need more love to make this a top-notch
feature of Hive. However I was curious to know what the community thought
about it and where do they see this integration stand in coming time when
compared with all the other upcoming techs?

Thanks,
Swarnim

[1]
https://docs.google.com/presentation/d/1K2A2NMsNbmKWuG02aUDxsLo0Lal0lhznYy8SB6HjC9U/edit#slide=id.p


[jira] [Created] (HIVE-10664) Unit tests run fail in windows because of illegal escape character in file path

2015-05-09 Thread Hari Sankar Sivarama Subramaniyan (JIRA)
Hari Sankar Sivarama Subramaniyan created HIVE-10664:


 Summary: Unit tests run fail in windows because of  illegal escape 
character in file path
 Key: HIVE-10664
 URL: https://issues.apache.org/jira/browse/HIVE-10664
 Project: Hive
  Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan


{code:title=In windows we hit errors as shown below }
[ERROR] 
/D:/w/hv/itests/qtest/target/generated-test-sources/java/org/apache/hadoop/hive/cli/TestHBaseNegativeCliDriver.java:[97,54]
 illegal escape character
{code}

Specifically, the lines it is complaining about in the log, look like this:
{code:title=line 97 of 
/itests/qtest/target/generated-test-sources/java/org/apache/hadoop/hive/cli/TestHBaseNegativeCliDriver.java}
line 97:  
QTestUtil.addTestsToSuiteFromQfileNames(D:\w\hv\itests\qtest\target\generated-test-sources\java\org\apache\hadoop\hive\cli\TestHBaseNegativeCliDriverQFileNames.txt,
 qFilesToExecute,
{code}

It is executing the itests/qtests directory on the windows platform. It seems 
as if it is hitting a fairly simple portability problem, of the type that a 
small change will touch up all of them quickly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality

2015-05-09 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33881/#review83143
---



beeline/src/java/org/apache/hive/beeline/BeeLine.java
https://reviews.apache.org/r/33881/#comment134021

We might just call the next method in this method to avoid code duplication.



beeline/src/java/org/apache/hive/beeline/BeeLine.java
https://reviews.apache.org/r/33881/#comment134022

code style



beeline/src/java/org/apache/hive/beeline/BeeLine.java
https://reviews.apache.org/r/33881/#comment134024

I believe that currently Hive CLI is able to connect a metastore other than 
the embedded derby. Thus, we need to make sure that the embedded HS2 is also 
able to do that. It's unclear to me how is that achieved, maybe via 
hive-site.xml. Please verify this case is covered.


- Xuefu Zhang


On May 6, 2015, 6:32 a.m., cheng xu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/33881/
 ---
 
 (Updated May 6, 2015, 6:32 a.m.)
 
 
 Review request for hive and Xuefu Zhang.
 
 
 Bugs: HIVE-10623
 https://issues.apache.org/jira/browse/HIVE-10623
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Changes:
 1. Support the hive cli options including database, e, !, H, f.
 2. Add error handler for using f and e together
 3. Add error handler for invalid option
 
 
 Diffs
 -
 
   beeline/src/java/org/apache/hive/beeline/BeeLine.java b3d89cb 
   beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java 
 PRE-CREATION 
   beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION 
   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/33881/diff/
 
 
 Testing
 ---
 
 Newly add unit test passed locally.
 
 
 Thanks,
 
 cheng xu
 




HCatStorer throws error while storing Pig int into HCat bigint column

2015-05-09 Thread Suraj Nayak
Hi Hive/Pig Developers,

I had a question regarding storing integer data type of pig into bigint
data type column in HCat table.

When I try to run a pig script which stores int data into the bigint column
of hive it throws below error:

ERROR org.apache.pig.tools.grunt.Grunt - ERROR 1115: Unsupported type: 10
in Pig's schema

Is there a reason why auto handling of this is not done? As all integers
fit into bigint data type.

Let me know if this auto handling is good to have and do not harm any other
implementation in hive or pig. I can create a JIRA and contribute a patch
for this.

-- 
Thanks
Suraj Nayak M