Re: Review Request 58403: HIVE-16355 Service: embedded mode should only be available if service is loaded onto the classpath

> On July 7, 2017, 8:54 p.m., Vaibhav Gumashta wrote: > > > > Vaibhav Gumashta wrote: > Also, can you comment on the testing of this? since currently I've not modified anything - the regular tests see the same as before...it would be great to separate the hs2's classpath from the client c

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180255 --- Typo: The RB description says "HIVE-16966" but it should be HIVE-

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > > Any

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/#review180254 --- ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMer

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > > Any

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > > Any

Re: [DISCUSS] Separating out the metastore as its own TLP

>> I'd like to suggest Riven. (Owen O'Malley) > How about "Flora"? (Andrew Sherman) Nice idea and thanks for introducing me to that book, Andrew. Along the same lines, how about "Honeycomb"? But since the idea is to make the metastore useful for many projects, a generic name that starts with

[jira] [Created] (HIVE-17076) typo in itests/src/test/resources/testconfiguration.properties

Eugene Koifman created HIVE-17076: - Summary: typo in itests/src/test/resources/testconfiguration.properties Key: HIVE-17076 URL: https://issues.apache.org/jira/browse/HIVE-17076 Project: Hive

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

> On July 11, 2017, 10:16 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > > Line 1965 (original) > > > > > > Did you intend to remove

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60757/ --- (Updated July 11, 2017, 10:33 p.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60757/#review180251 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60757/ --- (Updated July 11, 2017, 10:07 p.m.) Review request for hive and Ashutosh Chauha

Re: [VOTE] storage-release-2.4.0rc1

+1. Checked the signatures, did a build with a fresh maven repo, ran rat. On Mon, Jul 10, 2017 at 11:58 PM, Pengcheng Xiong wrote: > Hi all, > >Here is a new release candidate for hive-storage-2.4.0 which Hive 2.3 > will depend on. Please take a look and vote. Thanks. > > Here is my +1 afte

Re: Review Request 59020: Support Parquet through HCatalog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59020/#review180234 --- Fix it, then Ship it! The patch looks good Adam. Please just ad

Re: Review Request 60468: HIVE-16888

> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_union.q.out > > Line 31 (original), 31 (patched) > > > > > > I am not sure if this filter simplification is correct fo

Re: Review Request 60468: HIVE-16888

> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/vector_date_1.q.out > > Line 594 (original), 594 (patched) > > > > > > seems like predicate: and (dt1 > 1970-01-01) and (

Re: Review Request 60468: HIVE-16888

> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/druid_basic2.q.out > > Line 837 (original), 837 (patched) > > > > > > Is this correct: extraction function should have be

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180227 --- .reviewboardrc Line 1 (original), 1 (patched)

Re: Review Request 60468: HIVE-16888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/#review180228 --- ql/src/test/results/clientpositive/druid_intervals.q.out Line 112

Re: Review Request 60776: HIVE-16907: "INSERT INTO" overwrite old data when destination table encapsulated by backquote

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60776/#review180224 --- ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.

[jira] [Created] (HIVE-17075) unstable stats in q files

Eugene Koifman created HIVE-17075: - Summary: unstable stats in q files Key: HIVE-17075 URL: https://issues.apache.org/jira/browse/HIVE-17075 Project: Hive Issue Type: Bug Reporter

Re: [DISCUSS] Separating out the metastore as its own TLP

On Fri, Jun 30, 2017 at 5:05 PM, Owen O'Malley wrote: > On Fri, Jun 30, 2017 at 3:26 PM, Chao Sun wrote: > > > and maybe a different project name? > > > > Yes, it certainly needs a new name. I'd like to suggest Riven. > > .. Owen > How about "Flora"? (Flora is the protagonist of The Bees by La

[jira] [Created] (HIVE-17074) PURGE option for DROP DATABASE

Muthu Manickam created HIVE-17074: - Summary: PURGE option for DROP DATABASE Key: HIVE-17074 URL: https://issues.apache.org/jira/browse/HIVE-17074 Project: Hive Issue Type: New Feature

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60757/#review180200 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/

Review Request 60776: HIVE-16907: "INSERT INTO" overwrite old data when destination table encapsulated by backquote

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60776/ --- Review request for hive. Bugs: HIVE-16907 https://issues.apache.org/jira/br

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60085/#review180194 --- Ship it! Ship It! - Peter Vary On June 14, 2017, 2:38 p.m.,

[jira] [Created] (HIVE-17073) Incorrect result with vectorization and SharedWorkOptimizer

Jesus Camacho Rodriguez created HIVE-17073: -- Summary: Incorrect result with vectorization and SharedWorkOptimizer Key: HIVE-17073 URL: https://issues.apache.org/jira/browse/HIVE-17073 Project

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 11, 2017, 10:05 a.m.) Review request for hive. Bugs: HIVE-16989

[jira] [Created] (HIVE-17072) Make the parallelized timeout configurable in BeeLine tests

Marta Kuczora created HIVE-17072: Summary: Make the parallelized timeout configurable in BeeLine tests Key: HIVE-17072 URL: https://issues.apache.org/jira/browse/HIVE-17072 Project: Hive Iss

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

> On July 11, 2017, 7:27 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java > > Line 63 (original) > > > > > > That's probably a bug? Thanks for the suggestion Gopal V. Looking a

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180168 --- ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java L

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 11, 2017, 7:13 a.m.) Review request for hive. Summary (updated)