Re: Review Request 66397: HIVE-19064

2018-04-14 Thread Jesús Camacho Rodríguez 


> On April 14, 2018, 5:19 p.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 3052 (patched)
> > 
> >
> > Current behavior is: single and double quotes for string literals and 
> > backticks for identifiers.
> > 
> > For string literals we can keep that as is, but for identifers we allow 
> > double quotes in addition to backticks than we can have "standard" as 
> > default. Which will imply that users can use double quotes for both 
> > literals as well as identifiers (which adheres to standard) as well as its 
> > still back compat where users may have used backticks for identifers and 
> > used double or single quotes for literals.

The problem is that then we end up with double quotes for two sets of 
expressions (both literals and identifiers), which will add complexity to the 
grammar (I run into ambiguity issues while I was writing the patch, I will take 
another look to have a more accurate definition of the problem I was facing).


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66397/#review201166
---


On April 3, 2018, 1:26 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66397/
> ---
> 
> (Updated April 3, 2018, 1:26 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-19064
> https://issues.apache.org/jira/browse/HIVE-19064
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19064
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 02367eb433ab9820b82f7a07f72eb0f503854716 
>   itests/src/test/resources/testconfiguration.properties 
> ec257139063c43ba90bb9853a92abace4896998d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
> 429c296dee41e11e919d541c6510a9934572b29b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
>  06adc647277a9b053cb509b14016f19dd578557b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java
>  1395027159f891d334a71b2d19d079eb573f 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java 
> 9057bb94b0b50e1ba693506b2d33d3ac8bb5c05c 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java 
> 286a47f15059d7eaf76c0c9fab8daaeca1769e0c 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 
> dae18fb9b14d781904e8fec1b115e6a6eb7d7398 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
> fe26283bd27d20890faeccdade1e24bd55f45fa2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
> 2780be2518a78bce8d281d783bf3c06163685dda 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 
> 3ff6a5e4e30b30c9ba64b8f0a96714cd7e55954c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 8b639f792226b817220d2b5eaefa62d41162a0b9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 99e2c72d212cfaefe463b1fa32239d6b63aa9228 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
> 8c238871765b0d5312a459a0e7f68c81f3837c13 
>   ql/src/test/queries/clientpositive/quotedid_basic_standard.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q 
> adc23e99b335f95552e16e1a0234a41e48aec18c 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_2.q 
> PRE-CREATION 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out 
> 31c97b0c6f6b66d7a3548b0bc68f51b203620e94 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out
>  PRE-CREATION 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_2.q.out
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/quotedid_basic_standard.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out 
> 7a9cc12dbb66bb6d87c68c614b43189b8920a0c2 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  8539fea42fa2743381833ab3137579caeac64672 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
>  88cbfcdc4bc09fcc8be96c02521c7afb04736eca 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  995137f9675cd34b7d7c6f79bb78e206a65d99f7 
>   
>

Re: Review Request 66397: HIVE-19064

2018-04-14 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66397/#review201166
---




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 3052 (patched)


Current behavior is: single and double quotes for string literals and 
backticks for identifiers.

For string literals we can keep that as is, but for identifers we allow 
double quotes in addition to backticks than we can have "standard" as default. 
Which will imply that users can use double quotes for both literals as well as 
identifiers (which adheres to standard) as well as its still back compat where 
users may have used backticks for identifers and used double or single quotes 
for literals.


- Ashutosh Chauhan


On April 3, 2018, 1:26 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66397/
> ---
> 
> (Updated April 3, 2018, 1:26 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-19064
> https://issues.apache.org/jira/browse/HIVE-19064
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19064
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 02367eb433ab9820b82f7a07f72eb0f503854716 
>   itests/src/test/resources/testconfiguration.properties 
> ec257139063c43ba90bb9853a92abace4896998d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
> 429c296dee41e11e919d541c6510a9934572b29b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
>  06adc647277a9b053cb509b14016f19dd578557b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java
>  1395027159f891d334a71b2d19d079eb573f 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java 
> 9057bb94b0b50e1ba693506b2d33d3ac8bb5c05c 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java 
> 286a47f15059d7eaf76c0c9fab8daaeca1769e0c 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 
> dae18fb9b14d781904e8fec1b115e6a6eb7d7398 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
> fe26283bd27d20890faeccdade1e24bd55f45fa2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
> 2780be2518a78bce8d281d783bf3c06163685dda 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 
> 3ff6a5e4e30b30c9ba64b8f0a96714cd7e55954c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 8b639f792226b817220d2b5eaefa62d41162a0b9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 99e2c72d212cfaefe463b1fa32239d6b63aa9228 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
> 8c238871765b0d5312a459a0e7f68c81f3837c13 
>   ql/src/test/queries/clientpositive/quotedid_basic_standard.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q 
> adc23e99b335f95552e16e1a0234a41e48aec18c 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_2.q 
> PRE-CREATION 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out 
> 31c97b0c6f6b66d7a3548b0bc68f51b203620e94 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out
>  PRE-CREATION 
>   
> ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_2.q.out
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/quotedid_basic_standard.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out 
> 7a9cc12dbb66bb6d87c68c614b43189b8920a0c2 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  8539fea42fa2743381833ab3137579caeac64672 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
>  88cbfcdc4bc09fcc8be96c02521c7afb04736eca 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  995137f9675cd34b7d7c6f79bb78e206a65d99f7 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  8ea605169203d05bb9980babc43b8bd0799b51f1 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java
>  24e3c5667add1152a3e85f77d8b24727b46f2b8e 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  9857c4ea673a6291aa77b61075646961c57e0aea 
>   
>

[jira] [Created] (HIVE-19216) beeline: initscript commands should not be recorded in the history

2018-04-14 Thread Zoltan Haindrich (JIRA) 
Zoltan Haindrich created HIVE-19216:
---

 Summary: beeline: initscript commands should not be recorded in 
the history
 Key: HIVE-19216
 URL: https://issues.apache.org/jira/browse/HIVE-19216
 Project: Hive
  Issue Type: Improvement
Reporter: Zoltan Haindrich


I've about 10 settings changed in my initscript; it makes my history barely 
useable - since every time I launch a new session all the set commands are 
recorded in the history



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

2018-04-14 Thread Daniel Dai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66571/
---

(Updated April 14, 2018, 7:06 a.m.)


Review request for hive.


Repository: hive-git


Description
---

See HIVE-19161


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e533ee6 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 801de7a 
  itests/hive-unit/pom.xml 05c362e 
  
itests/hive-unit/src/test/java/org/apache/hive/service/server/TestInformationSchemaWithPrivilege.java
 PRE-CREATION 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/DatabaseAccessorFactory.java
 7dc690f 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java
 178c97d 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java
 638e2b0 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/MsSqlDatabaseAccessor.java
 PRE-CREATION 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/OracleDatabaseAccessor.java
 PRE-CREATION 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/PostgresDatabaseAccessor.java
 PRE-CREATION 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 339 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d59bf1f 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProvider.java
 60d9dc1 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveResourceACLsImpl.java
 PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6003ced 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentGroups.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java
 PRE-CREATION 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 47f84b5 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 565549a 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 9a43b2c 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
 98674cf 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 c5da7b5 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
 f6c46ee 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 1ce86bb 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 612afe1 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 304f567 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 85c6727 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 ecddc7b 


Diff: https://reviews.apache.org/r/66571/diff/5/

Changes: https://reviews.apache.org/r/66571/diff/4-5/


Testing
---


Thanks,

Daniel Dai