Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-18 Thread Na Li via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69585/
---

(Updated Dec. 19, 2018, 6:57 a.m.)


Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.


Bugs: HIVE-20776
https://issues.apache.org/jira/browse/HIVE-20776


Repository: hive-git


Description
---

add filtering to read result at HMS server, so user cannot see metadata he/she 
has no privileges. Filtering is enabled/disabled based on configuration.


Diffs
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 9eb1193a27120b5167f92daf67bf6a1c4e1d9927 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 fb0b2fe6fb9fd4b4c92a6a39f06f39a4641aaabd 
  standalone-metastore/metastore-server/pom.xml 
895abfc423f00b121ee63e40904f5b3e57aea8ed 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 0a1b96dcf62d3536cab2ce074d27a6225b2d3443 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/69585/diff/2/


Testing (updated)
---

Existing unit tests passed. 
add new unit tests for filtering at HMS server and HMS client
add code to enabled/disable filtering at HMS client based on configuration


Thanks,

Na Li



Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-18 Thread Na Li via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69585/
---

(Updated Dec. 19, 2018, 6:56 a.m.)


Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.


Bugs: HIVE-20776
https://issues.apache.org/jira/browse/HIVE-20776


Repository: hive-git


Description
---

add filtering to read result at HMS server, so user cannot see metadata he/she 
has no privileges. Filtering is enabled/disabled based on configuration.


Diffs (updated)
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 9eb1193a27120b5167f92daf67bf6a1c4e1d9927 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 fb0b2fe6fb9fd4b4c92a6a39f06f39a4641aaabd 
  standalone-metastore/metastore-server/pom.xml 
895abfc423f00b121ee63e40904f5b3e57aea8ed 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 0a1b96dcf62d3536cab2ce074d27a6225b2d3443 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/69585/diff/2/

Changes: https://reviews.apache.org/r/69585/diff/1-2/


Testing
---

Existing unit tests passed. 
Will add new unit tests for filtering at HMS server in next update of this jira
Will add code to enabled/disable filtering at HMS client based on configuration 
in next update of this jira


Thanks,

Na Li



[jira] [Created] (HIVE-21058) Make Compactor run in a transaction (Umbrella)

2018-12-18 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-21058:
-

 Summary: Make Compactor run in a transaction (Umbrella)
 Key: HIVE-21058
 URL: https://issues.apache.org/jira/browse/HIVE-21058
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 3.0.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Fix For: 4.0.0


Ensure that files produced by the compactor have their visibility controlled 
via Hive transaction commit like any other write to an ACID table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21057) Make semi join reduction work with UNION

2018-12-18 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-21057:
--

 Summary: Make semi join reduction work with UNION
 Key: HIVE-21057
 URL: https://issues.apache.org/jira/browse/HIVE-21057
 Project: Hive
  Issue Type: Improvement
  Components: Query Planning
Reporter: Vineet Garg
Assignee: Vineet Garg


HIVE-21007 disabled semi-join for plans containing UNION since it generates a 
operator tree which ends up producing invalid tez plan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] hive pull request #440: HIVE-20785: Typo KEQ_SEQ -> KEY_SEQ

2018-12-18 Thread Mogztter
Github user Mogztter closed the pull request at:

https://github.com/apache/hive/pull/440


---


[jira] [Created] (HIVE-21056) Make CompactionInfo extend CompactionInfoStruct

2018-12-18 Thread Jaume M (JIRA)
Jaume M created HIVE-21056:
--

 Summary: Make CompactionInfo extend CompactionInfoStruct
 Key: HIVE-21056
 URL: https://issues.apache.org/jira/browse/HIVE-21056
 Project: Hive
  Issue Type: Improvement
Reporter: Jaume M


CompactionInfo is serialized into CompactionInfoStruct and by doing so if new 
fields are added to CompactionInfo they may not be added to the serialization 
functions. Doing it this way will help prevent bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-18 Thread Na Li via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69585/
---

Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.


Bugs: HIVE-20776
https://issues.apache.org/jira/browse/HIVE-20776


Repository: hive-git


Description
---

add filtering to read result at HMS server, so user cannot see metadata he/she 
has no privileges. Filtering is enabled/disabled based on configuration.


Diffs
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 fb0b2fe 
  standalone-metastore/metastore-server/pom.xml 895abfc 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 0a1b96d 


Diff: https://reviews.apache.org/r/69585/diff/1/


Testing
---

Existing unit tests passed. 
Will add new unit tests for filtering at HMS server in next update of this jira
Will add code to enabled/disable filtering at HMS client based on configuration 
in next update of this jira


Thanks,

Na Li



[GitHub] hive pull request #483: HIVE-20682: Async query execution can potentially fa...

2018-12-18 Thread sankarh
Github user sankarh closed the pull request at:

https://github.com/apache/hive/pull/483


---


[GitHub] hive pull request #508: HIVE-21043: Enable move optimization for replicating...

2018-12-18 Thread sankarh
Github user sankarh closed the pull request at:

https://github.com/apache/hive/pull/508


---


[GitHub] hive pull request #509: HIVE-21055 : Replication load command executing copy...

2018-12-18 Thread maheshk114
GitHub user maheshk114 opened a pull request:

https://github.com/apache/hive/pull/509

HIVE-21055 : Replication load command executing copy in serial mode even if 
parallel execution is enabled using with clause

…

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maheshk114/hive HIVE-21055

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #509


commit d44ab1c233aaceed443bc09820ce893bb8601c38
Author: Mahesh Kumar Behera 
Date:   2018-12-18T11:40:17Z

HIVE-21055 : Replication load command executing copy in serial mode even if 
parallel execution is enabled using with clause




---


[GitHub] hive pull request #508: HIVE-21043: Enable move optimization for replicating...

2018-12-18 Thread sankarh
GitHub user sankarh opened a pull request:

https://github.com/apache/hive/pull/508

HIVE-21043: Enable move optimization for replicating to cloud based cluster 
with strict managed tables.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sankarh/hive HIVE-21043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #508


commit a3fd34c093b4ebc5672156d8bc7e6f4d426aee6d
Author: Sankar Hariappan 
Date:   2018-12-18T11:00:04Z

HIVE-21043: Enable move optimization for replicating to cloud based cluster 
with strict managed tables.




---


Re: Hive Code Contribution

2018-12-18 Thread László Bodor
Hi Mani!

As far as I know, there are some "aliases" for the newbie label
(accidentally used or not, not sure, but doesn't matter):
https://issues.apache.org/jira/browse/HIVE-20159?jql=project%20%3D%20HIVE%20AND%20status%20%3D%20Open%20AND%20labels%20in%20(newbie%2C%20newbiee%2C%20%22newbie%2B%2B%22%2C%20newbiee%2C%20noob)

Regards,
Laszlo Bodor


On Mon, 17 Dec 2018 at 21:40, Mani M  wrote:

> Hi Alan
> Thanks for the info.
>
> Let me go through the issues and come back to you for any help..
>
> With Regards
> M.Mani
> +61 432 461 087
>
> On Tue, 18 Dec 2018, 04:58 Alan Gates 
> > Hi Mani, and welcome to the Hive community.  We have a newbie label that
> we
> > use in JIRA to mark issues for new contributors.
> >
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HIVE%20AND%20status%20%3D%20Open%20AND%20labels%20%3D%20newbie
> >
> > Alan.
> >
> >
> >
> > On Sat, Dec 15, 2018 at 6:59 PM Mani M  wrote:
> >
> > > Hi Team,
> > >
> > > I'm planning to work as a code contributor for hive project.
> > >
> > > To start-with I like to take the jira tickets with easy fixes.
> > >
> > > Can anyone help me to find out the jira tickets for the starters.
> > >
> > > With Regards
> > > M.Mani
> > > +61 432 461 087
> > >
> >
>


[jira] [Created] (HIVE-21055) Replication to a target cluster with hive.strict.managed.tables enabled executing copy in serial mode

2018-12-18 Thread mahesh kumar behera (JIRA)
mahesh kumar behera created HIVE-21055:
--

 Summary: Replication to a target cluster with 
hive.strict.managed.tables enabled executing copy in serial mode
 Key: HIVE-21055
 URL: https://issues.apache.org/jira/browse/HIVE-21055
 Project: Hive
  Issue Type: Bug
Reporter: mahesh kumar behera
Assignee: mahesh kumar behera


For repl load command use can specify the execution mode as part of "with" 
clause. But the config for executing task in parallel or serial is not read 
from the command specific config. It is read from the hive server config. So 
even if user specifies to run the tasks in parallel during repl load command, 
the tasks are getting executed serially.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)