[jira] [Created] (HIVE-21115) Add support for object versions in metastore

2019-01-10 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-21115: -- Summary: Add support for object versions in metastore Key: HIVE-21115 URL: https://issues.apache.org/jira/browse/HIVE-21115 Project: Hive Issue

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

2019-01-10 Thread Karthik Manamcheri via Review Board
> On Jan. 9, 2019, 11:56 p.m., Yongzhi Chen wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > > Line 228 (original), 227 (patched) > > > >

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

2019-01-10 Thread Karthik Manamcheri via Review Board
> On Jan. 9, 2019, 11:56 p.m., Yongzhi Chen wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > > Lines 101 (patched) > > > > > >

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

2019-01-10 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211846 ---

[jira] [Created] (HIVE-21114) Create read-only transactions

2019-01-10 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-21114: - Summary: Create read-only transactions Key: HIVE-21114 URL: https://issues.apache.org/jira/browse/HIVE-21114 Project: Hive Issue Type: Bug

Re: [DISCUSS] Consistent Timestamps across Hadoop

2019-01-10 Thread Owen O'Malley
Toward that end, I've updated the Hive tutorial wiki https://cwiki.apache.org/confluence/display/Hive/Tutorial with the current timestamp semantics. In the DDL section, we should call out the historical semantics and the former and current bugs. .. Owen

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211843 --- Fix it, then Ship it!

Fwd: [DISCUSS] Consistent Timestamps across Hadoop

2019-01-10 Thread Owen O'Malley
-- Forwarded message - From: Owen O'Malley Date: Thu, Jan 10, 2019 at 3:09 PM Subject: Re: [DISCUSS] Consistent Timestamps across Hadoop To: Zoltan Ivanfi No, that isn't right. The discussion for Apache projects needs to happen in the open and not the private google doc that

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 10, 2019, 9:10 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Na Li via Review Board
> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > > Lines 318 (patched) > > > > > >

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Na Li via Review Board
> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4711 (patched) > > > > > > move this

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Na Li via Review Board
> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4655 (patched) > > > > > > same comment

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2019-01-10 Thread Na Li via Review Board
> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > Thanks for the patch. Do we really need to introduce > > authorizeTableForPartitionMetadata in these API calls. For the common case, > > it can potentially degrade API performance. For instance, for fetching a > > single partition,

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-10 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 10, 2019, 7:23 p.m.) Review request for hive and Eugene Koifman.

Re: [DISCUSS] Consistent Timestamps across Hadoop

2019-01-10 Thread Zoltan Ivanfi
Hi, Once we are through the discussion phase and hopefully have reached agreement, I support moving the document to a more permanent place. I'm unsure about what the best place would be though. Since it needs the agreement of three communities, it does not strictly belong to any single one of

Review Request 69704: HIVE-21052

2019-01-10 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69704/ --- Review request for hive. Repository: hive-git Description --- Make sure

getTable variants in InjectableBehaviourObjectStore

2019-01-10 Thread Ashutosh Bapat
Hi, There are two getTable variants in InjectableBehaviourObjectStore() each calling corresponding super.getTable() and passing the returned value to getTableModifier.apply(). ObjectStore, which is super class here, itself has the same getTable variants. A result is that when one variant of

[jira] [Created] (HIVE-21113) For HPL/SQL that contains boolean expression with NOT, incorrect SQL may be generated.

2019-01-10 Thread Baoning He (JIRA)
Baoning He created HIVE-21113: - Summary: For HPL/SQL that contains boolean expression with NOT, incorrect SQL may be generated. Key: HIVE-21113 URL: https://issues.apache.org/jira/browse/HIVE-21113