Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-21 Thread Vaibhav Gumashta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69367/
---

(Updated Jan. 22, 2019, 7:04 a.m.)


Review request for hive and Eugene Koifman.


Bugs: HIVE-20699
https://issues.apache.org/jira/browse/HIVE-20699


Repository: hive-git


Description
---

https://jira.apache.org/jira/browse/HIVE-20699


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b213609f39 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java 
d6a41919bf 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java
 PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bbe7fb0697 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java 
15c14c9be5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java 7f8bd229a6 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java 
fbb931cbcd 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 6d4578e7a0 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 4d55592b63 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
0e5b3e5473 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 
dc05e1990e 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java a0df82cb20 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java
 PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 0fdcbda66f 


Diff: https://reviews.apache.org/r/69367/diff/7/

Changes: https://reviews.apache.org/r/69367/diff/6-7/


Testing
---


Thanks,

Vaibhav Gumashta



[GitHub] hive pull request #519: [HIVE-21141] Fix some spell errors in Hive

2019-01-21 Thread xubo245
GitHub user xubo245 opened a pull request:

https://github.com/apache/hive/pull/519

[HIVE-21141] Fix some spell errors in Hive

 Fix some spell errors in Hive

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xubo245/hive HIVE-21141_fixSpellErrors

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #519


commit 199cf2ccbb584202395285e25b70ebcea2c5d872
Author: xubo245 
Date:   2019-01-22T06:28:11Z

[HIVE-21141] Fix some spell errors in Hive




---


[jira] [Created] (HIVE-21141) Fix som spell errors in Hive

2019-01-21 Thread xubo245 (JIRA)
xubo245 created HIVE-21141:
--

 Summary: Fix som spell errors in Hive
 Key: HIVE-21141
 URL: https://issues.apache.org/jira/browse/HIVE-21141
 Project: Hive
  Issue Type: Bug
Reporter: xubo245
Assignee: xubo245


Fix som spell errors in Hive



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] hive pull request #518: HIVE-20419: Vectorization: Prevent mutation of Vecto...

2019-01-21 Thread pudidic
GitHub user pudidic opened a pull request:

https://github.com/apache/hive/pull/518

HIVE-20419: Vectorization: Prevent mutation of VectorPartitionDesc af…

…ter being used in a hashmap key (Teddy Choi)

Change-Id: Id2219d74cd09db8efc6c464acef27aa0bb95fe2b

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pudidic/hive HIVE-20419

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit 45df1940daa816148cec44e282119aa62b65fb26
Author: Teddy Choi 
Date:   2019-01-21T08:31:11Z

HIVE-20419: Vectorization: Prevent mutation of VectorPartitionDesc after 
being used in a hashmap key (Teddy Choi)

Change-Id: Id2219d74cd09db8efc6c464acef27aa0bb95fe2b




---


Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69801/
---

(Updated Jan. 21, 2019, 1:34 p.m.)


Review request for hive, Peter Vary and Vihang Karajgaonkar.


Bugs: HIVE-21116
https://issues.apache.org/jira/browse/HIVE-21116


Repository: hive-git


Description
---

HADOOP_CREDSTORE_PASSWORD is not populated under 
yarn.app.mapreduce.am.admin.user.env


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java ae6fa43df0 
  common/src/java/org/apache/hive/common/util/HiveStringUtils.java a4923f9f1b 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java 
4f49190df0 


Diff: https://reviews.apache.org/r/69801/diff/3/

Changes: https://reviews.apache.org/r/69801/diff/2-3/


Testing
---

TestHiveCredentialProviders.java


Thanks,

Denys Kuzmenko



Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69801/
---

(Updated Jan. 21, 2019, 1:13 p.m.)


Review request for hive, Peter Vary and Vihang Karajgaonkar.


Bugs: HIVE-21116
https://issues.apache.org/jira/browse/HIVE-21116


Repository: hive-git


Description
---

HADOOP_CREDSTORE_PASSWORD is not populated under 
yarn.app.mapreduce.am.admin.user.env


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java ae6fa43df0 
  common/src/java/org/apache/hive/common/util/HiveStringUtils.java a4923f9f1b 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java 
4f49190df0 


Diff: https://reviews.apache.org/r/69801/diff/2/

Changes: https://reviews.apache.org/r/69801/diff/1-2/


Testing
---

TestHiveCredentialProviders.java


Thanks,

Denys Kuzmenko



Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69801/
---

Review request for hive, Peter Vary and Vihang Karajgaonkar.


Bugs: HIVE-21116
https://issues.apache.org/jira/browse/HIVE-21116


Repository: hive-git


Description
---

HADOOP_CREDSTORE_PASSWORD is not populated under 
yarn.app.mapreduce.am.admin.user.env


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java ae6fa43df0 
  common/src/java/org/apache/hive/common/util/HiveStringUtils.java a4923f9f1b 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java 
4f49190df0 


Diff: https://reviews.apache.org/r/69801/diff/1/


Testing
---

TestHiveCredentialProviders.java


Thanks,

Denys Kuzmenko



Re: Review Request 69780: HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles

2019-01-21 Thread MANI M

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69780/#review212174
---


Ship it!




Ship It!

- MANI M


On Jan. 17, 2019, 10:22 a.m., MANI M wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69780/
> ---
> 
> (Updated Jan. 17, 2019, 10:22 a.m.)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21099
> https://issues.apache.org/jira/browse/HIVE-21099
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 
> 80f77b9f0c 
> 
> 
> Diff: https://reviews.apache.org/r/69780/diff/1/
> 
> 
> Testing
> ---
> 
> PRE-COMMIT testing done and the results are available in the JIRA
> https://issues.apache.org/jira/browse/HIVE-21099
> 
> 
> Thanks,
> 
> MANI M
> 
>



Re: Review Request 69780: HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles

2019-01-21 Thread Peter Vary via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69780/#review212173
---


Ship it!




Ship It!

- Peter Vary


On jan. 17, 2019, 10:22 de, MANI M wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69780/
> ---
> 
> (Updated jan. 17, 2019, 10:22 de)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21099
> https://issues.apache.org/jira/browse/HIVE-21099
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 
> 80f77b9f0c 
> 
> 
> Diff: https://reviews.apache.org/r/69780/diff/1/
> 
> 
> Testing
> ---
> 
> PRE-COMMIT testing done and the results are available in the JIRA
> https://issues.apache.org/jira/browse/HIVE-21099
> 
> 
> Thanks,
> 
> MANI M
> 
>