Re: Review Request 71014: HIVE-21938
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71014/ --- (Updated July 5, 2019, 5:49 a.m.) Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg. Summary (updated) - HIVE-21938 Bugs: HIVE-21938 https://issues.apache.org/jira/browse/HIVE-21938 Repository: hive-git Description --- By default pre upgrade tool scans all databases and tables in the warehouse. Add database and table filter options to run the tool for a specific subset of databases and tables only. Diffs - upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd Diff: https://reviews.apache.org/r/71014/diff/1/ Testing --- New UTs for testing filtering Thanks, Krisztian Kasa
Review Request 71014: HIVE-21938: Add database and table filter options to PreUpgradeTool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71014/ --- Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg. Bugs: HIVE-21938 https://issues.apache.org/jira/browse/HIVE-21938 Repository: hive-git Description --- By default pre upgrade tool scans all databases and tables in the warehouse. Add database and table filter options to run the tool for a specific subset of databases and tables only. Diffs - upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd Diff: https://reviews.apache.org/r/71014/diff/1/ Testing --- New UTs for testing filtering Thanks, Krisztian Kasa
[jira] [Created] (HIVE-21959) Clean up Concatenate and Msck DDL commands
Miklos Gergely created HIVE-21959: - Summary: Clean up Concatenate and Msck DDL commands Key: HIVE-21959 URL: https://issues.apache.org/jira/browse/HIVE-21959 Project: Hive Issue Type: Sub-task Components: Hive Affects Versions: 3.1.1 Reporter: Miklos Gergely Assignee: Miklos Gergely Fix For: 4.0.0 Concatenate and Msck DDL use basic data structure implementations instead of their interfaces for variable declaration, like ArrayList instead of List, LinkedHashMap instead of Map, etc. This is due to a lot of similar issues in the code, which needs to be cleaned. Concatenate also had a non-immutable Desc class, that needs to be transformed into an immutable one. Concatenate operation code should be cut into smaller functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HIVE-21958) The list of table expression in the inclusion and exclusion list should be separated by '|' instead of comma.
mahesh kumar behera created HIVE-21958:
--
Summary: The list of table expression in the inclusion and
exclusion list should be separated by '|' instead of comma.
Key: HIVE-21958
URL: https://issues.apache.org/jira/browse/HIVE-21958
Project: Hive
Issue Type: Sub-task
Reporter: mahesh kumar behera
Assignee: mahesh kumar behera
Java regex expression does not support comma. If user wants multiple expression
to be present in the include or exclude list, then the expressions can be
provided separated by pipe ('|') character. The policy will look something like
db_name.'(t1*)|(t3)'.'t100'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Review Request 70920: HIVE-21868: Vectorize CAST...FORMAT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70920/ --- (Updated July 4, 2019, 3:04 p.m.) Review request for hive and Marta Kuczora. Changes --- Patch 7 Bugs: HIVE-21868 https://issues.apache.org/jira/browse/HIVE-21868 Repository: hive-git Description --- Vectorize UDFs for CAST ( AS STRING/CHAR/VARCHAR FORMAT ) and CAST ( AS TIMESTAMP/DATE FORMAT ). Diffs (updated) - common/src/java/org/apache/hadoop/hive/common/format/datetime/HiveSqlDateTimeFormatter.java 4e024a357b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java fa9d1e9783 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToCharWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToString.java dfa9f8a00d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToStringWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToVarCharWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java a6dff12e1a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDateWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToTimestamp.java b48b0136eb ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToTimestampWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToCharWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToString.java adc3a9d7b9 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToStringWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToVarCharWithFormat.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCastFormat.java 16742eee9b ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java 663237739e ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 58fd7b030e ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCastsWithFormat.java PRE-CREATION ql/src/test/queries/clientnegative/udf_cast_format_bad_pattern.q PRE-CREATION ql/src/test/queries/clientpositive/cast_datetime_with_sql_2016_format.q 269edf6da6 ql/src/test/results/clientnegative/udf_cast_format_bad_pattern.q.out PRE-CREATION ql/src/test/results/clientpositive/cast_datetime_with_sql_2016_format.q.out 4a502b9700 Diff: https://reviews.apache.org/r/70920/diff/4/ Changes: https://reviews.apache.org/r/70920/diff/3-4/ Testing --- Thanks, Karen Coppage
Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71011/ --- Review request for hive, Marta Kuczora and Thejas Nair. Repository: hive-git Description --- HIVE:21957: Create temporary table like should omit transactional properties. Diffs - ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e09fc379f5e0127367e73ed4c4556522de9838a8 Diff: https://reviews.apache.org/r/71011/diff/1/ Testing --- Thanks, Laszlo Pinter
[jira] [Created] (HIVE-21957) Create temporary table like should omit transactional properties
Laszlo Pinter created HIVE-21957: Summary: Create temporary table like should omit transactional properties Key: HIVE-21957 URL: https://issues.apache.org/jira/browse/HIVE-21957 Project: Hive Issue Type: Bug Components: Hive Affects Versions: 4.0.0 Reporter: Laszlo Pinter Assignee: Laszlo Pinter In case of create temporary table like queries, where the source table is transactional, the transactional properties should not be copied over to the new table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HIVE-21956) Add the list of table selected by dump in the dump folder.
mahesh kumar behera created HIVE-21956: -- Summary: Add the list of table selected by dump in the dump folder. Key: HIVE-21956 URL: https://issues.apache.org/jira/browse/HIVE-21956 Project: Hive Issue Type: Sub-task Reporter: mahesh kumar behera Assignee: mahesh kumar behera The list of tables selected by a dump should be kept in the dump folder as a _tables file. This will help user to find out the tables replicated and the list can be used by user for ranger and atlas policy replication. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HIVE-21955) SearchArgumentImpl generates wrong ExpressionTree in some cases which might result in loss of data
Zihao Ye created HIVE-21955: --- Summary: SearchArgumentImpl generates wrong ExpressionTree in some cases which might result in loss of data Key: HIVE-21955 URL: https://issues.apache.org/jira/browse/HIVE-21955 Project: Hive Issue Type: Bug Components: Hive, ORC Reporter: Zihao Ye ExpressionBuilder applies `pushDownNot`, `foldMaybe`, `flatten`, `convertToCNF`, `flatten` and `buildLeafList` in order to form a non-normalized expression into a CNF expression with the unique leaves. After an expression is converted to CNF, there might be more than one non-leaf node which are exactly the same object in the expression tree. If this happens, those non-leaf node will be visited more than once in `buildLeafList` function. As a result, a wrong ExpressionTree is generated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HIVE-21954) QTest: support for running qtests on various metastore DBs
Laszlo Bodor created HIVE-21954: --- Summary: QTest: support for running qtests on various metastore DBs Key: HIVE-21954 URL: https://issues.apache.org/jira/browse/HIVE-21954 Project: Hive Issue Type: Bug Reporter: Laszlo Bodor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
