[jira] [Created] (HIVE-22849) Regex for Hive built in functions giving different result

[ABHISHEK KUMAR GUPTA (Jira)]

ABHISHEK KUMAR GUPTA created HIVE-22849:
---

 Summary: Regex for Hive built in functions giving different result
 Key: HIVE-22849
 URL: https://issues.apache.org/jira/browse/HIVE-22849
 Project: Hive
  Issue Type: Bug
Affects Versions: 3.1.1
 Environment: hive> show functions like 'ad?*';
OK
abs
acos
add_months
aes_decrypt
aes_encrypt
and
array
array_contains
ascii
asin
assert_true
atan
avg
Time taken: 0.005 seconds, Fetched: 13 row(s)
hive> show functions like 'ad*';
OK
add_months
Time taken: 0.005 seconds, Fetched: 1 row(s)
Reporter: ABHISHEK KUMAR GUPTA






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22848) Disallow creating managed table at encryption zone root

[Aasha Medhi (Jira)]

Aasha Medhi created HIVE-22848:
--

 Summary: Disallow creating managed table at encryption zone root
 Key: HIVE-22848
 URL: https://issues.apache.org/jira/browse/HIVE-22848
 Project: Hive
  Issue Type: Bug
Reporter: Aasha Medhi
Assignee: Aasha Medhi






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22847) view created in presto throws Exception in Hive while accessing

[ABHISHEK KUMAR GUPTA (Jira)]

ABHISHEK KUMAR GUPTA created HIVE-22847:
---

 Summary: view created in presto throws Exception in Hive while 
accessing
 Key: HIVE-22847
 URL: https://issues.apache.org/jira/browse/HIVE-22847
 Project: Hive
  Issue Type: Bug
Reporter: ABHISHEK KUMAR GUPTA


hive> select * from test_view;
NoViableAltException(-1@[])
at 
org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1300)
at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:208)
at org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:77)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.replaceViewReferenceWithDefinition(SemanticAnalyzer.java:2443)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.getMetaData(SemanticAnalyzer.java:2022)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.getMetaData(SemanticAnalyzer.java:1934)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genResolvedParseTree(SemanticAnalyzer.java:11080)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:11133)
at 
org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:286)
at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:258)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:512)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
at 
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:233)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:184)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:403)
at 
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:821)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:759)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:686)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:226)
at org.apache.hadoop.util.RunJar.main(RunJar.java:141)
FAILED: SemanticException line 1:17 cannot recognize input near '' '' 
'' in definition of VIEW test_view [
/* Presto View */
] used as test_view at Line 1:14



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22846) Hive metastore doesn’t support stats on container types

[ABHISHEK KUMAR GUPTA (Jira)]

ABHISHEK KUMAR GUPTA created HIVE-22846:
---

 Summary: Hive metastore doesn’t support stats on container types
 Key: HIVE-22846
 URL: https://issues.apache.org/jira/browse/HIVE-22846
 Project: Hive
  Issue Type: Bug
  Components: SQL
Affects Versions: 2.3.6
Reporter: ABHISHEK KUMAR GUPTA


hive> CREATE TABLE `test_map_text`(`id` string,`score` map) ROW 
FORMAT SERDE 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' WITH 
SERDEPROPERTIES ( 
'colelction.delim'=',','field.delim'='|','mapkey.delim'=':','serializaion.format'='|')
 STORED AS TEXTFILE;
hive> LOAD DATA INPATH '/tmp/map.text' INTO TABLE test_map.text;
This is my test_map.txt at HDFS location
1|Math:90,English:89
2|Math:88,English:90
3|Math:93,English:93
hive> analyze table test_map_text compute statistics for columns;
hive> desc formatted test_map_text score;
OK
# col_name  data_type   min max 
num_nulls   distinct_count  avg_col_len 
max_col_len num_trues   num_falses  
   comment

score   map 


   from deserializer
COLUMN_STATS_ACCURATE   
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"id\":\"true\"}}
Time taken: 0.053 seconds, Fetched: 4 row(s)




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22845) Code compilation fails on Windows when user name begins with 'N' or 'R'

[Renukaprasad C (Jira)]

Renukaprasad C created HIVE-22845:
-

 Summary: Code compilation fails on Windows when user name begins 
with 'N' or 'R'
 Key: HIVE-22845
 URL: https://issues.apache.org/jira/browse/HIVE-22845
 Project: Hive
  Issue Type: Bug
Reporter: Renukaprasad C
Assignee: Renukaprasad C


package-info.java is generated from the script - saveVersion.sh.

Generated contetnt is as follows.
/*
 * Generated by saveVersion.sh
 */
@MetastoreVersionAnnotation(version="4.0.0-SNAPSHOT", shortVersion="4.0.0",
 revision="Unknown", branch="Unknown",
 user="India
enu", date="Thu Feb 6 17:12:46 IST 2020", 
url="file:///cygdrive/f/hive/code/os/standalone-metastore",
 srcChecksum="88f3dc17f75ffda6176faa649593b54e")
package org.apache.hadoop.hive.metastore.annotation;


When user name begings with 'R' (India\Renu), then it get parsed as Carriage 
Return in between the string and fails compile. Same issue exists with name 
begins with 'N' also.

Whereas compilation is fine with any other user name doesnt contain \r or \n.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22844) Validate cm configs, add retries in fs apis for cm

[Aasha Medhi (Jira)]

Aasha Medhi created HIVE-22844:
--

 Summary: Validate cm configs, add retries in fs apis for cm
 Key: HIVE-22844
 URL: https://issues.apache.org/jira/browse/HIVE-22844
 Project: Hive
  Issue Type: Bug
Reporter: Aasha Medhi
Assignee: Aasha Medhi


# Retry create cm root logic
 # Validate fallbackEncryptionZone
 # Rename encryptionZones to cmRootLocations to be more accurate
 # Check cmRootEncrypted.isAbsolute() first before we go for creating anything
 # Validate fallbackNonEncryptedCmRootDir if it's really not encrypted
 # Refactor deleteTableData logic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22843) Use bounded map for storing encryption zone to cmroot mapping

[Aasha Medhi (Jira)]

Aasha Medhi created HIVE-22843:
--

 Summary: Use bounded map for storing encryption zone to cmroot 
mapping
 Key: HIVE-22843
 URL: https://issues.apache.org/jira/browse/HIVE-22843
 Project: Hive
  Issue Type: Bug
Reporter: Aasha Medhi


Currently cm uses a hashmap to store encryption zone to cm mapping. This may 
lead to OOM.

Analyse the same and move to bounded map if needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22842) Timestamp/date vectors in Arrow serializer should use correct calendar for value representation

[Jesus Camacho Rodriguez (Jira)]

Jesus Camacho Rodriguez created HIVE-22842:
--

 Summary: Timestamp/date vectors in Arrow serializer should use 
correct calendar for value representation
 Key: HIVE-22842
 URL: https://issues.apache.org/jira/browse/HIVE-22842
 Project: Hive
  Issue Type: Improvement
Reporter: Jesus Camacho Rodriguez
Assignee: Shubham Chaurasia






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

[Vineet Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72063/#review219519
---




ql/src/test/queries/clientpositive/dynpart_cast.q
Lines 2 (patched)


Thanks for addressing the comments. Just another minor comment. 
Can we add this test under 'minillap.query.files'? Right now this is MR 
test but since we use Tez/Llap it will be better under that.
You'll need to run "TestTezMiniLlapCliDriver' to genrate q file


- Vineet Garg


On Feb. 6, 2020, 2:22 p.m., Karen Coppage wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72063/
> ---
> 
> (Updated Feb. 6, 2020, 2:22 p.m.)
> 
> 
> Review request for hive and Peter Vary.
> 
> 
> Bugs: HIVE-10362
> https://issues.apache.org/jira/browse/HIVE-10362
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Example:
> create table dynparttypechecknum (key int, value string) partitioned by (part 
> int);
> insert into dynparttypechecknum partition (part) select key, value, '1' 
> from src limit 1;
> show partitions dynparttypechecknum;
> 
> Partition created will be named:
> part=1
> even though the type of `part` is int.
> 
> Solution is to cast the inserted DP columns in the SelectOperator before 
> FileSinkOperator which creates the partition dir, not after.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 12a022c590 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c2514eedb1 
>   ql/src/test/queries/clientpositive/dynpart_cast.q PRE-CREATION 
>   ql/src/test/results/clientpositive/autoColumnStats_6.q.out da3be3e5bb 
>   ql/src/test/results/clientpositive/dynpart_cast.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization_acid2.q.out 
> 43bb789840 
>   ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out 
> f745b46899 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_opt_bucketing.q.out 
> 453d2451df 
>   ql/src/test/results/clientpositive/llap/orc_merge1.q.out 9da73e65ac 
>   ql/src/test/results/clientpositive/llap/orc_merge10.q.out a6ea33493f 
>   ql/src/test/results/clientpositive/llap/orc_merge2.q.out 9b0d3b4234 
>   ql/src/test/results/clientpositive/llap/orc_merge_diff_fs.q.out d35f44b10a 
>   ql/src/test/results/clientpositive/llap/rcfile_merge2.q.out fcff20a68e 
>   ql/src/test/results/clientpositive/llap/tez_dml.q.out 4ad78d8582 
>   ql/src/test/results/clientpositive/orc_merge1.q.out 9c07816340 
>   ql/src/test/results/clientpositive/orc_merge10.q.out 4a5f03c82f 
>   ql/src/test/results/clientpositive/orc_merge2.q.out d132d62b18 
>   ql/src/test/results/clientpositive/orc_merge_diff_fs.q.out 7f9a04b09f 
>   ql/src/test/results/clientpositive/smb_join_partition_key.q.out c18d01d26a 
>   
> ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out 
> 56d5ed945b 
>   ql/src/test/results/clientpositive/spark/orc_merge1.q.out 977c4cbfc1 
>   ql/src/test/results/clientpositive/spark/orc_merge2.q.out 4647b86ea3 
>   ql/src/test/results/clientpositive/spark/orc_merge_diff_fs.q.out b7d3dd725d 
> 
> 
> Diff: https://reviews.apache.org/r/72063/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Karen Coppage
> 
>

[jira] [Created] (HIVE-22841) CookieSigner should not throw IllegalArgumentException on invalid cookie signature

[Kevin Risden (Jira)]

Kevin Risden created HIVE-22841:
---

 Summary: CookieSigner should not throw IllegalArgumentException on 
invalid cookie signature
 Key: HIVE-22841
 URL: https://issues.apache.org/jira/browse/HIVE-22841
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Reporter: Kevin Risden
Assignee: Kevin Risden


Currently CookieSigner throws an IllegalArgumentException if the cookie 
signature is invalid. 

{code:java}
if (!MessageDigest.isEqual(originalSignature.getBytes(), 
currentSignature.getBytes())) {
  throw new IllegalArgumentException("Invalid sign, original = " + 
originalSignature +
" current = " + currentSignature);
}
{code}

CookieSigner is only used in the ThriftHttpServlet#getClientNameFromCookie and 
doesn't handle the IllegalArgumentException. It is only checking if the value 
from the cookie is null or not.

https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java#L295

{code:java}
  currValue = signer.verifyAndExtract(currValue);
  // Retrieve the user name, do the final validation step.
  if (currValue != null) {
{code}

This should be fixed to either:
a) Have CookieSigner not return an IllegalArgumentException
b) Improve ThriftHttpServlet to handle CookieSigner throwing an 
IllegalArgumentException



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

[Karen Coppage via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72063/
---

(Updated Feb. 6, 2020, 2:22 p.m.)


Review request for hive and Peter Vary.


Changes
---

Patch 11 - qtest changes, dropped use of DynamicPartitionCtx


Bugs: HIVE-10362
https://issues.apache.org/jira/browse/HIVE-10362


Repository: hive-git


Description
---

Example:
create table dynparttypechecknum (key int, value string) partitioned by (part 
int);
insert into dynparttypechecknum partition (part) select key, value, '1' 
from src limit 1;
show partitions dynparttypechecknum;

Partition created will be named:
part=1
even though the type of `part` is int.

Solution is to cast the inserted DP columns in the SelectOperator before 
FileSinkOperator which creates the partition dir, not after.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 12a022c590 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2514eedb1 
  ql/src/test/queries/clientpositive/dynpart_cast.q PRE-CREATION 
  ql/src/test/results/clientpositive/autoColumnStats_6.q.out da3be3e5bb 
  ql/src/test/results/clientpositive/dynpart_cast.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/dynpart_sort_optimization_acid2.q.out 
43bb789840 
  ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out 
f745b46899 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_bucketing.q.out 
453d2451df 
  ql/src/test/results/clientpositive/llap/orc_merge1.q.out 9da73e65ac 
  ql/src/test/results/clientpositive/llap/orc_merge10.q.out a6ea33493f 
  ql/src/test/results/clientpositive/llap/orc_merge2.q.out 9b0d3b4234 
  ql/src/test/results/clientpositive/llap/orc_merge_diff_fs.q.out d35f44b10a 
  ql/src/test/results/clientpositive/llap/rcfile_merge2.q.out fcff20a68e 
  ql/src/test/results/clientpositive/llap/tez_dml.q.out 4ad78d8582 
  ql/src/test/results/clientpositive/orc_merge1.q.out 9c07816340 
  ql/src/test/results/clientpositive/orc_merge10.q.out 4a5f03c82f 
  ql/src/test/results/clientpositive/orc_merge2.q.out d132d62b18 
  ql/src/test/results/clientpositive/orc_merge_diff_fs.q.out 7f9a04b09f 
  ql/src/test/results/clientpositive/smb_join_partition_key.q.out c18d01d26a 
  ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out 
56d5ed945b 
  ql/src/test/results/clientpositive/spark/orc_merge1.q.out 977c4cbfc1 
  ql/src/test/results/clientpositive/spark/orc_merge2.q.out 4647b86ea3 
  ql/src/test/results/clientpositive/spark/orc_merge_diff_fs.q.out b7d3dd725d 


Diff: https://reviews.apache.org/r/72063/diff/3/

Changes: https://reviews.apache.org/r/72063/diff/2-3/


Testing
---

There were changes in query output in two spark auto_sortmerge_join_16.q.out 
files. They now match the query output of llap/auto_sortmerge_join_16.q.out.


Thanks,

Karen Coppage

Re: Review Request 72084: HIVE-21216: Write Parquet INT64 timestamp

[Karen Coppage via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72084/
---

(Updated Feb. 6, 2020, 2:12 p.m.)


Review request for hive and Marta Kuczora.


Bugs: HIVE-21216
https://issues.apache.org/jira/browse/HIVE-21216


Repository: hive-git


Description
---

This patch enables Hive to start writing int64 timestamps in Parquet.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 12a022c590 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java 
ba235f761d 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java
 21bfb2e1a2 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/ParquetTimestampUtils.java
 9ce07e74f3 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriteSupport.java
 8acde81a3d 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java 
bd519eb66e 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/HiveParquetSchemaTestUtils.java
 181894f106 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestDataWritableWriter.java 
b242392a9a 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java 
dc80af1b76 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java
 9ea78508ee 
  ql/src/test/queries/clientpositive/parquet_int64_timestamp.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/parquet_int64_timestamp_int96_compatibility.q
 PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_int64_timestamp.q.out PRE-CREATION 
  
ql/src/test/results/clientpositive/parquet_int64_timestamp_int96_compatibility.q.out
 PRE-CREATION 


Diff: https://reviews.apache.org/r/72084/diff/2/

Changes: https://reviews.apache.org/r/72084/diff/1-2/


Testing
---


Thanks,

Karen Coppage

[jira] [Created] (HIVE-22840) Race condition in formatters of TimestampColumnVector and DateColumnVector

[Jira]

László Bodor created HIVE-22840:
---

 Summary: Race condition in formatters of TimestampColumnVector and 
DateColumnVector 
 Key: HIVE-22840
 URL: https://issues.apache.org/jira/browse/HIVE-22840
 Project: Hive
  Issue Type: Improvement
Reporter: László Bodor






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22839) Fix build failure of branch-2 against hbase-1.5

[Masatake Iwasaki (Jira)]

Masatake Iwasaki created HIVE-22839:
---

 Summary: Fix build failure of branch-2 against hbase-1.5
 Key: HIVE-22839
 URL: https://issues.apache.org/jira/browse/HIVE-22839
 Project: Hive
  Issue Type: Bug
  Components: Test
Affects Versions: 2.3.6
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki


branch-2 build with {{-Dhbase.version=1.5.0}} failed due to the change of 
org.apache.hadoop.hbase.client.ResultScanner introduced in hbase-1.4.0.
 
[https://archive.apache.org/dist/hbase/1.4.0/hbase-1.3.1-1.4.0RC1_compatibility_report.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22838) like any is incorrect if contains null

[Yuming Wang (Jira)]

Yuming Wang created HIVE-22838:
--

 Summary: like any is incorrect if contains null
 Key: HIVE-22838
 URL: https://issues.apache.org/jira/browse/HIVE-22838
 Project: Hive
  Issue Type: Bug
  Components: Query Planning
Affects Versions: 3.1.2
Reporter: Yuming Wang


How to reproduce:

{code:sql}
CREATE TABLE like_any_table
STORED AS TEXTFILE
AS
SELECT "google" as company,"%oo%" as pat
UNION ALL
SELECT "facebook" as company,"%oo%" as pat
UNION ALL
SELECT "linkedin" as company,"%in" as pat
;
{code}


{noformat}
hive> select company from like_any_table where company like any ('%oo%',null);
OK
Time taken: 0.064 seconds
hive> select company from like_any_table where company like '%oo%'  or company 
like null;
OK
google
facebook
{noformat}





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HIVE-22837) Make opertion log delay cleanup work for all operations

[Shaohui Liu (Jira)]

Shaohui Liu created HIVE-22837:
--

 Summary: Make opertion log delay cleanup  work for all operations
 Key: HIVE-22837
 URL: https://issues.apache.org/jira/browse/HIVE-22837
 Project: Hive
  Issue Type: Improvement
Affects Versions: 3.1.2
Reporter: Shaohui Liu
Assignee: Shaohui Liu


Currently, the operation log delay cleanup work only when a query is cancelled.

It's a very useful feature to debug the SQL through the operation log.

I think it should  be enabled for all operations
{code:java}
2020-02-06T13:30:03,537  INFO [f5a6a379-09f6-4fd8-8f1f-25034eee0ff8 
HiveServer2-Handler-Pool: Thread-76] operation.Operation: Closing operation log 
./operationlog/f5a6a379-09f6-4fd8-8f1f-25034eee0ff8/work_20200206133003_580d028f-0ca0-4fd6-9cc4-e56b57c29439
 without delay
2020-02-06T13:30:03,537  INFO [d3f09003-5507-4dbe-a900-69f245c41fae 
HiveServer2-Handler-Pool: Thread-77] operation.Operation: Closing operation log 
./operationlog/d3f09003-5507-4dbe-a900-69f245c41fae/work_20200206133003_5b6b405d-c0ed-4b44-aee1-d4dd4b57f8a2
 without delay
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72088: Extract Executor from Driver

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72088/
---

(Updated Feb. 6, 2020, 9:17 a.m.)


Review request for hive and Zoltan Haindrich.


Bugs: HIVE-22835
https://issues.apache.org/jira/browse/HIVE-22835


Repository: hive-git


Description
---

The Driver class contains ~600 lines of code responsible for executing the 
command. That means that from the Query Plan as input the appropriate tasks 
should be executed. This is a thing done by the execute function, which is ~300 
lines long, and also has some sub functions to help this task. All these codes 
should be put into a separate class, where it can do it's job without getting 
mixed with the other codes in the Driver.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 342d463480 
  ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java bbf7fe5379 
  ql/src/java/org/apache/hadoop/hive/ql/Executor.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/IDriver.java baad2694b3 
  ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecDriver.java eab7f45fde 


Diff: https://reviews.apache.org/r/72088/diff/2/

Changes: https://reviews.apache.org/r/72088/diff/1-2/


Testing
---

The tests are still running.


Thanks,

Miklos Gergely

Review Request 72088: Extract Executor from Driver

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72088/
---

Review request for hive and Zoltan Haindrich.


Bugs: HIVE-22835
https://issues.apache.org/jira/browse/HIVE-22835


Repository: hive-git


Description
---

The Driver class contains ~600 lines of code responsible for executing the 
command. That means that from the Query Plan as input the appropriate tasks 
should be executed. This is a thing done by the execute function, which is ~300 
lines long, and also has some sub functions to help this task. All these codes 
should be put into a separate class, where it can do it's job without getting 
mixed with the other codes in the Driver.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 342d463480 
  ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java bbf7fe5379 
  ql/src/java/org/apache/hadoop/hive/ql/Executor.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/IDriver.java baad2694b3 
  ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecDriver.java eab7f45fde 


Diff: https://reviews.apache.org/r/72088/diff/1/


Testing
---

The tests are still running.


Thanks,

Miklos Gergely