Re: Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72143/
---

(Updated Feb. 18, 2020, 12:09 a.m.)


Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.


Bugs: HIVE-22892
https://issues.apache.org/jira/browse/HIVE-22892


Repository: hive-git


Description
---

Unable to compile query if CTE joined


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
f7ac6d3bfa 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 8986315690 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33d3beba46 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java e7ad914e97 
  ql/src/test/queries/clientpositive/cte_join.q PRE-CREATION 
  ql/src/test/results/clientpositive/cte_join.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/72143/diff/3/

Changes: https://reviews.apache.org/r/72143/diff/2-3/


Testing (updated)
---

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver 
-Dqfile=subquery_in_explain_rewrite.q,tablevalues.q,cte_join.q -pl itests/qtest 
-Pitests


Thanks,

Krisztian Kasa

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Karen Coppage via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/#review219606
---


Ship it!




Ship It!

- Karen Coppage


On Feb. 17, 2020, 3:30 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72145/
> ---
> 
> (Updated Feb. 17, 2020, 3:30 p.m.)
> 
> 
> Review request for hive, Karen Coppage and Peter Vary.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21543: Use FilterHooks for show compactions
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  c7e1044589fd1dd970b86259b713d3a44716e7b8 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
>  d9da00dd2148b0408548ab7d5c88df014a7f7826 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  b6de1460a565f06217f163ca5f733594a0c8406a 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
>  23faa7444a8e9f9c010290539f89b9d8b44f3aa8 
> 
> 
> Diff: https://reviews.apache.org/r/72145/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Laszlo Pinter via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/
---

(Updated Feb. 17, 2020, 3:30 p.m.)


Review request for hive, Karen Coppage and Peter Vary.


Changes
---

Fix code review findings.


Repository: hive-git


Description
---

HIVE-21543: Use FilterHooks for show compactions


Diffs (updated)
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 c7e1044589fd1dd970b86259b713d3a44716e7b8 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
 d9da00dd2148b0408548ab7d5c88df014a7f7826 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 b6de1460a565f06217f163ca5f733594a0c8406a 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
 23faa7444a8e9f9c010290539f89b9d8b44f3aa8 


Diff: https://reviews.apache.org/r/72145/diff/2/

Changes: https://reviews.apache.org/r/72145/diff/1-2/


Testing
---


Thanks,

Laszlo Pinter

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Karen Coppage via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/#review219605
---




standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
Lines 403-405 (patched)


nit: My friendly IDE tells me this can be replaced with a 
Map.computeIfAbsent call. Also true for lines 410, 413.



standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
Lines 440-442 (patched)


I think these are unnecessary



standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
Lines 404 (patched)


Parameter isn't used


- Karen Coppage


On Feb. 17, 2020, 9:42 a.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72145/
> ---
> 
> (Updated Feb. 17, 2020, 9:42 a.m.)
> 
> 
> Review request for hive, Karen Coppage and Peter Vary.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21543: Use FilterHooks for show compactions
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  c7e1044589fd1dd970b86259b713d3a44716e7b8 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
>  d9da00dd2148b0408548ab7d5c88df014a7f7826 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  7b7c2d77914ad56d3ae568aa050725b12969895a 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
>  23faa7444a8e9f9c010290539f89b9d8b44f3aa8 
> 
> 
> Diff: https://reviews.apache.org/r/72145/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>

[jira] [Created] (HIVE-22897) Remove enforcing of package-info.java files from the rest of the checkstyle files

2020-02-17 Thread Miklos Gergely (Jira) 
Miklos Gergely created HIVE-22897:
-

 Summary: Remove enforcing of package-info.java files from the rest 
of the checkstyle files
 Key: HIVE-22897
 URL: https://issues.apache.org/jira/browse/HIVE-22897
 Project: Hive
  Issue Type: Improvement
Reporter: Miklos Gergely
Assignee: Miklos Gergely


Follow-up Jira of HIVE-22876, enforcing is also present at:
{code:java}
./storage-api/checkstyle/checkstyle.xml
./standalone-metastore/checkstyle/checkstyle.xml
{code}
Remove those too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72109: HIVE-20948: Eliminate file rename in compactor

2020-02-17 Thread Laszlo Pinter via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72109/
---

(Updated Feb. 17, 2020, 12:53 p.m.)


Review request for hive, Karen Coppage, Marta Kuczora, and Peter Vary.


Changes
---

Fix code review findings


Repository: hive-git


Description
---

HIVE-20948: Eliminate file rename in compactor


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 
9ad4e7148226b91b0c759de54e251893d61725a3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java 
076b77877ae748b757a4c9c08532a3ce029fed38 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 
2f5ec5270c0bc7d1a591c9c8c15b1ecb7f9f6ace 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 
ecc7bdee4dacc03cf59ac5be4bed92a75f8e720b 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 
bb70db452402dd690e2136a122e9b3bd11fa7522 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java 
f238eb5dd058fc79c5b7ad3b08920c774b1a7f8c 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 
f96a0481b870b04cc97621cd62a43b07ecd5d7fd 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java 
d2349104902c2af3d6020c9599fd3fa20f9a64a5 


Diff: https://reviews.apache.org/r/72109/diff/3/

Changes: https://reviews.apache.org/r/72109/diff/2-3/


Testing
---


Thanks,

Laszlo Pinter

Re: Review Request 72109: HIVE-20948: Eliminate file rename in compactor

2020-02-17 Thread Peter Vary via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72109/#review219603
---



LGTM +1, just minor nits?


ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java
Lines 97-98 (original), 95-96 (patched)


nit: Do we need these formatting changes?



ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java
Line 107 (original), 105 (patched)


nit: Do we need these formatting changes?



ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java
Line 131 (original), 129 (patched)


nit: Do we need these formatting changes?



ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java
Line 136 (original), 134 (patched)


nit: Do we need these formatting changes?


- Peter Vary


On febr. 11, 2020, 10:24 de, Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72109/
> ---
> 
> (Updated febr. 11, 2020, 10:24 de)
> 
> 
> Review request for hive, Karen Coppage, Marta Kuczora, and Peter Vary.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20948: Eliminate file rename in compactor
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 
> 9ad4e7148226b91b0c759de54e251893d61725a3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java 
> 076b77877ae748b757a4c9c08532a3ce029fed38 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 
> 2f5ec5270c0bc7d1a591c9c8c15b1ecb7f9f6ace 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 
> ecc7bdee4dacc03cf59ac5be4bed92a75f8e720b 
>   ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 
> bb70db452402dd690e2136a122e9b3bd11fa7522 
>   
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java 
> f238eb5dd058fc79c5b7ad3b08920c774b1a7f8c 
>   
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 
> f96a0481b870b04cc97621cd62a43b07ecd5d7fd 
>   ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java 
> d2349104902c2af3d6020c9599fd3fa20f9a64a5 
> 
> 
> Diff: https://reviews.apache.org/r/72109/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>

Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'

2020-02-17 Thread Laszlo Bodor 


> On Feb. 14, 2020, 3:23 p.m., Panos Garefalakis wrote:
> > +1 from me as well
> > As discussed the extra 0s in the query out are caused by the 
> > counters.findCounter() that initializes an empty counter when reading a non 
> > existent counter -- then all HIVE_COUNTERS are printed by 
> > PostExecTezSummaryPrinter
> 
> Laszlo Bodor wrote:
> I like this patch, and I would be happy to see a simple unit test (which 
> would be an integration test actually) which is about doing a simple update 
> and checking the improved output, I believe we have similar unit tests already

+1 with the new testcase (which fails without the patch for me locally, LGTM)


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72113/#review219591
---


On Feb. 13, 2020, 3:40 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72113/
> ---
> 
> (Updated Feb. 13, 2020, 3:40 p.m.)
> 
> 
> Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and 
> Ramesh Kumar Thangarajan.
> 
> 
> Bugs: HIVE-22870
> https://issues.apache.org/jira/browse/HIVE-22870
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Executing an update or insert statement in beeline doesn't show the actual 
> rows inserted/updated.
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
>  04dd0ddad2e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 
>   ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 9c5695ae603 
>   ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out 
> f9b5f8f0d4d 
>   ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 9ad0a9b7faf 
>   ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out 
> 3e99e0ee627 
>   ql/src/test/results/clientpositive/llap/retry_failure_reorder.q.out 
> baeac434d79 
>   ql/src/test/results/clientpositive/llap/tez_input_counters.q.out 
> 885cb0a9cba 
> 
> 
> Diff: https://reviews.apache.org/r/72113/diff/3/
> 
> 
> Testing
> ---
> 
> with insert and updates
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

[jira] [Created] (HIVE-22896) Increase fash hashtable size on detecting initial collision

2020-02-17 Thread Rajesh Balamohan (Jira) 
Rajesh Balamohan created HIVE-22896:
---

 Summary: Increase fash hashtable size on detecting initial 
collision
 Key: HIVE-22896
 URL: https://issues.apache.org/jira/browse/HIVE-22896
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Rajesh Balamohan


This would help in avoiding collisions and helps in burning lesser CPU cycles 
during probing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Laszlo Pinter via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/
---

Review request for hive, Karen Coppage and Peter Vary.


Repository: hive-git


Description
---

HIVE-21543: Use FilterHooks for show compactions


Diffs
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 c7e1044589fd1dd970b86259b713d3a44716e7b8 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
 d9da00dd2148b0408548ab7d5c88df014a7f7826 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 7b7c2d77914ad56d3ae568aa050725b12969895a 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
 23faa7444a8e9f9c010290539f89b9d8b44f3aa8 


Diff: https://reviews.apache.org/r/72145/diff/1/


Testing
---


Thanks,

Laszlo Pinter

Re: Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72143/
---

(Updated Feb. 17, 2020, 9:15 a.m.)


Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.


Bugs: HIVE-22892
https://issues.apache.org/jira/browse/HIVE-22892


Repository: hive-git


Description
---

Unable to compile query if CTE joined


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
f7ac6d3bfa 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 8986315690 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33d3beba46 
  ql/src/test/queries/clientpositive/cte_join.q PRE-CREATION 
  ql/src/test/results/clientpositive/cte_join.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/72143/diff/2/

Changes: https://reviews.apache.org/r/72143/diff/1-2/


Testing
---

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver 
-Dqfile=cte_join.q -pl itests/qtest -Pitests


Thanks,

Krisztian Kasa

Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72143/
---

Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.


Bugs: HIVE-22892
https://issues.apache.org/jira/browse/HIVE-22892


Repository: hive-git


Description
---

Unable to compile query if CTE joined


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
f7ac6d3bfa 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 8986315690 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 33d3beba46 
  ql/src/test/queries/clientpositive/cte_join.q PRE-CREATION 
  ql/src/test/results/clientpositive/cte_join.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/72143/diff/1/


Testing
---

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver 
-Dqfile=cte_join.q -pl itests/qtest -Pitests


Thanks,

Krisztian Kasa