Re: Review Request 72437: Reduce number of DB calls in ObjectStore::getPartitionsByExprInternal

2020-05-04 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72437/#review220616 ---

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread John Sherman
> On May 5, 2020, 1:59 a.m., John Sherman wrote: > > ql/src/test/results/clientpositive/llap/mapjoin_hook.q.out > > Line 41 (original), 41 (patched) > > > > > > Same as above Not same as above, prior one failed due

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread John Sherman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220612 --- I didn't call out every spot where order changed of results

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220613 --- ql/src/test/results/clientpositive/llap/leadlag_queries.q.out

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Steve Carlin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220611 ---

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220610 --- ql/src/test/results/clientpositive/llap/input_part3.q.out Line

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Jesús Camacho Rodríguez
> On May 4, 2020, 9:20 p.m., Steve Carlin wrote: > > ql/src/test/results/clientpositive/llap/groupby_sort_skew_1_23.q.out > > Line 49 (original), 49 (patched) > > > > > > This file is a bit overwhelming to check. 8K

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Jesús Camacho Rodríguez
> On May 4, 2020, 5:20 p.m., Zoltan Haindrich wrote: > > ql/src/test/results/clientpositive/llap/join_cond_pushdown_unqual5.q.out > > Line 100 (original), 114 (patched) > > > > > > the CASE have been pushed into the

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Steve Carlin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220608 --- ql/src/test/results/clientpositive/llap/groupby_sort_8.q.out

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220607 ---

[jira] [Created] (HIVE-23366) Investigate why bucket_map_join*, bucketcontext_* and bucketmapjoin* tests are missing bucket map join when run under TestMiniLlapLocalCliDriver

2020-05-04 Thread Vineet Garg (Jira)
Vineet Garg created HIVE-23366: -- Summary: Investigate why bucket_map_join*, bucketcontext_* and bucketmapjoin* tests are missing bucket map join when run under TestMiniLlapLocalCliDriver Key: HIVE-23366 URL:

[jira] [Created] (HIVE-23365) Put RS deduplication optimization under cost based decision

2020-05-04 Thread Jesus Camacho Rodriguez (Jira)
Jesus Camacho Rodriguez created HIVE-23365: -- Summary: Put RS deduplication optimization under cost based decision Key: HIVE-23365 URL: https://issues.apache.org/jira/browse/HIVE-23365

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/#review220597 --- ql/src/test/results/clientpositive/llap/join45.q.out Line 1104

Re: What's master key in hive metastore?

2020-05-04 Thread Alan Gates
It is used in storing delegation tokens, which HS2 and the megastore need to act on the user's behalf when reading files, launching jobs, etc. See DelegationTokenStore. Alan. On Mon, May 4, 2020 at 2:00 AM Xi Chen wrote: > Dear all, > > I find several APIs about master key in hive metastore

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Denys Kuzmenko via Review Board
> On May 4, 2020, 3:21 p.m., Marton Bod wrote: > > Looks good to me, just a couple of questions. Thank you for the review! > On May 4, 2020, 3:21 p.m., Marton Bod wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > > Lines 2226 (patched) > >

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Denys Kuzmenko via Review Board
> On May 4, 2020, 3:21 p.m., Marton Bod wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > > Lines 2231 (patched) > > > > > > nit: this appears in a few places, might make sense to

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/ --- (Updated May 4, 2020, 4:33 p.m.) Review request for hive, Marton Bod, Peter

[jira] [Created] (HIVE-23364) Push down null-safe cast-s

2020-05-04 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23364: --- Summary: Push down null-safe cast-s Key: HIVE-23364 URL: https://issues.apache.org/jira/browse/HIVE-23364 Project: Hive Issue Type: Improvement

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Denys Kuzmenko via Review Board
> On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidCompactionHistoryService.java > > Line 31 (original), 32 (patched) > > >

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Marton Bod
> On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > LGTM , just few questions Thanks for the review! > On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > > Line 153 (original) > >

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/#review220594 --- LGTM , just few questions

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/#review220595 --- Looks good to me, just a couple of questions.

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220593 ---

[jira] [Created] (HIVE-23363) Upgrade DataNucleus dependency to 5.2

2020-05-04 Thread Zoltan Chovan (Jira)
Zoltan Chovan created HIVE-23363: Summary: Upgrade DataNucleus dependency to 5.2 Key: HIVE-23363 URL: https://issues.apache.org/jira/browse/HIVE-23363 Project: Hive Issue Type: Improvement

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/ --- (Updated May 4, 2020, 1:32 p.m.) Review request for hive, Marton Bod, Peter

Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/ --- Review request for hive, Marton Bod, Peter Varga, and Peter Vary. Bugs:

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 4, 2020, 1:22 p.m.) Review request for hive and Denys Kuzmenko.

Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git

Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

2020-05-04 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72466/ --- Review request for hive, Jesús Camacho Rodríguez, John Sherman, Zoltan

[jira] [Created] (HIVE-23362) Repl dump returns dump location and repl id even in case of failure

2020-05-04 Thread Aasha Medhi (Jira)
Aasha Medhi created HIVE-23362: -- Summary: Repl dump returns dump location and repl id even in case of failure Key: HIVE-23362 URL: https://issues.apache.org/jira/browse/HIVE-23362 Project: Hive

What's master key in hive metastore?

2020-05-04 Thread Xi Chen
Dear all, I find several APIs about master key in hive metastore and IMetastoreClient. I searched around but didn't find any usage in hive DDL tasks. Any idea where this master key is designed for? Thanks in advance, bargitta int addMasterKey(String key) throws MetaException, TException; void

Re: Review Request 72451: Add tests to cover database managed location related DDL and fix minor issues

2020-05-04 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72451/#review220565 ---

Re: Review Request 72431: HIVE-23206

2020-05-04 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72431/ --- (Updated May 4, 2020, 7:55 a.m.) Review request for hive, Jesús Camacho

Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- Review request for hive and Denys Kuzmenko. Repository: hive-git Description

Re: Review Request 72431: HIVE-23206

2020-05-04 Thread Krisztian Kasa
> On April 27, 2020, 6:02 p.m., Vineet Garg wrote: > > ql/src/test/results/clientpositive/llap/keep_uniform.q.out > > Lines 946 (patched) > > > > > > Why is there an extra join in the plan now? > > Krisztian Kasa

[jira] [Created] (HIVE-23361) Optimising privilege synchroniser

2020-05-04 Thread Simhadri G (Jira)
Simhadri G created HIVE-23361: - Summary: Optimising privilege synchroniser Key: HIVE-23361 URL: https://issues.apache.org/jira/browse/HIVE-23361 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-23360) Unable to create Connection using the Ambari default PORT (working fine if Port is taken as 10000)

2020-05-04 Thread Sukhpreet Kaur (Jira)
Sukhpreet Kaur created HIVE-23360: - Summary: Unable to create Connection using the Ambari default PORT (working fine if Port is taken as 1) Key: HIVE-23360 URL: