Re: Review Request 34713: Invalidate basic stats for insert queries if autogather=false

://reviews.apache.org/r/34713/diff/ Testing --- Existing tests + added new tests Thanks, Ashutosh Chauhan

Re: Refactor code for avoiding comparing Strings

Seems like you are on really old version of Hive. Do you have following patches on your tree? https://issues.apache.org/jira/browse/HIVE-3616 https://issues.apache.org/jira/browse/HIVE-6095 https://issues.apache.org/jira/browse/HIVE-6116 https://issues.apache.org/jira/browse/HIVE-6121

Review Request 39768: HIVE-12181

/39768/diff/ Testing --- Existing test Thanks, Ashutosh Chauhan

Re: PreCommit-HIVE-TRUNK-Build

https://issues.apache.org/jira/browse/HIVE-12253 On Fri, Oct 23, 2015 at 5:34 PM, Eugene Koifman wrote: > Does anyone know what is going on here? All the runs are failing to build > > >

Review Request 39555: HIVE-12224

3517a60 ql/src/test/queries/clientpositive/ddltime.q 3eead6f ql/src/test/results/clientnegative/ddltime.q.out 25d9af6 ql/src/test/results/clientpositive/ddltime.q.out ec8938d Diff: https://reviews.apache.org/r/39555/diff/ Testing --- Thanks, Ashutosh Chauhan

Re: Review Request 39836: HIVE-12309

mplete/missing stats. - Ashutosh Chauhan On Oct. 31, 2015, 10:11 p.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: displaying Target Version on JIRA

AFAIK there is no way to accomplish that except INFRA ticket. On Thu, Nov 12, 2015 at 11:53 AM, Sergey Shelukhin wrote: > Hi. Is it possible to display the new Target Version field in the JIRA by > default, even if empty? Near Fix Version if possible :) > I think this

Re: Review Request 40359: HIVE-11110 Cost Based Optimizer improvements

apache.org/r/40359/#comment165481> It will be good to document ordering of optimization rules here to reflect current thinking for chosen ordering. It will help later when we are adding new rules or need to change order. - Ashutosh Chauhan On Nov. 16, 201

Re: Review Request 40359: HIVE-11110 Cost Based Optimizer improvements

pache.org/r/40359/#comment165529> Extra column than mandated. Col pruning issue. ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out (line 472) <https://reviews.apache.org/r/40359/#comment165530> More columns selected than needed. - Ashutosh Chauhan On Nov. 16,

Review Request 39957: HIVE-12289

: https://reviews.apache.org/r/39957/diff/ Testing --- Thanks, Ashutosh Chauhan

Review Request 39960: HIVE-12331

ting tests Thanks, Ashutosh Chauhan

Review Request 39909: HIVE-12320

: https://reviews.apache.org/r/39909/diff/ Testing --- Existing test suite. Thanks, Ashutosh Chauhan

Re: Review Request 39909: HIVE-12320

/parquet_schema_evolution.q af0cf99 serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java a4323d1 Diff: https://reviews.apache.org/r/39909/diff/ Testing --- Existing test suite. Thanks, Ashutosh Chauhan

Re: Review Request 39909: HIVE-12320

u are right, we should not allow those conversions. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39909/#review104949 ------

Review Request 39950: HIVE-12329

/vectorization_part_project.q.out f98e79c ql/src/test/results/clientpositive/vectorization_short_regress.q.out 570e649 Diff: https://reviews.apache.org/r/39950/diff/ Testing --- Existing tests Thanks, Ashutosh Chauhan

Re: Review Request 39909: HIVE-12320

/parquet_schema_evolution.q af0cf99 serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 24361c7 Diff: https://reviews.apache.org/r/39909/diff/ Testing --- Existing test suite. Thanks, Ashutosh Chauhan

Target Version in Jira

Historically there has always been a confusion about Fix Version. To reduce that confusion, I requested asf infra to add target version field for Hive jira and they promptly added that. So, now we have an additional target version for jira tickets. If you are creating new ticket, it will show up

Re: Review Request 39960: HIVE-12331

ting --- Existing tests Thanks, Ashutosh Chauhan

Review Request 40028: HIVE-12332

/queries/clientpositive/insertoverwrite_bucket.q d939710 ql/src/test/results/clientpositive/insertoverwrite_bucket.q.out 9b7b85d Diff: https://reviews.apache.org/r/40028/diff/ Testing --- Added new test Thanks, Ashutosh Chauhan

Review Request 39836: HIVE-12309

ql/src/test/results/clientpositive/tez/llapdecider.q.out 676a0e4 Diff: https://reviews.apache.org/r/39836/diff/ Testing --- Existing tests Thanks, Ashutosh Chauhan

Review Request 39374: HIVE-12164

a6f1148 ql/src/test/queries/clientpositive/stats19.q ccdad6b ql/src/test/queries/clientpositive/stats_only_null.q b2bd4dc ql/src/test/queries/clientpositive/statsfs.q 82a2295 Diff: https://reviews.apache.org/r/39374/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Review Request 39236: HIVE-12065

, Ashutosh Chauhan

Review Request 39247: HIVE-12010

/clientpositive/unionDistinct_1.q.out 81c46da ql/src/test/results/clientpositive/vectorized_ptf.q.out 5e6a72e Diff: https://reviews.apache.org/r/39247/diff/ Testing --- Existing Tests. Thanks, Ashutosh Chauhan

Re: Review Request 36284: HIVE-11197

://reviews.apache.org/r/36284/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Review Request 36284: HIVE-11197

://reviews.apache.org/r/36284/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Review Request 36253: HIVE-11171

/mrr.q.out d42f9b0 ql/src/test/results/clientpositive/tez/skewjoin.q.out ec368f9 ql/src/test/results/clientpositive/tez/tez_union.q.out 4012b90 Diff: https://reviews.apache.org/r/36253/diff/ Testing --- Existing tests Thanks, Ashutosh Chauhan

[Discuss] Patch submission and commit format

There was a problem of attributing contributions correctly back when we were using svn, now that we are on git, that problem can be addressed. This email is an effort to solicit feedback for it. Problem: In svn, there is only a committer field, so when committer was committing someone else's

Re: Review Request 40055: HIVE-12017

/CalcitePlanner.java (lines 883 - 889) <https://reviews.apache.org/r/40055/#comment165724> All these rules don't need stats, it will be better to move them out of try block, so that we still leverage them even when stats are not available. - Ashutosh Chauhan On Nov. 16, 2015, 6:16 p.m.,

Review Request 37919: Add AggregateProjectMergeRule

/clientpositive/vectorized_parquet.q.out 7b2dc6d ql/src/test/results/clientpositive/vectorized_parquet_types.q.out 8d1bddc ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out f66903b Diff: https://reviews.apache.org/r/37919/diff/ Testing --- Thanks, Ashutosh Chauhan

Re: Review Request 37919: Add AggregateProjectMergeRule

/ Testing --- Thanks, Ashutosh Chauhan

Re: BONECP

We need to move to DN 4.x for other reasons as well. See : https://issues.apache.org/jira/browse/HIVE-11036 On Wed, Sep 16, 2015 at 4:59 PM, Vaibhav Gumashta wrote: > It seems for the version of DataNucleus that we have (3.2.X), it does not > support HikariCP: >

Review Request 38871: HIVE-11972

/hadoop/hive/ql/plan/DynamicPartitionCtx.java 24db7d0 ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java c6ae030 Diff: https://reviews.apache.org/r/38871/diff/ Testing --- Existing regression suite. Thanks, Ashutosh Chauhan

Review Request 38583: HIVE-10785

ql/src/test/results/clientpositive/tez/vectorized_nested_mapjoin.q.out 74be17b ql/src/test/results/clientpositive/vectorized_nested_mapjoin.q.out 6a9532e Diff: https://reviews.apache.org/r/38583/diff/ Testing --- Added new tests and existing test cases. Thanks, Ashutosh Chauhan

Re: Review Request 38583: HIVE-10785

://reviews.apache.org/r/38583/diff/ Testing --- Added new tests and existing test cases. Thanks, Ashutosh Chauhan

Review Request 38493: HIVE-11132

/ReduceSinkDeDuplication.java 56334ed ql/src/test/queries/clientpositive/join_grp_diff_keys.q PRE-CREATION ql/src/test/results/clientpositive/join_grp_diff_keys.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38493/diff/ Testing --- New q test and regression suite. Thanks, Ashutosh

unit tests in patches

Hi everyone, Generally, its a good idea to add unit tests in patches especially when its easy to repro (e.g,., NPE). This may not always be possible, but we should aim to add tests wherever we can. In addition to regression testing, tests also proves the existence of bug. I would especially like

Re: Review Request 38493: HIVE-11132

://reviews.apache.org/r/38493/diff/ Testing --- New q test and regression suite. Thanks, Ashutosh Chauhan

Re: [ANNOUNCE] New Hive PMC Chair - Ashutosh Chauhan

hu, Sep 17, 2015 at 1:09 AM, Carl Steinbach <c...@apache.org> wrote: > >> I am very happy to announce that Ashutosh Chauhan is taking over as the >> new VP of the Apache Hive project. Ashutosh has been a longtime contributor >> to Hive and has played a pivotal role in

Review Request 40876: Default mode for hive.mapred.mode should be strict

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40876/ --- Review request for hive. Bugs: HIVE-12413

Re: Review Request 40976: [REFACTOR] Make physical compiler more type safe

, Ashutosh Chauhan

Review Request 40976: [REFACTOR] Make physical compiler more type safe

. Thanks, Ashutosh Chauhan

Review Request 40827: HIVE-12491

/clientpositive/cbo_rp_auto_join0.q.out 7822ad9 ql/src/test/results/clientpositive/tez/explainuser_1.q.out a3d1f87 Diff: https://reviews.apache.org/r/40827/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Re: Review Request 40827: HIVE-12491

. Thanks, Ashutosh Chauhan

Review Request 41176: HIVE-12643

/hadoop/hive/ql/plan/PartitionDesc.java b032349 Diff: https://reviews.apache.org/r/41176/diff/ Testing --- existing tests Thanks, Ashutosh Chauhan

Review Request 41297: HIVE-12590

Thanks, Ashutosh Chauhan

Re: Review Request 41176: HIVE-12643

/src/test/results/clientpositive/vector_partition_diff_num_cols.q.out 92ee800 Diff: https://reviews.apache.org/r/41176/diff/ Testing --- existing tests Thanks, Ashutosh Chauhan

Re: Review Request 41721: MetadataUpdater: provide a mechanism to edit the basic statistics of a table (or a partition)

rawDS, throw exception saying invalid stat key. - Ashutosh Chauhan On Dec. 30, 2015, 1:54 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 41482: StatsSetupConst.COLUMN_STATS_ACCURATE is not used correctly

e state of stats is or we can leave the stale stats with stats flag set to false. - Ashutosh Chauhan On Dec. 23, 2015, 6:22 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 41297: HIVE-12590

3edaff0 Diff: https://reviews.apache.org/r/41297/diff/ Testing --- Added new test Thanks, Ashutosh Chauhan

Re: Review Request 41723: HIVE-12372: Improve to support the multibyte character at lpad and rpad

/reviews.apache.org/r/41723/#comment172422> This loop can be optimized using one of stringbuilder::append() overload methods. - Ashutosh Chauhan On Dec. 26, 2015, 1:08 p.m., Shinichi Yamashita wrote: > > --- > This is an a

[ANNOUNCE] New PMC Member : John Pullokkaran

On behalf of the Hive PMC I am delighted to announce John Pullokkaran is joining Hive PMC. John is a long time contributor in Hive and is focusing on compiler and optimizer areas these days. Please give John a warm welcome to the project! Ashutosh

Re: Review Request 39960: HIVE-12331

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39960/#review107468 --- On Nov. 5, 2015, 8:50 p.m., Ashutosh Chauhan wrote: > > --- > This is an

Review Request 48190: HIVE-13933

Diff: https://reviews.apache.org/r/48190/diff/ Testing --- Regression suite. Thanks, Ashutosh Chauhan

Re: [discuss] jdk8 support

enkins has been running all > tests in Java8 successfully for a week now. > There are still a few tests we need to fix, but so far is looking good. > > Sergio > > On Fri, Jun 3, 2016 at 12:02 AM, Ashutosh Chauhan <hashut...@apache.org> > wrote: > > > Now that branch-2.1

Re: [discuss] jdk8 support

> >> wrote: > >> >> > >> >> > Option 3 sounds good. I'd ideally like to make JDK8 the minimum > >> >> requirement > >> >> > soon as well. > >> >> > > >> >> > On Mon, Apr 11, 2016 at 4:59 PM, Sz

Re: Review Request 48500: HIVE-13982

t for 2nd RS. What if there is a PTF operator in between. Will merging be triggered in that case? If so, will it be valid? ql/src/test/results/clientpositive/vector_groupby_reduce.q.out (line 788) <https://reviews.apache.org/r/48500/#comment202950> Plan change expected? - Ashut

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

2867 - 2876) <https://reviews.apache.org/r/47916/#comment200349> I don't think this is needed. This codepath gets exercised when dest is pre-existing. There is no need to set permissions in that case. - Ashutosh Chauhan On May 27, 2016, 7:42 p.m., Hari Sankar Sivarama Subramaniyan

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

tus.getGroup()) to protect against NPE in case targetStatus.getGroup() returns null. - Ashutosh Chauhan On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 47838: HIVE-13831

<https://reviews.apache.org/r/47838/#comment200020> I think you may use single boolean variable here and name it as nonEqualityPredicate - Ashutosh Chauhan On May 25, 2016, 5:59 p.m., Jesús Camacho Rodríguez wrote: > > --- > Thi

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

2889) <https://reviews.apache.org/r/47916/#comment200042> As i mentioned satus - Ashutosh Chauhan On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

> On May 26, 2016, 8:57 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2889 > > <https://reviews.apache.org/r/47916/diff/1/?file=1395707#file1395707line2889> > > > > As i mentioned satus Your first patch wa

Re: Review Request 49052: Insert overwrite does not work in HBase tables: stats is not updated

). ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 6536) <https://reviews.apache.org/r/49052/#comment204228> getInputs(), getOutputs() - Ashutosh Chauhan On June 21, 2016, 11:41 p.m., pen

Re: [discuss] decimals vs doubles in Hive

What about my suggestions to treat non-integral constant literals as BigDecimal instead of Double? I checked on other products and thats what MySQL, Oracle & SQL server is doing. Thanks, Ashutosh On Tue, Jun 14, 2016 at 4:07 PM, Alan Gates wrote: > I’m +1 on reverting it.

Re: [discuss] decimals vs doubles in Hive

; Doesn’t the patch in question do the reverse? I think we can have a > follow-up JIRA if it’s not already done in all circumstances, without the > patch. > > On 16/6/14, 16:13, "Ashutosh Chauhan" <ashutosh.chau...@gmail.com> wrote: > > >What about my sugge

Re: Review Request 48500: HIVE-13982

Awesome! ql/src/test/results/clientpositive/vectorization_short_regress.q.out (line 2315) <https://reviews.apache.org/r/48500/#comment204424> Awesome! - Ashutosh Chauhan On June 22, 2016, 8:27 p.m., Jesús Camacho Rodríguez wrote: > > --

Re: Assign JIRA to myself

Hi Peter, I have added you in a contributor list. Now it should be possible for you to assign jira to yourself. Thanks, Ashutosh On Wed, Jun 15, 2016 at 11:22 PM, Peter Vary wrote: > Hi, > > Thanks for the fast answer. > Who should I ask to add me as a contributor? 6 days

Review Request 42116: HIVE-12824

://reviews.apache.org/r/42116/diff/ Testing --- windowing_gby.q Thanks, Ashutosh Chauhan

Re: Review Request 41482: StatsSetupConst.COLUMN_STATS_ACCURATE is not used correctly

op/hive/ql/optimizer/StatsOptimizer.java (lines 373 - 375) <https://reviews.apache.org/r/41482/#comment175099> Now that we are making sure, in case of invalid stats, we are removing them, we can possibly uplift this restriction.

Re: Review Request 48500: HIVE-13982

> On June 23, 2016, 3 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/reduce_deduplicate_extended2.q, line 3 > > <https://reviews.apache.org/r/48500/diff/7/?file=1427709#file1427709line3> > > > > We need to explore this

Review Request 43431: HIVE-13033 SPDO unnecessarily duplicates columns in key & value of mapper output

/SortedDynPartitionOptimizer.java 27b0457 ql/src/test/results/clientpositive/dynpart_sort_opt_vectorization.q.out 8813802 ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 2105d8b Diff: https://reviews.apache.org/r/43431/diff/ Testing --- Regression suites. Thanks, Ashutosh Chauhan

Re: Review Request 42671: Improve dynamic partition loading

/DynamicPartitionCtx.java 95d5635 Diff: https://reviews.apache.org/r/42671/diff/ Testing --- Regression test suite. Thanks, Ashutosh Chauhan

Review Request 42758: Improve dynamic partition loading

/TestDbNotificationListener.java 56f5c8b ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java efb50b2 ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java c8895c2 Diff: https://reviews.apache.org/r/42758/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Review Request 43142: Improve dynamic partition loading III

/apache/hadoop/hive/ql/metadata/Hive.java 0bab769 Diff: https://reviews.apache.org/r/43142/diff/ Testing --- Regression suite Thanks, Ashutosh Chauhan

Re: Review Request 43885: HIVE-13102

esults/clientpositive/ppd_udf_col.q.out (line 117) <https://reviews.apache.org/r/43885/#comment181798> Seems like we missed opportunity to fold constant here. - Ashutosh Chauhan On Feb. 23, 2016, 5:27 p.m., Jesús Camacho Rod

Re: Review Request 43834: Support view column authorization

/r/43834/#comment181811> User name: hive_test_user - Ashutosh Chauhan On Feb. 22, 2016, 3:24 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To

Review Request 43836: Don't create empty bucket files

/Hadoop23Shims.java 31060a2 Diff: https://reviews.apache.org/r/43836/diff/ Testing --- Regression suite Thanks, Ashutosh Chauhan

Review Request 42671: Improve dynamic partition loading

suite. Thanks, Ashutosh Chauhan

Re: Review Request 42359: HIVE-12805: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure

/HiveJoinToMultiJoinRule.java (line 263) <https://reviews.apache.org/r/42359/#comment176475> Do we really need to find uniqueness of expression? Can we do numKeys = joinLeafPredInfo.getJoinExprs(i).size() ? - Ashutosh Chauhan On Jan. 19, 2016, 9 p.m., Hari Sankar Sivarama Subram

Re: Review Request 42671: Improve dynamic partition loading

/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 5b4365c ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java 95d5635 Diff: https://reviews.apache.org/r/42671/diff/ Testing --- Regression test suite. Thanks, Ashutosh Chauhan

Review Request 43626: HIVE-12988

suite Thanks, Ashutosh Chauhan

Re: Review Request 44756: Support masking and filtering of rows/columns

ty/authorization/plugin/HiveAuthorizer.java (line 300) <https://reviews.apache.org/r/44756/#comment186093> We should add additional method boolean needToEnforceRowColumnTransformation(String username) so that we can avoid traversing AST tree if this method returns false. - Ashutosh Ch

Re: Review Request 43626: HIVE-12988

/HiveConf.java 5098851 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ad17096 shims/common/src/main/java/org/apache/hadoop/fs/ProxyFileSystem.java cb1e2b7 Diff: https://reviews.apache.org/r/43626/diff/ Testing --- Regression suite Thanks, Ashutosh Chauhan

Re: Review Request 44756: Support masking and filtering of rows/columns

sform(String database, String table); - Ashutosh Chauhan On March 18, 2016, 4:59 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command

is may cause backward compatibility issue. ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 324) <https://reviews.apache.org/r/45274/#comment190820> Constraint name should be computed at Metastore server, not in client. - Ashutosh Chauhan On March 24, 2016, 7:08

Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information

pc/if/TCLIService.thrift (line 982) <https://reviews.apache.org/r/44031/#comment190760> There is no catalog in Hive. service-rpc/if/TCLIService.thrift (line 985) <https://reviews.apache.org/r/44031/#comment190761> Database - Ashutosh Chauhan On March 29, 2016, 12:11 a.m

Re: recent metastore failures in HiveQA

I can repro locally hang of TestJdbcWithMiniHS2 and I also saw it hanging on recent QA runs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-7556/failed/TestJdbcWithMiniHS2/ Wondering if you guys have seen this? Thanks, Ashutosh On Tue, Apr 12, 2016 at 11:28

Re: Review Request 45697: HIVE-13380 : Decimal should have lower precedence than Double/Float

tosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45697/#review128049 --- On April 5, 2016, 1:23 a.m., Ashutosh Cha

Re: [discuss] jdk8 support

Hi Mohit, I also think option 3 makes sense. We should strive to keep test matrix small so that we can do fast QA runs for dev patches. We can just use jdk7 to build & test Hive1 and jdk8 to build & test Hive2. However, I am not sure of explicitly dropping support altogether for jdk7 on Hive2. We

Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information

<https://reviews.apache.org/r/45406/#comment191717> Neither for this. - Ashutosh Chauhan On April 11, 2016, 5:45 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 44756: Support masking and filtering of rows/columns

No need to provide context. Its already available to impl. - Ashutosh Chauhan On March 17, 2016, 6:03 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44913: HIVE-11424

PCR failed to remove filter on partition columns ql/src/test/results/clientpositive/tez/bucketpruning1.q.out (line 1106) <https://reviews.apache.org/r/44913/#comment186187> Pretty neat. Bucket pruning kicked in. - Ashutosh Chauhan

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

/GenericUDFFormatNumber.java (line 178) <https://reviews.apache.org/r/18182/#comment183440> I assume you only allow F to be a constant string. If so, this evaluation can happen at compile time in initialize(). You can obtain value via ConstantStringOI. - Ashutosh Chauhan On March 1, 2016, 11:

Review Request 45602: TS/Date should have higher precedence in type hierarchy than string group

ults/clientpositive/cast_on_constant.q.out PRE-CREATION Diff: https://reviews.apache.org/r/45602/diff/ Testing --- New test & existing regression suite. Thanks, Ashutosh Chauhan

Review Request 45658: HIVE-13373 : Use most specific type for numerical constants

tive/vectorization_short_regress.q.out 91c10f0 Diff: https://reviews.apache.org/r/45658/diff/ Testing --- New test & regression suite. Thanks, Ashutosh Chauhan

Re: Review Request 45658: HIVE-13373 : Use most specific type for numerical constants

/src/test/results/clientpositive/vectorization_0.q.out 53dffed ql/src/test/results/clientpositive/vectorization_short_regress.q.out 91c10f0 Diff: https://reviews.apache.org/r/45658/diff/ Testing --- New test & regression suite. Thanks, Ashutosh Chauhan

Re: Review Request 45697: HIVE-13380 : Decimal should have lower precedence than Double/Float

://reviews.apache.org/r/45697/diff/ Testing --- Regression suite Thanks, Ashutosh Chauhan

Re: Failing tests, precommit test runtimes

I agree with disabling these tests till we are able to fix it. Since bug seems to be in spark runtime, it may take a little while to fix it. Increased run time for QA till then would be waste of resources. Thanks, Ashutosh On Tue, Mar 29, 2016 at 9:06 AM, Siddharth Seth wrote:

Re: Review Request 45611: HIVE-13360: Refactoring Hive Authorization

- 111) <https://reviews.apache.org/r/45611/#comment189690> it will be good to add comments for these. - Ashutosh Chauhan On April 2, 2016, 12:54 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 45602: TS/Date should have higher precedence in type hierarchy than string group

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45602/#review126882 ------- On April 1, 2016, 8:49 p.m., Ashutosh Chauhan wrote: > > -

Review Request 45697: HIVE-13380 : Decimal should have lower precedence than Double/Float

, Ashutosh Chauhan

<    2   3   4   5   6   7   8   9   10   11   >