://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
---
On Aug. 20, 2014, 8:04 p.m., David Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23797
86d23f10a66f9a33023e2153202b970c386bae20
Diff: https://reviews.apache.org/r/24136/diff/
Testing (updated)
---
Run unit tests.
Thanks,
David Chen
/AvroSerDe.java
69545b046db06fd56f35a0da09d3d6960832484d
Diff: https://reviews.apache.org/r/24136/diff/
Testing
---
Run unit tests.
Thanks,
David Chen
/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
69545b046db06fd56f35a0da09d3d6960832484d
Diff: https://reviews.apache.org/r/24136/diff/
Testing
---
Run unit tests.
Thanks,
David Chen
/
Testing
---
Confirmed that core Avro is now included in the hive-exec jar. Successfully ran
sample query against table registered with the AvroSerDe.
Thanks,
David Chen
Hi all,
Have the unit tests been disabled? I am testing a patch, and I tried
running mvn test but it appears that none of the unit tests were run.
Thanks,
David
://reviews.apache.org/r/22033/diff/
Testing
---
Thanks,
David Chen
/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java
PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
---
Thanks,
David Chen
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java
be7134fabf2c487fb2936f171fe30bb53b392ec1
Diff: https://reviews.apache.org/r/22069/diff/
Testing
---
All hcatalog-core tests pass.
Thanks,
David Chen
/
Testing
---
All hcatalog-core tests pass.
Thanks,
David Chen
tests pass.
Thanks,
David Chen
hcatalog-core tests pass.
Thanks,
David Chen
. To reply, visit:
https://reviews.apache.org/r/22033/#review45537
---
On May 29, 2014, 7:33 p.m., David Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/hcatalog/mapreduce/FileRecordWriterContainer.java
b55a05528d5a4eed114b5628697cf5a60f6c6cbc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticPartitionFileRecordWriterContainer.java
PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
---
Thanks,
David Chen
/browse/HIVE-7230
Repository: hive-git
Description
---
HIVE-7230: Add Eclipse formatter file.
Diffs
-
eclipse-styles.xml PRE-CREATION
Diff: https://reviews.apache.org/r/22590/diff/
Testing
---
Manual
Thanks,
David Chen
/22590/diff/
Testing
---
Manual
Thanks,
David Chen
b55a05528d5a4eed114b5628697cf5a60f6c6cbc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticPartitionFileRecordWriterContainer.java
PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
---
Thanks,
David Chen
/hive/hcatalog/util/TestAvroTypeInfoSchemaConverter.java
PRE-CREATION
hcatalog/core/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
hcatalog/core/src/test/java/org/apache/hive/hcatalog/util/TestAvroTypeInfoSchemaConverter.java
PRE-CREATION
hcatalog/core/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
---
Thanks,
David Chen
0040f3c9df690c44a1bc2f258cb075dbaaa585f3
ql/src/test/results/clientpositive/storage_format_descriptor.q.out
PRE-CREATION
ql/src/test/results/clientpositive/tez/ctas.q.out
a58e16639d725c851cedfc7bb81d65c25f3c56c3
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
-CREATION
ql/src/test/results/clientpositive/tez/ctas.q.out
a58e16639d725c851cedfc7bb81d65c25f3c56c3
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
/clientpositive/storage_format_descriptor.q.out
PRE-CREATION
ql/src/test/results/clientpositive/tez/ctas.q.out
a58e16639d725c851cedfc7bb81d65c25f3c56c3
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
/test/results/clientpositive/storage_format_descriptor.q.out
PRE-CREATION
ql/src/test/results/clientpositive/tez/ctas.q.out
6b4c69019d45976bd0ccb705331948cd240e5750
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
6b4c69019d45976bd0ccb705331948cd240e5750
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
,
David Chen
://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
/r/23153/diff/
Testing
---
Thanks,
David Chen
/AvroSchemaGenerator.java
https://reviews.apache.org/r/23387/#comment83713
It might be better to call this TypeInfoToSchema to make it consistent with
SchemaToTypeInfo, which converts from Avro Schema to Hive TypeInfo.
- David Chen
On July 10, 2014, 4:50 a.m., Ashish Singh wrote
b5aff959e9acd15efb51f476673b71811a8019c8
ql/src/test/results/clientpositive/union_top_level.q.out
a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
/clientpositive/union_top_level.q.out
a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
b5aff959e9acd15efb51f476673b71811a8019c8
ql/src/test/results/clientpositive/union_top_level.q.out
a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
---
Thanks,
David Chen
/TestTypeInfoToSchema.java
https://reviews.apache.org/r/23387/#comment83950
These lines should be indented 4 spaces rather than 2. Same with other
places in this file where lines are split.
- David Chen
On July 14, 2014, 10:05 p.m., Ashish Singh wrote
---
Thanks,
David Chen
-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
PRE-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
/TypeInfoToSchema.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
PRE-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
/avro/TypeInfoToSchema.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
PRE-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
and similarly in other qfiles added as part of this patch.
- David Chen
On July 17, 2014, 2:50 a.m., Ashish Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23387
On July 17, 2014, 5:33 a.m., David Chen wrote:
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java, line 37
https://reviews.apache.org/r/23387/diff/8/?file=634143#file634143line37
Is using AVROFILE rather than AVRO a common use case? If not, should we
be allowing both
(record1.avsc).openStream());
- David Chen
On July 17, 2014, 9:10 p.m., Ashish Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23387
On July 19, 2014, 12:43 a.m., David Chen wrote:
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java,
line 294
https://reviews.apache.org/r/23387/diff/9/?file=634616#file634616line294
It would improve maintainability to keep the test schemas in separate
a8ce61aaad42b03e4de346530d0724f3d69776b9
Diff: https://reviews.apache.org/r/23730/diff/
Testing
---
Thanks,
David Chen
-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java
a8ce61aaad42b03e4de346530d0724f3d69776b9
Diff: https://reviews.apache.org/r/23730/diff/
Testing
---
Thanks,
David Chen
/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java
a8ce61aaad42b03e4de346530d0724f3d69776b9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
/TypeInfoToSchema.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
PRE-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
---
Thanks,
David Chen
/TestPigHCatUtil.java
a8ce61aaad42b03e4de346530d0724f3d69776b9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
/TestOrcHCatStorer.java
1084092828a9ac5e37f5b50b9c6bbd03f70b48fd
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java
a8ce61aaad42b03e4de346530d0724f3d69776b9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
/TypeInfoToSchema.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
PRE-CREATION
serde/src/test/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23387/#review48563
---
Ship it!
Ship It!
- David Chen
On July 23, 2014, 6:38 p.m
://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
/resources/alltypes.avsc PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David Chen
d639e9966687e0d885f93afbb3b7fb6568d50edc
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitioned.java
dc05f431d9a1f8dbc8362499a672c7816cc82526
ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java PRE-CREATION
Diff: https://reviews.apache.org/r/22946/diff/
Testing
---
Thanks,
David
-mail. To reply, visit:
https://reviews.apache.org/r/22946/#review48792
---
On July 25, 2014, 9:25 p.m., David Chen wrote:
---
This is an automatically generated e-mail. To reply
Diff: https://reviews.apache.org/r/24136/diff/
Testing
---
Thanks,
David Chen
/apache/hadoop/hive/ql/io/StorageFormats.java
19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
/StorageFormats.java
19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
---
Thanks,
David Chen
:
https://reviews.apache.org/r/23797/#review54061
---
On Sept. 18, 2014, 11:21 p.m., David Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
b93121d617673fa455df70f97eed67254425678c
Diff: https://reviews.apache.org/r/24136/diff/
Testing
---
Run unit tests.
Thanks,
David Chen
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099343#comment-14099343
]
David Chen commented on HIVE-4329:
--
Hi Sushanth,
Thank you for taking a look
[
https://issues.apache.org/jira/browse/HIVE-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7457:
-
Attachment: HIVE-7457.5.patch
Adding new patch rebased on trunk to run pre-commit tests again.
Minor
[
https://issues.apache.org/jira/browse/HIVE-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7457:
-
Status: Patch Available (was: Open)
Minor HCatalog Pig Adapter test clean up
[
https://issues.apache.org/jira/browse/HIVE-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101508#comment-14101508
]
David Chen commented on HIVE-7457:
--
Thanks for reviewing this, [~cwsteinbach]. I renamed
[
https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7420:
-
Attachment: HIVE-7420-without-HIVE-7457.4.patch
HIVE-7420.4.patch
Parameterize tests
[
https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7420:
-
Status: Patch Available (was: Open)
Parameterize tests for HCatalog Pig interfaces for testing against
[
https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14104484#comment-14104484
]
David Chen commented on HIVE-7420:
--
Thanks for your review, [~cwsteinbach]. I have
[
https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7420:
-
Attachment: HIVE-7420.5.patch
HIVE-7420-without-HIVE-7457.5.patch
Uploading new patch
David Chen created HIVE-7855:
Summary: Invalid partition values specified when writing to static
partitioned tables via HCatalog
Key: HIVE-7855
URL: https://issues.apache.org/jira/browse/HIVE-7855
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-4329:
-
Attachment: HIVE-4329.1.patch
HCatalog should use getHiveRecordWriter rather than getRecordWriter
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-4329:
-
Attachment: HIVE-4329.2.patch
HCatalog should use getHiveRecordWriter rather than getRecordWriter
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114530#comment-14114530
]
David Chen commented on HIVE-4329:
--
Hi Sushanth,
I really appreciate you taking your time
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-4329:
-
Attachment: HIVE-4329.3.patch
HCatalog should use getHiveRecordWriter rather than getRecordWriter
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119055#comment-14119055
]
David Chen commented on HIVE-4329:
--
Thank you for your feedback, Sushanth.
bq. One note
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955594#comment-13955594
]
David Chen commented on HIVE-4329:
--
I am running into this issue as well. If no one
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-4329 started by David Chen.
HCatalog clients can't write to AvroSerde backed tables
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-4329:
-
Summary: HCatalog should use getHiveRecordWriter rather than
getRecordWriter (was: HCatalog clients
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957201#comment-13957201
]
David Chen commented on HIVE-4329:
--
I think the correct fix for this is that HCatalog
David Chen created HIVE-7066:
Summary: hive-exec jar is missing avro-mapred
Key: HIVE-7066
URL: https://issues.apache.org/jira/browse/HIVE-7066
Project: Hive
Issue Type: Bug
Reporter
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-7066 started by David Chen.
hive-exec jar is missing avro-mapred
Key: HIVE-7066
URL
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998274#comment-13998274
]
David Chen commented on HIVE-7066:
--
I have posted a patch for a fix. I have tested
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-7066 started by David Chen.
hive-exec jar is missing avro-mapred
Key: HIVE-7066
URL
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7066:
-
Attachment: HIVE-7066.1.patch
hive-exec jar is missing avro-mapred
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998278#comment-13998278
]
David Chen commented on HIVE-7066:
--
RB: https://reviews.apache.org/r/21471
hive-exec jar
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-7066 stopped by David Chen.
hive-exec jar is missing avro-mapred
Key: HIVE-7066
URL
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7066:
-
Status: Patch Available (was: In Progress)
hive-exec jar is missing avro-mapred
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen reassigned HIVE-7066:
Assignee: David Chen
hive-exec jar is missing avro-mapred
David Chen created HIVE-7073:
Summary: Implement Binary in ParquetSerDe
Key: HIVE-7073
URL: https://issues.apache.org/jira/browse/HIVE-7073
Project: Hive
Issue Type: Bug
Reporter
[
https://issues.apache.org/jira/browse/HIVE-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999308#comment-13999308
]
David Chen commented on HIVE-4329:
--
If I understand correctly, it seems that this change
[
https://issues.apache.org/jira/browse/HIVE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen reassigned HIVE-7073:
Assignee: David Chen
Implement Binary in ParquetSerDe
[
https://issues.apache.org/jira/browse/HIVE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7073:
-
Issue Type: Sub-task (was: Bug)
Parent: HIVE-6384
Implement Binary in ParquetSerDe
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000456#comment-14000456
]
David Chen commented on HIVE-7066:
--
Hi Xuefu, I simply ran {{select count(1) from avro
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002601#comment-14002601
]
David Chen commented on HIVE-7066:
--
[~xuefuz], were you able to reproduce the problem? Do
David Chen created HIVE-7093:
Summary: Separate out static/dynamic partitioning code in HCatalog
as implementations
Key: HIVE-7093
URL: https://issues.apache.org/jira/browse/HIVE-7093
Project: Hive
[
https://issues.apache.org/jira/browse/HIVE-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7093:
-
Description:
From HCATALOG-504:
{quote}
Currently the whole code base has if (dynamicparitioning){} else
David Chen created HIVE-7094:
Summary: Separate out static/dynamic partitioning code in
FileRecordWriterContainer
Key: HIVE-7094
URL: https://issues.apache.org/jira/browse/HIVE-7094
Project: Hive
[
https://issues.apache.org/jira/browse/HIVE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated HIVE-7066:
-
Summary: hive-exec jar is missing avro core (was: hive-exec jar is missing
avro-mapred)
hive-exec jar
1 - 100 of 280 matches
Mail list logo
