Re: Review Request 12750: HIVE-3632: Upgrade datanucleus to support JDK7

2013-07-19 Thread Sergey Shelukhin
/#comment47454 this (and other stuff above and below) will require schema upgrade script as far as I see - Sergey Shelukhin On July 18, 2013, 11:27 p.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail. To reply

documentation issue for RLIKE/REGEXP

2013-08-08 Thread Sergey Shelukhin
Double checking before I try to edit. The page here: https://cwiki.apache.org/Hive/languagemanual-udf.html says: A RLIKE B if A or B is NULL, TRUE if any (possibly empty) substring of A matches the Java regular expression B, otherwise FALSE. E.g. 'foobar' RLIKE 'foo' evaluates to FALSE whereas

LIKE filter pushdown for tables and partitions

2013-08-21 Thread Sergey Shelukhin
Hi. I think there are issues with the way hive can currently do LIKE operator JDO pushdown and it the code should be removed for partitions and tables. Are there objections to removing LIKE from Filter.g and related areas? If no I will file a JIRA and do it. Details: There's code in metastore

Re: LIKE filter pushdown for tables and partitions

2013-08-26 Thread Sergey Shelukhin
Since there's no response I am assuming nobody cares about this code... Jira is HIVE-5134, I will attach a patch with removal this week. On Wed, Aug 21, 2013 at 2:28 PM, Sergey Shelukhin ser...@hortonworks.comwrote: Hi. I think there are issues with the way hive can currently do LIKE

Re: LIKE filter pushdown for tables and partitions

2013-08-26 Thread Sergey Shelukhin
to send an email to users@hive to ask if there are users for this. Thanks, Ashutosh On Mon, Aug 26, 2013 at 2:08 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Since there's no response I am assuming nobody cares about this code... Jira is HIVE-5134, I will attach a patch

Re: LIKE filter pushdown for tables and partitions

2013-08-27 Thread Sergey Shelukhin
use, getPartitionsByFilter, you're saying you want to remove the use case of using like clause on a partition column? if so, um, yeah, i would think that's surely used. On Mon, Aug 26, 2013 at 7:48 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Adding user list. Any objections

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

2013-09-16 Thread Sergey Shelukhin
/clientnegative/illegal_partition_type.q https://reviews.apache.org/r/14155/#comment51115 local path, also below in other q files - Sergey Shelukhin On Sept. 16, 2013, 9:05 p.m., Vikram Dixit Kumaraswamy wrote: --- This is an automatically

Re: Review Request 14428: Migrate expression serialization to Kryo

2013-10-02 Thread Sergey Shelukhin
/PartitionPruner.java https://reviews.apache.org/r/14428/#comment51854 this fn is recursive, I don't think this is valid... at least there's column desc. Same above with node - Sergey Shelukhin On Oct. 2, 2013, 1:07 p.m., Ashutosh Chauhan wrote

Re: Review Request 14428: Migrate expression serialization to Kryo

2013-10-02 Thread Sergey Shelukhin
/14428/#comment51858 should this be removed? - Sergey Shelukhin On Oct. 2, 2013, 1:07 p.m., Ashutosh Chauhan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14428

maven build of itests

2013-11-05 Thread Sergey Shelukhin
Hi. Is there reason why build of the q tests is separate from main build now in maven? (cd itests, etc.) They could be part of the same build. -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information

Re: maven build of itests

2013-11-05 Thread Sergey Shelukhin
. As a disconnected child as I have done I prefer #2 and as I did the mavenization that is what we ended up with. On Nov 5, 2013 6:08 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Hi. Is there reason why build of the q tests is separate from main build now in maven? (cd itests, etc

MR logs during .q file tests

2013-11-05 Thread Sergey Shelukhin
Hi. Is there any way to get MR logs during .q tests? Ideally, without changing code. MR logs by default don't go into hive.log, even though the logging from caller alleges that's where they are to be found. Previously, a workaround existed where you could force MR to local by changing code in

Review Request 15359: HIVE-5700 enforce single date format for partition column storage

2013-11-08 Thread Sergey Shelukhin
/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 46d1fac ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5305537 Diff: https://reviews.apache.org/r/15359/diff/ Testing --- tests; manual verification of mysql and psql scripts (Oracle tbd) Thanks, Sergey Shelukhin

Re: Review Request 15359: HIVE-5700 enforce single date format for partition column storage

2013-11-08 Thread Sergey Shelukhin
://reviews.apache.org/r/15359/diff/ Testing --- tests; manual verification of mysql and psql scripts (Oracle tbd) Thanks, Sergey Shelukhin

Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-11-26 Thread Sergey Shelukhin
/results/clientpositive/vectorization_div0.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1 Diff: https://reviews.apache.org/r/15869/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-11-26 Thread Sergey Shelukhin
/NullUtil.java https://reviews.apache.org/r/15869/#comment56702 disregard this part of the comment (and below) - Sergey Shelukhin On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-12-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15869/#review29493 --- On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-12-02 Thread Sergey Shelukhin
On Dec. 2, 2013, 10:55 p.m., Sergey Shelukhin wrote: I did not see the junit test. I also see trailing white space in template files still. Did you upload latest diff to ReviewBoard? not yet, working on q file - Sergey

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-12-02 Thread Sergey Shelukhin
-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938 Diff: https://reviews.apache.org/r/15869/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-12-03 Thread Sergey Shelukhin
/clientpositive/vectorization_div0.q PRE-CREATION ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938 Diff: https://reviews.apache.org/r/15869/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

2013-12-03 Thread Sergey Shelukhin
/clientpositive/vectorization_div0.q PRE-CREATION ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938 Diff: https://reviews.apache.org/r/15869/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 16074: HIVE-5951 improve performance of adding partitions from client

2013-12-05 Thread Sergey Shelukhin
/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44 ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26 ql/src/test/results/clientpositive/add_part_multiple.q.out b2525cf Diff: https://reviews.apache.org/r/16074/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16074: HIVE-5951 improve performance of adding partitions from client

2013-12-05 Thread Sergey Shelukhin
) --- running clidriver, some more query results will change Thanks, Sergey Shelukhin

Re: Review Request 16074: HIVE-5951 improve performance of adding partitions from client

2013-12-06 Thread Sergey Shelukhin
e90ffc7 ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f Diff: https://reviews.apache.org/r/16074/diff/ Testing --- running clidriver, some more query results will change Thanks, Sergey Shelukhin

Re: Review Request 16074: HIVE-5951 improve performance of adding partitions from client

2013-12-06 Thread Sergey Shelukhin
, some more query results will change Thanks, Sergey Shelukhin

Re: Review Request 16074: HIVE-5951 improve performance of adding partitions from client

2013-12-09 Thread Sergey Shelukhin
, some more query results will change Thanks, Sergey Shelukhin

Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL

2013-12-10 Thread Sergey Shelukhin
ql/src/test/results/clientpositive/partition_date.q.out 3462a1b Diff: https://reviews.apache.org/r/16171/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL

2013-12-11 Thread Sergey Shelukhin
/queries/clientpositive/partition_date.q 3c031db ql/src/test/results/clientpositive/partition_date.q.out 3462a1b Diff: https://reviews.apache.org/r/16171/diff/ Testing --- Thanks, Sergey Shelukhin

adding ANSI flag for hive

2013-12-11 Thread Sergey Shelukhin
Hi. There's recently been some discussion about data type changes in Hive (double to decimal), and result changes for special cases like division by zero, etc., to bring it in compliance with MySQL (that's what JIRAs use an example; I am assuming ANSI SQL is meant). The latter are

Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-12 Thread Sergey Shelukhin
/TestCompareCliDriver.vm PRE-CREATION Diff: https://reviews.apache.org/r/16229/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-12 Thread Sergey Shelukhin
PRE-CREATION ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION Diff: https://reviews.apache.org/r/16229/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-13 Thread Sergey Shelukhin
/TestCompareCliDriver.vm PRE-CREATION Diff: https://reviews.apache.org/r/16229/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 16269: HIVE-6034 vectorized % doesn't handle zeroes the same way as non-vectorized

2013-12-13 Thread Sergey Shelukhin
.q.out 247197a Diff: https://reviews.apache.org/r/16269/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16269: HIVE-6034 vectorized % doesn't handle zeroes the same way as non-vectorized

2013-12-16 Thread Sergey Shelukhin
/test/results/clientpositive/vectorization_14.q.out 247197a Diff: https://reviews.apache.org/r/16269/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-16 Thread Sergey Shelukhin
think it should be written elsewhere? ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv https://reviews.apache.org/r/16229/#comment58355 this will muddy the naming convention for versions and potentially cause ambiguity; discussed the details in person - Sergey Shelukhin

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-16 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16229/#review30464 --- On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-17 Thread Sergey Shelukhin
/TestCompareCliDriver.vm PRE-CREATION Diff: https://reviews.apache.org/r/16229/diff/ Testing --- Thanks, Sergey Shelukhin

Re: adding ANSI flag for hive

2013-12-17 Thread Sergey Shelukhin
the defaults for some of the configs to more desirable values, but non backward compatible values. On Wed, Dec 11, 2013 at 4:33 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Hi. There's recently been some discussion about data type changes in Hive (double to decimal), and result

Review Request 16339: HIVE-6052 metastore JDO filter pushdown for integers may produce unexpected results with non-normalized integer columns

2013-12-17 Thread Sergey Shelukhin
/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942 Diff: https://reviews.apache.org/r/16339/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java 29d895a ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 44cb9c0 Diff: https://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
/ReduceSinkMapJoinProc.java https://reviews.apache.org/r/24427/#comment87176 this is wrong - Sergey Shelukhin On Aug. 6, 2014, 9:26 p.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
/HashMapWrapper.java https://reviews.apache.org/r/24427/#comment87177 should also divide by HIVEHASHTABLELOADFACTOR here and in another place - Sergey Shelukhin On Aug. 6, 2014, 9:26 p.m., Sergey Shelukhin wrote: --- This is an automatically

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
/HashTableLoader.java 6d292d0 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java 29d895a ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 44cb9c0 Diff: https://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review requests JIRA process

2014-08-07 Thread Sergey Shelukhin
I think the process that works best for getting patches reviewed is adding specific people to RB/JIRA and asking, usually the people who are active in a related area of code. And nagging them until they either review or refuse to review :) On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
/#review49830 --- On Aug. 6, 2014, 10 p.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
/HashTableLoader.java 6d292d0 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java 29d895a ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 44cb9c0 Diff: https://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Sergey Shelukhin
884c106 ql/src/test/results/clientpositive/union_ppr.q.out ee209c7 Diff: https://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Sergey Shelukhin
/mapjoin_mapjoin.q 3f36851 ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 567b0ca ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out 9e90ec2 Diff: https://reviews.apache.org/r/24427/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 24587: HIVE-7617 optimize bytes mapjoin hash table read path wrt serialization, at least for common cases

2014-08-11 Thread Sergey Shelukhin
/binarysortable/BinarySortableSerDe.java 523ad7d Diff: https://reviews.apache.org/r/24587/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24587: HIVE-7617 optimize bytes mapjoin hash table read path wrt serialization, at least for common cases

2014-08-11 Thread Sergey Shelukhin
://reviews.apache.org/r/24587/#comment87967 bad comment ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java https://reviews.apache.org/r/24587/#comment87968 make private - Sergey Shelukhin On Aug. 12, 2014, 2:07 a.m., Sergey Shelukhin wrote

Re: Review Request 24587: HIVE-7617 optimize bytes mapjoin hash table read path wrt serialization, at least for common cases

2014-08-12 Thread Sergey Shelukhin
/BinarySortableSerDe.java 523ad7d Diff: https://reviews.apache.org/r/24587/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 24617: HIVE-7696 small changes to mapjoin hashtable

2014-08-12 Thread Sergey Shelukhin
/org/apache/hadoop/hive/serde2/WriteBuffers.java bed4d0a Diff: https://reviews.apache.org/r/24617/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24498: A method to extrapolate the missing column status for the partitions.

2014-08-12 Thread Sergey Shelukhin
/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/24498/#comment88167 I wonder if so much logic belongs to DirectSQL class; it is growing pretty big. Maybe it can be moved out - Sergey Shelukhin On Aug. 12, 2014, 5:57 p.m., pengcheng xiong wrote

Re: Review Request 24587: HIVE-7617 optimize bytes mapjoin hash table read path wrt serialization, at least for common cases

2014-08-13 Thread Sergey Shelukhin
/WriteBuffers.java bed4d0a serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d Diff: https://reviews.apache.org/r/24587/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 24587: HIVE-7617 optimize bytes mapjoin hash table read path wrt serialization, at least for common cases

2014-08-14 Thread Sergey Shelukhin
/serde2/ByteStream.java 390d9de serde/src/java/org/apache/hadoop/hive/serde2/WriteBuffers.java bed4d0a serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d Diff: https://reviews.apache.org/r/24587/diff/ Testing --- Thanks, Sergey Shelukhin

HiveQA fails due to some spark qfiles issue

2014-08-15 Thread Sergey Shelukhin
For several of my patches, HiveQA failed with: Tests exited with: IllegalArgumentException: No propertifies found in file: mainProperties for property: spark.query.files I tried for some time to find a commit to blame, but couldn't find one :) -- CONFIDENTIALITY NOTICE NOTICE: This message is

Re: Review Request 24498: A method to extrapolate the missing column status for the partitions.

2014-08-18 Thread Sergey Shelukhin
On Aug. 13, 2014, 1:10 a.m., Sergey Shelukhin wrote: metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 1101 https://reviews.apache.org/r/24498/diff/2/?file=658642#file658642line1101 please quote the identifier names (won't work on pgsql otherwise

getting development branch for HIVE-7926

2014-09-04 Thread Sergey Shelukhin
Hi. Is it possible to get llap development branch for HIVE-7926 JIRA? -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under

Re: Patches to release branches

2014-09-09 Thread Sergey Shelukhin
From my experience in HBase, I can say that bug fix (or dot, e.g. 0.96.1) releases are a common practice and work very well for users. The release manager of the corresponding major release vets the backports and makes bugfix releases on some cadence (i.e. monthly), without much of the usual major

Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

2014-09-11 Thread Sergey Shelukhin
/SemanticAnalyzer.java e4a30a2 ql/src/test/queries/clientpositive/insert0.q PRE-CREATION ql/src/test/results/clientpositive/insert0.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25550/diff/ Testing --- Thanks, Sergey Shelukhin

moving Hive to git

2014-09-12 Thread Sergey Shelukhin
Hi. Many Apache projects are moving to git from svn; HBase moved recently, and as far as I have heard Hadoop has moved too. Are there any objections to moving Hive to use git too? I wanted to start a preliminary discussion. -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use

Re: Review Request 17302: HIVE-6012: restore backward compatibility of arithmetic operations

2014-03-05 Thread Sergey Shelukhin
/GenericUDFBaseNumeric.java https://reviews.apache.org/r/17302/#comment67251 what would this be for two decimals? - Sergey Shelukhin On Feb. 7, 2014, 12:13 a.m., Jason Dere wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Thoughts on new metastore APIs

2014-03-05 Thread Sergey Shelukhin
+1. It would be nice to deprecate some classic APIs superseded by req/resp APIs too On Wed, Mar 5, 2014 at 3:05 PM, Prasad Mujumdar pras...@cloudera.comwrote: +1 @Brock, Thanks for bring this up. thanks Prasad On Wed, Mar 5, 2014 at 11:39 AM, Brock Noland br...@cloudera.com wrote:

Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-07 Thread Sergey Shelukhin
Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Proposal to switch to pull requests

2014-03-07 Thread Sergey Shelukhin
+1 to git! On Fri, Mar 7, 2014 at 12:46 PM, Xuefu Zhang xzh...@cloudera.com wrote: Switching to git from svn seems to be a proposal slightly different from that of switching to pull request from the head of the thread. Personally I'm +1 to git, but I think patches are very portable and

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-11 Thread Sergey Shelukhin
generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review36680 --- On March 8, 2014, 12:31 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-11 Thread Sergey Shelukhin
/serde2/io/TimestampWritable.java 435d6c6 serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java b188c3f serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 6c14081 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-13 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review36939 --- On March 12, 2014, 2:30 a.m., Sergey Shelukhin wrote

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
/LazyBinarySerDe.java b188c3f serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 6c14081 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
/LazyBinarySerDe.java b188c3f serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 6c14081 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
/HashTableLoader.java https://reviews.apache.org/r/18936/#comment68767 retained from testing, will remove ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java https://reviews.apache.org/r/18936/#comment68768 retained from testing, will remove - Sergey Shelukhin On March 15, 2014, 1:22

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 868dd4c serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 1fb49e5 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-17 Thread Sergey Shelukhin
://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 19219: Vectorization: Partition column names are not picked up.

2014-03-17 Thread Sergey Shelukhin
nit: variable is not needed ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java https://reviews.apache.org/r/19219/#comment69030 maybe there should be a hashset of names - Sergey Shelukhin On March 14, 2014, 9:23 a.m., Jitendra Pandey wrote

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-18 Thread Sergey Shelukhin
/TestLazyPrimitive.java 868dd4c serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 1fb49e5 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-18 Thread Sergey Shelukhin
/HashTableLoader.java https://reviews.apache.org/r/18936/#comment69316 should have been changed, will do - Sergey Shelukhin On March 19, 2014, 2:40 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

2014-03-20 Thread Sergey Shelukhin
. Repository: hive-git Description --- See JIRA Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e20d8bf ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3262ae3 Diff: https://reviews.apache.org/r/19475/diff/ Testing --- Thanks, Sergey

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-20 Thread Sergey Shelukhin
/TestLazyPrimitive.java 868dd4c serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 1fb49e5 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 19552: HIVE-6701 Analyze table compute statistics for decimal columns.

2014-03-21 Thread Sergey Shelukhin
/src/test/queries/clientpositive/compute_stats_decimal.q PRE-CREATION ql/src/test/results/clientpositive/compute_stats_decimal.q.out PRE-CREATION Diff: https://reviews.apache.org/r/19552/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

2014-03-25 Thread Sergey Shelukhin
://reviews.apache.org/r/19475/#comment70664 why remove? when there's less urgency before release someone can address it - Sergey Shelukhin On March 20, 2014, 4:57 p.m., Sergey Shelukhin wrote: --- This is an automatically generated

Re: Review Request 19475: HIVE-6703 Tez should store SHA of the jar when uploading to cache

2014-03-25 Thread Sergey Shelukhin
/19475/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 19789: HIVE-6739 Hive HBase query fails on Tez due to missing jars and then due to NPE in getSplits

2014-03-28 Thread Sergey Shelukhin
/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java 5ad4250 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 859b5ad Diff: https://reviews.apache.org/r/19789/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 19903: Support bulk deleting directories for partition drop with partial spec

2014-04-02 Thread Sergey Shelukhin
://reviews.apache.org/r/19903/#comment71713 should these two explains have different names? ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java https://reviews.apache.org/r/19903/#comment71714 why is this needed? I don't see it used anywhere - Sergey Shelukhin On April 2

Re: Review Request 19789: HIVE-6739 Hive HBase query fails on Tez due to missing jars and then due to NPE in getSplits

2014-04-02 Thread Sergey Shelukhin
/TestTezSessionPool.java d2c332c ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java 5ad4250 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 4810fd0 Diff: https://reviews.apache.org/r/19789/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 19789: HIVE-6739 Hive HBase query fails on Tez due to missing jars and then due to NPE in getSplits

2014-04-04 Thread Sergey Shelukhin
/TestTezSessionPool.java d2c332c ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java 5ad4250 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 4810fd0 Diff: https://reviews.apache.org/r/19789/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 20110: HIVE-6825 custom jars for Hive query should be uploaded to scratch dir per query; and/or versioned

2014-04-07 Thread Sergey Shelukhin
/r/20110/diff/ Testing --- Thanks, Sergey Shelukhin

Re: [ANNOUNCE] New Hive Committers - Alan Gates, Daniel Dai, and Sushanth Sowmyan

2014-04-14 Thread Sergey Shelukhin
Congrats! On Mon, Apr 14, 2014 at 10:55 AM, Prasanth Jayachandran pjayachand...@hortonworks.com wrote: Congratulations everyone!! Thanks Prasanth Jayachandran On Apr 14, 2014, at 10:51 AM, Carl Steinbach c...@apache.org wrote: The Apache Hive PMC has voted to make Alan Gates, Daniel

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-16 Thread Sergey Shelukhin
/PrimitiveObjectInspectorConverter.java 06d5c5e serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 868dd4c serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 1fb49e5 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-17 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

datanucleus identity factory and sql scripts

2014-04-18 Thread Sergey Shelukhin
Hi. I've noticed that Hive, and all the sql scripts, rely on datanucleus1 DN identity factory (see http://www.datanucleus.org/products/datanucleus/jdo/orm/datastore_identifiers.html) rather than the newer ...2 one. Is there a reason for this other than backward compat? -- CONFIDENTIALITY NOTICE

Review Request 20565: HIVE-6945 issues with dropping partitions on Oracle

2014-04-22 Thread Sergey Shelukhin
: https://reviews.apache.org/r/20565/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 20565: HIVE-6945 issues with dropping partitions on Oracle

2014-04-22 Thread Sergey Shelukhin
/hadoop/hive/metastore/Warehouse.java fe15101 Diff: https://reviews.apache.org/r/20565/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 20565: HIVE-6945 issues with dropping partitions on Oracle

2014-04-22 Thread Sergey Shelukhin
/hadoop/hive/metastore/Warehouse.java fe15101 Diff: https://reviews.apache.org/r/20565/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Apache Hive 0.13.1

2014-04-25 Thread Sergey Shelukhin
I don't have access to edit this page (or cannot figure out the UI). Username sershe. Can you add HIVE-6961 : Drop partitions treats partition columns as strings (area - metastore) On Fri, Apr 25, 2014 at 4:20 PM, Sushanth Sowmyan khorg...@gmail.comwrote: I've created the following wiki link :

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-29 Thread Sergey Shelukhin
Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
--- On April 30, 2014, 2:03 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 30, 2014, 2

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
/thrift_test/CreateSequenceFile.java 1fb49e5 Diff: https://reviews.apache.org/r/18936/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
/#comment75550 dup, will remove - Sergey Shelukhin On April 30, 2014, 11:14 p.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936

  1   2   3   4   5   6   7   8   9   10   >