Re: Review Request 43921: HIVE-13120 propagate doAs when generating ORC splits

2016-02-23 Thread Sergey Shelukhin
(line 545) <https://reviews.apache.org/r/43921/#comment181851> not needed - Sergey Shelukhin On Feb. 24, 2016, 12:12 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 43921: HIVE-13120 propagate doAs when generating ORC splits

2016-02-23 Thread Sergey Shelukhin
--- see jira Diffs - ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 9b1d7ae Diff: https://reviews.apache.org/r/43921/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-25 Thread Sergey Shelukhin
/TestOrcSplitElimination.java 7a93b54 storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java dc71db4 storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java be5e67b Diff: https://reviews.apache.org/r/40415/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-26 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Review Request 44128: HIVE-13002 Hive object is not thread safe, is shared via a threadlocal and thus should not be passed around too much - part 1

2016-02-26 Thread Sergey Shelukhin
, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-26 Thread Sergey Shelukhin
---- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40415/#review119116 --- On Feb. 26, 2016, 5:04 a.m., Sergey Shelukhin wrote: > > --

Re: Review Request 42482: HIVE-12855 LLAP UDF whitelist check

2016-01-19 Thread Sergey Shelukhin
/GenericUDFBridge.java 6098ddd Diff: https://reviews.apache.org/r/42482/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 42482: HIVE-12855 LLAP UDF whitelist check

2016-01-25 Thread Sergey Shelukhin
src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5353062 > ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java > 0e6e2de > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java > 6098ddd > > Diff: https://reviews.apache.org/r/42482/diff/ > > > Testing > --- > > > Thanks, > > Sergey Shelukhin > >

HiveQA machines are low on disk space

2016-01-25 Thread Sergey Shelukhin
Hi. Recently, there has occasionally been a stuck mini cluster test, usually MiniTez, I think I’ve seen MiniSpark too. Upon looking at the logs for one recent timeout, I don’t see any obvious problem with Hive, but there’s this: 2016-01-25T09:23:15,658 WARN

Re: Review Request 42482: HIVE-12855 LLAP UDF whitelist check

2016-01-25 Thread Sergey Shelukhin
/GenericUDFBridge.java 6098ddd Diff: https://reviews.apache.org/r/42482/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Need your opinion on HIVE-12916 to clean up metastore API

2016-01-25 Thread Sergey Shelukhin
There are 2 separate issues. 1) Removing old APIs. There’s (almost) no impact from keeping the old function for compat if both old and new call the same internal method with slight argument variations, but there would be compact problems with removing them if someone is using it; metastore is

Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a single thread

2016-01-20 Thread Sergey Shelukhin
/TezSessionPoolManager.java 3bfe35a ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1 Diff: https://reviews.apache.org/r/41377/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 42482: HIVE-12855 LLAP UDF whitelist check

2016-01-26 Thread Sergey Shelukhin
/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java 6098ddd Diff: https://reviews.apache.org/r/42482/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 43541: HIVE-12856 LLAP: update (add/remove) the UDFs available in LLAP when they are changed (refresh periodically)

2016-02-12 Thread Sergey Shelukhin
/if/hive_metastore.thrift 1abcfe5 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 98fbf70 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f51e1a4 Diff: https://reviews.apache.org/r/43541/diff/ Testing --- Thanks, Sergey Shelukhin

[ANNOUNCE] Apache Hive 2.0.0 Released

2016-02-16 Thread Sergey Shelukhin
The Apache Hive team is proud to announce the the release of Apache Hive version 2.0.0. The Apache Hive (TM) data warehouse software facilitates querying and managing large datasets residing in distributed storage. Built on top of Apache Hadoop (TM), it provides: * Tools to enable easy data

branch-2.0 usage past 2.0 release, and release plans

2016-02-16 Thread Sergey Shelukhin
Hi. Hive 2.0 having been released, branch-2.0 is now open, but should only include commits for a hypothetical Hive 2.0.1 bug fix release. As far as I understand, I will be the RM for all such dot-dot releases for 2.0. Time-wise, 2.0.1 will be released based on the number and impact of the bugs

Spark and HBase metastore jiras in 2.0 release

2016-02-16 Thread Sergey Shelukhin
Hi. There is a number of JIRAs resolved in a variety of branches that are a part of 2.0 release. We need to close these; I’ll take care of closing the llap JIRAs; as far as hbase-metastore-branch and spark-branch are concerned, any objection to closing these? None of them look new. I will close

Re: Review Request 43541: HIVE-12856 LLAP: update (add/remove) the UDFs available in LLAP when they are changed (refresh periodically)

2016-02-16 Thread Sergey Shelukhin
/HBaseReadWrite.java 61257f0 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f51e1a4 Diff: https://reviews.apache.org/r/43541/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Spark and HBase metastore jiras in 2.0 release

2016-02-17 Thread Sergey Shelukhin
uld update the fix version whenever we merge the branch into >> master/branch-1 . >> >> >> >> On Tue, Feb 16, 2016 at 5:31 PM, Sergey Shelukhin >> <ser...@hortonworks.com> wrote: >> > Hi. >> > There is a number of JIRAs resolved in a variety o

Review Request 45062: HIVE-13241 LLAP: Incremental Caching marks some small chunks as "incomplete CB"

2016-03-18 Thread Sergey Shelukhin
/hadoop/hive/common/io/encoded/EncodedColumnBatch.java ddba889 Diff: https://reviews.apache.org/r/45062/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 44491: HIVE-13221 expose metastore APIs from HS2

2016-03-09 Thread Sergey Shelukhin
/hive/service/server/HiveServer2.java 892a476 Diff: https://reviews.apache.org/r/44491/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-08 Thread Sergey Shelukhin
/SearchArgumentImpl.java be5e67b Diff: https://reviews.apache.org/r/40415/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 44248: HIVE-12995 LLAP: Synthetic file ids need collision checks

2016-03-08 Thread Sergey Shelukhin
/common/io/encoded/EncodedColumnBatch.java 3ef7abe Diff: https://reviews.apache.org/r/44248/diff/ Testing --- Thanks, Sergey Shelukhin

Re: [ANNOUNCE] New Hive Committer - Wei Zheng

2016-03-09 Thread Sergey Shelukhin
Congrats! From: Szehon Ho > Reply-To: "u...@hive.apache.org" > Date: Wednesday, March 9, 2016 at 17:40 To: "u...@hive.apache.org"

Review Request 44491: HIVE-13221 expose metastore APIs from HS2

2016-03-07 Thread Sergey Shelukhin
Diff: https://reviews.apache.org/r/44491/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-07 Thread Sergey Shelukhin
/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-07 Thread Sergey Shelukhin
/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45704: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-05 Thread Sergey Shelukhin
(line 73) <https://reviews.apache.org/r/45704/#comment190023> unnecessary orc/src/java/org/apache/orc/impl/OutStream.java (line 323) <https://reviews.apache.org/r/45704/#comment190024> unnecessary - Sergey Shelukhin On April 4, 2016, 9:18 p.m., Sergey She

Re: [DISCUSS] Hive 2.0.1 bug fix release

2016-04-05 Thread Sergey Shelukhin
; > -- Lefty >> > >> > On Thu, Mar 31, 2016 at 4:55 PM, Thejas Nair <thejas.n...@gmail.com> >> wrote: >> > >> >> +1 >> >> >> >> On Thu, Mar 31, 2016 at 1:20 PM, Sergey Shelukhin >> >> <ser...@hortonworks.com> w

recent metastore failures in HiveQA

2016-04-06 Thread Sergey Shelukhin
Has anyone else noticed that many tests that involve metastore started failing lately? The failures are sporadic and happen both in the tests that test metastore, and q files that use metastore… The error is always something like java.net.ConnectException: Connection refused at

Re: Review Request 45704: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-05 Thread Sergey Shelukhin
://reviews.apache.org/r/45704/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-06 Thread Sergey Shelukhin
? see estimateRgEndOffset calls. It calls the fn right now to log the message, but uses lengths if available. I can remove it when the patch is done... or only do it if info is enabled - Sergey --- This is an automatically generated e-m

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-06 Thread Sergey Shelukhin
://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Sergey Shelukhin
2 days may be too short… One can submit all the patches on Friday night and commit on Sunday ;) On 16/4/11, 17:43, "Prasanth Jayachandran" wrote: >Also, it will be good to add “NO PRECOMMIT TESTS” in the description of >the jira >if the patches are really small

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-08 Thread Sergey Shelukhin
/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-07 Thread Sergey Shelukhin
/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-11 Thread Sergey Shelukhin
ql/src/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 46048: HIVE-13194 remove sessionHive

2016-04-11 Thread Sergey Shelukhin
/HiveSessionImplwithUGI.java 025b0b8 Diff: https://reviews.apache.org/r/46048/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46048: HIVE-13194 remove sessionHive

2016-04-11 Thread Sergey Shelukhin
/SQLOperation.java 9ce6055 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844 Diff: https://reviews.apache.org/r/46048/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-03-19 Thread Sergey Shelukhin
doesn't work for some reason, what about creating a small struct class to hold the fields with logical names and types, instead of the map. - Sergey Shelukhin On March 16, 2016, 8:51 a.m., Takanobu Asanuma wrote: > > --- > Thi

Re: Review Request 45062: HIVE-13241 LLAP: Incremental Caching marks some small chunks as "incomplete CB"

2016-03-22 Thread Sergey Shelukhin
> On March 22, 2016, 5:09 a.m., Gopal V wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java, > > line 844 > > <https://reviews.apache.org/r/45062/diff/1/?file=1307057#file1307057line844> > > > > is Data ev

Re: Review Request 45062: HIVE-13241 LLAP: Incremental Caching marks some small chunks as "incomplete CB"

2016-03-22 Thread Sergey Shelukhin
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/45062/#review124732 ------- On March 18, 2016, 11:18 p.m., Sergey Shelukhin wrote: > > --- > This is an

Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-03-23 Thread Sergey Shelukhin
/hive/common/io/encoded/EncodedColumnBatch.java ddba889 Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 44248: HIVE-12995 LLAP: Synthetic file ids need collision checks

2016-03-03 Thread Sergey Shelukhin
://reviews.apache.org/r/44248/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 44248: HIVE-12995 LLAP: Synthetic file ids need collision checks

2016-03-01 Thread Sergey Shelukhin
/EncodedColumnBatch.java 3ef7abe Diff: https://reviews.apache.org/r/44248/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-01 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin
or pay a small perf penalty - Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40415/#review122261 --- On March 2, 2016, 2:30 a.m., Sergey Shelukhin wrote: > > -

[DISCUSS] Hive 2.0.1 bug fix release

2016-03-31 Thread Sergey Shelukhin
There have been a few bug fixes since 2.0, some more might be in the pipeline. I think it’s a good time to release 2.0.1. I will go thru the log diff between master and branch-2 and see if anything needs to be backported, people can also mark JIRAs as 2.0.1-targeted. Depending on how many of the

Review Request 45704: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-04 Thread Sergey Shelukhin
/vectorized_ptf.q.out 3d1f22f ql/src/test/results/clientpositive/union_fast_stats.q.out f0879af ql/src/test/results/clientpositive/vectorized_ptf.q.out 3b17591 Diff: https://reviews.apache.org/r/45704/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-22 Thread Sergey Shelukhin
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3ea5ef9 Diff: https://reviews.apache.org/r/46597/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-04-22 Thread Sergey Shelukhin
/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-22 Thread Sergey Shelukhin
, Sergey Shelukhin

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-04-22 Thread Sergey Shelukhin
is > restricted to HS2. changed to have both options - Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130230 ---------

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-25 Thread Sergey Shelukhin
- Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review130369 --- On April 23, 2016, 2:08 a.m., Sergey

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-25 Thread Sergey Shelukhin
/TezSessionState.java 3ea5ef9 Diff: https://reviews.apache.org/r/46597/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-26 Thread Sergey Shelukhin
/ Testing --- Thanks, Sergey Shelukhin

Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

2016-04-26 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

please withhold commits to Hive branch-2.0

2016-04-27 Thread Sergey Shelukhin
I’ve just cut the RC0 for Hive 2.0.1 release. Please withhold commits to Hive branch-2.0 until the release is completed, or the RC is sank.

[VOTE] Apache Hive 2.0.1 Release Candidate 0

2016-04-27 Thread Sergey Shelukhin
Apache Hive 2.0.1 Release Candidate 0 is available here: http://home.apache.org/~sershe/hive-2.0.1-rc0/ Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-1048/ Source tag for RC0 (github mirror) is:

Re: [VOTE] Apache Hive 2.0.1 Release Candidate 0

2016-04-27 Thread Sergey Shelukhin
RC is invalid. I will publish RC1 in due course... On 16/4/27, 15:05, "Sergey Shelukhin" <ser...@hortonworks.com> wrote: >Apache Hive 2.0.1 Release Candidate 0 is available here: > >http://home.apache.org/~sershe/hive-2.0.1-rc0/ > > >Maven arti

Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-04-27 Thread Sergey Shelukhin
/MapRecordProcessor.java 0584ad8 Diff: https://reviews.apache.org/r/46754/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-04-27 Thread Sergey Shelukhin
/MapRecordProcessor.java (line 61) <https://reviews.apache.org/r/46754/#comment194768> unneeded - Sergey Shelukhin On April 27, 2016, 11:01 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

2016-04-27 Thread Sergey Shelukhin
: https://reviews.apache.org/r/46715/diff/ Testing --- Thanks, Sergey Shelukhin

new HiveQA jenkins queue doesn't have JIRA numbers

2016-04-28 Thread Sergey Shelukhin
Subj. Is it a limitation of the new Jenkins instance, or can it be enabled again? The JIRA number associated with the run used to be shown for the pending items in the left column.

Review Request 46809: HIVE-13442 LLAP: refactor submit API to be amenable to signing

2016-04-28 Thread Sergey Shelukhin
/ Testing --- Thanks, Sergey Shelukhin

Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-04-22 Thread Sergey Shelukhin
/LlapProtocolServerImpl.java e99e689 llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java 76ba225 llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java 8c7a539 Diff: https://reviews.apache.org/r/46579/diff/ Testing --- Thanks, Sergey

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-22 Thread Sergey Shelukhin
703line911> > > > > Should we iterate only if isTrackingLengths is true? Yes, because the trackers can also be used for the dictionary. Added a comment. - Sergey --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-04-21 Thread Sergey Shelukhin
ail on error jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 581) <https://reviews.apache.org/r/40867/#comment193629> nit: null check, there could be an error before stream is created - Sergey Shelukhin On April 15, 2016, 11:38 a.m., Taka

Re: Review Request 45238: HIVE-9660 store end offset of compressed data for RG in RowIndex in ORC

2016-04-22 Thread Sergey Shelukhin
Diff: https://reviews.apache.org/r/45238/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-19 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-23 Thread Sergey Shelukhin
d e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review134076 ------- On May 21, 2016, 12:07 a.m., Sergey Shelukhin wrote: > > --- > This is an a

Review Request 47735: HIVE-13617 LLAP: support non-vectorized execution in IO

2016-05-23 Thread Sergey Shelukhin
/clientpositive/orc_llap_nonvector.q.out PRE-CREATION Diff: https://reviews.apache.org/r/47735/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-23 Thread Sergey Shelukhin
verywhere. > > Assuming the appId is what will be used to differentiate different > > external clients ? and that in case of Tez - there's no differentiation. > > Sergey Shelukhin wrote: > This is the calling user in case of RPC. > > Siddharth Seth wrote: > This goes b

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-23 Thread Sergey Shelukhin
/TestFirstInFirstOutComparator.java a250882 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java c9b912b Diff: https://reviews.apache.org/r/46956/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-23 Thread Sergey Shelukhin
verywhere. > > Assuming the appId is what will be used to differentiate different > > external clients ? and that in case of Tez - there's no differentiation. > > Sergey Shelukhin wrote: > This is the calling user in case of RPC. > > Siddharth Seth wrote: > This goes b

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-18 Thread Sergey Shelukhin
/comparator/TestFirstInFirstOutComparator.java a250882 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java c9b912b Diff: https://reviews.apache.org/r/46956/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 47546: HIVE-13448 LLAP: check ZK acls for ZKSM and fail if they are too permissive

2016-05-18 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 47563: HIVE-13675 LLAP: add HMAC signatures to LLAPIF splits

2016-05-18 Thread Sergey Shelukhin
: https://reviews.apache.org/r/47563/diff/ Testing --- Thanks, Sergey Shelukhin

Review Request 47563: HIVE-13675 LLAP: add HMAC signatures to LLAPIF splits

2016-05-18 Thread Sergey Shelukhin
/HiveServer2.java d61edf5 Diff: https://reviews.apache.org/r/47563/diff/ Testing --- Thanks, Sergey Shelukhin

Re: [VOTE] Apache Hive 2.0.1 Release Candidate 1

2016-05-24 Thread Sergey Shelukhin
ote: >> > +1. Checked the keys and signatures, did a full build with a clean >> repo, checked for the presence of any binary files, checked the NOTICE >>and >> LICENSE files. >> > >> > Alan. >> > >> >> On May 3, 2016, at 21:25, Sergey She

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-20 Thread Sergey Shelukhin
--- Thanks, Sergey Shelukhin

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-20 Thread Sergey Shelukhin
ger. > > > > The one created earlier to generate tokens should be passed in. > > > > The KeySigner could be an interface instead, and SecretManager (extends > > ZKDelegationTokenSecretManager) can implement this. ACL checks etc are > > already

Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-20 Thread Sergey Shelukhin
To reply, visit: https://reviews.apache.org/r/46956/#review134076 ------- On May 18, 2016, 8:36 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-05-17 Thread Sergey Shelukhin
/security/LlapSecurityHelper.java f958bc4 llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java c54e726 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a Diff: https://reviews.apache.org/r/46579/diff/ Testing --- Thanks, Sergey

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-05-17 Thread Sergey Shelukhin
ated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133639 ------- On May 17, 2016, 9:58 p.m., Sergey Shelukhin wrote: > > --- > This is a

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-05-16 Thread Sergey Shelukhin
/llap/security/LlapSecurityHelper.java f958bc4 llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java c54e726 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a Diff: https://reviews.apache.org/r/46579/diff/ Testing --- Thanks, Sergey

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-05-16 Thread Sergey Shelukhin
sn't really matter if a new > > factory is created each time. > > > > Looks like not sharing the SecretManager could be expensive given the > > KDC login each time ? followed up in HIVE-13698 - Sergey ------

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-03 Thread Sergey Shelukhin
il. To reply, visit: https://reviews.apache.org/r/46754/#review131507 ------- On May 2, 2016, 9:44 p.m., Sergey Shelukhin wrote: > > --- > This is an automat

[VOTE] Apache Hive 2.0.1 Release Candidate 1

2016-05-03 Thread Sergey Shelukhin
Apache Hive 2.0.1 Release Candidate 1 is available here: http://home.apache.org/~sershe/hive-2.0.1-rc1/ Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-1049/ Source tag for RC1 (github mirror) is:

Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side

2016-05-03 Thread Sergey Shelukhin
-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapTokenChecker.java 762 llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java a250882 Diff: https://reviews.apache.org/r/46956/diff/ Testing --- Thanks, Sergey

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

2016-05-05 Thread Sergey Shelukhin
/security/LlapSecurityHelper.java f958bc4 llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java c54e726 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a Diff: https://reviews.apache.org/r/46579/diff/ Testing --- Thanks, Sergey

Re: new HiveQA jenkins queue doesn't have JIRA numbers

2016-05-02 Thread Sergey Shelukhin
t;On Thu, Apr 28, 2016 at 11:20 AM, Sergey Shelukhin ><ser...@hortonworks.com> wrote: >> Subj. Is it a limitation of the new Jenkins instance, or can it be >>enabled >> again? The JIRA number associated with the run used to be shown for the >> pending items in the left column. >> >

Re: Review Request 46809: HIVE-13442 LLAP: refactor submit API to be amenable to signing

2016-05-02 Thread Sergey Shelukhin
Diff: https://reviews.apache.org/r/46809/diff/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
ted e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review131247 ------- On April 27, 2016, 11:01 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
, Sergey Shelukhin

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-05-02 Thread Sergey Shelukhin
/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
<https://reviews.apache.org/r/46754/#comment195333> bogus - Sergey Shelukhin On May 2, 2016, 9:44 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-03 Thread Sergey Shelukhin
, Sergey Shelukhin

<    2   3   4   5   6   7   8   9   10   11   >