://reviews.apache.org/r/2001/#review4912
---
On 2012-01-29 17:56:48, Yin Huai wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2012-02-10 20:49:01.177796)
Review request for hive.
Changes
---
Congrats Brock!
On Tue, Jul 16, 2013 at 1:26 PM, Lefty Leverenz le...@hortonworks.comwrote:
Congratulations hooray, another committer to share the load!
– Lefty
On Tue, Jul 16, 2013 at 12:49 PM, Mark Grover
grover.markgro...@gmail.comwrote:
Congrats, Brock!
On Tue, Jul 16, 2013
mac and tests passed.
Thanks,
Yin Huai
Hi Mainak,
Can you try 'ant test -Dtestcase=TestRCFile'? It should work.
Thanks,
Yin
On Fri, Jul 19, 2013 at 10:16 AM, Mainak Ghosh gho...@us.ibm.com wrote:
Hello,
I am new to Hive codebase and was hoping to run some of its test code
specifically TestRCFile.java. Unfortunately I am not
] private static ColumnarSerDe serDe;
Any idea what these are? How to resolve them?
I personally do not have a lot of idea on remote debugging Hive. So a step
by step manual if present would be of great help.
Thanks and Regards,
Mainak.
[image: Inactive hide details for Yin Huai ---07/19/2013 10
://reviews.apache.org/r/12767/#review23527
---
On July 19, 2013, 5 p.m., Yin Huai wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12767
are hbase_stats_empty_partition.q and ppd_key_ranges.q in
TestHBaseCliDriver.
I manually tested these two in my mac and tests passed.
Thanks,
Yin Huai
Errors Success rateTime
26882 0 99.93% 43249.945
Two failures are hbase_stats_empty_partition.q and ppd_key_ranges.q in
TestHBaseCliDriver.
I manually tested these two in my mac and tests passed.
Thanks,
Yin Huai
. Any idea how I can
achieve that?
The problem here is my debugger attaches to the live instance of hive and
testcase runs using ant.
Thanks and Regards,
Mainak.
[image: Inactive hide details for Yin Huai ---07/19/2013 11:25:20 AM---Hi
Mainak, Here are steps:]Yin Huai ---07/19/2013 11:25:20
p.m., Yin Huai wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12767/
---
(Updated July 19, 2013, 5 p.m.)
Review request
,
Yin Huai
Congratulations Gunther!
On Sun, Jul 21, 2013 at 7:55 AM, Jarek Jarcec Cecho jar...@apache.orgwrote:
Congratulations Gunther!
Jarcec
On Sun, Jul 21, 2013 at 01:00:31AM -0700, Carl Steinbach wrote:
The Apache Hive PMC has voted to make Gunther Hagleitner a
committer on the Apache Hive
: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
generated e-mail. To reply, visit:
https://reviews.apache.org/r/12795/#review23671
---
On July 22, 2013, 4:19 a.m., Yin Huai wrote:
---
This is an automatically generated e-mail
. Will report what I get later.
- Yin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12795/#review23673
---
On July 22, 2013, 4:19 a.m., Yin Huai
.
Thanks,
Yin Huai
/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/clientpositive/multiMapJoin2.q.out PRE-CREATION
ql/src/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/multiMapJoin2.q.out PRE-CREATION
ql/src/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
Congrats Thejas!!!
On Tue, Aug 20, 2013 at 4:54 PM, Thejas Nair the...@hortonworks.com wrote:
Thanks everybody!
This is a great honor. I hope to live up to the expectations!
It is great to see the fresh momentum in hive and I am glad to be able to
work with the community on it.
Now I will
Seems ReduceSinkDeDuplication picked the wrong partitioning columns.
On Fri, Aug 23, 2013 at 9:15 PM, Shahansad KP s...@rocketfuel.com wrote:
I think the problem lies with in the group by operation. For this
optimization to work the group bys partitioning should be on the column 1
only.
It
Created a jira https://issues.apache.org/jira/browse/HIVE-5149
On Sun, Aug 25, 2013 at 9:11 PM, Yin Huai huaiyin@gmail.com wrote:
Seems ReduceSinkDeDuplication picked the wrong partitioning columns.
On Fri, Aug 23, 2013 at 9:15 PM, Shahansad KP s...@rocketfuel.com wrote:
I think
forgot to add in my last reply To generate correct results, you can
set hive.optimize.reducededuplication to false to turn off
ReduceSinkDeDuplication
On Sun, Aug 25, 2013 at 9:35 PM, Yin Huai huaiyin@gmail.com wrote:
Created a jira https://issues.apache.org/jira/browse/HIVE-5149
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
a52f4eb
ql/src/test/results/clientpositive/groupby_rollup1.q.out f120471
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
c380a2d
ql/src/test/queries/clientpositive/reduce_deduplicate_extended.q a5e9cdf
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13910/diff/
Testing
---
Thanks,
Yin Huai
On Sept. 2, 2013, 5:39 a.m., Yin Huai wrote:
Another sanity check.
Done.
- Yin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13862/#review25819
On Sept. 2, 2013, 5:29 a.m., Yin Huai wrote:
Thanks for adding comments!
We can have a query like ...
explain select * from (select * from src1 cluster by key) tmp sort by key,
value;
In this case, at first, we have two MR jobs. Since the second job is used for
sort
.q.out f120471
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
!
On Sep 4, 2013, at 6:49 AM, Carl Steinbach c...@apache.org
wrote:
The Apache Hive PMC has voted to make Yin Huai a committer on the
Apache
Hive project.
Please join me in congratulating Yin!
Thanks.
Carl
--
Alexander Alten-Lorenz
http
Sure. Let me take a look at 0.11 branch.
On Wed, Sep 4, 2013 at 2:53 PM, Eric Chu e...@rocketfuel.com wrote:
Hi Yin Huai,
This patch doesn't apply cleanly in Hive 11. For example,
ReduceSinkDeDuplication.java is in
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ in Hive 11 while the patch
Hi Eric,
Can you try
https://issues.apache.org/jira/secure/attachment/12601446/HIVE-5149-branch-0.11.patch?
Thanks,
Yin
On Wed, Sep 4, 2013 at 3:14 PM, Yin Huai huaiyin@gmail.com wrote:
Sure. Let me take a look at 0.11 branch.
On Wed, Sep 4, 2013 at 2:53 PM, Eric Chu e
/diff/
Testing
---
Thanks,
Yin Huai
/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
---
Thanks,
Yin Huai
/ColumnProjectionUtils.java
https://reviews.apache.org/r/14221/#comment51371
ok will remove it.
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java
https://reviews.apache.org/r/14221/#comment51372
ok, will also remove other null check
- Yin Huai
On Sept. 19, 2013, 5:48
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
Review request for hive.
Summary
---
This optimizer exploits intra-query
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2011-12-29 18:50:12.277210)
Review request for hive.
Summary
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2012-01-29 17:56:48.704757)
Review request for hive.
Changes
---
Can you try to set serde properties?
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AddSerDeProperties
I have not tried it, but seems it is the right way to pass configurations
to serde class.
Thanks,
Yin
On Mon, Oct 14, 2013 at 8:20 AM, Rui Martins
+1
On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner
ghagleit...@hortonworks.com wrote:
+1
Thanks,
Gunther.
On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley omal...@apache.org wrote:
Ed,
I didn't remember being unable to see revisions without a login. That
is
uncool. I'll
/src/test/results/clientpositive/correlationoptimizer1.q.out dc46a77
Diff: https://reviews.apache.org/r/15101/diff/
Testing
---
HiveQA
Thanks,
Yin Huai
Congrats Xuefu!
On Mon, Nov 4, 2013 at 7:11 AM, Lianhui Wang lianhuiwan...@gmail.comwrote:
Congrats Xuefu!
2013/11/4 Thejas Nair the...@hortonworks.com
Congrats Xuefu!
On Sun, Nov 3, 2013 at 11:11 PM, Mohammad Islam misla...@yahoo.com
wrote:
Congrats Xuefu!
--Mohammad
Hi all,
After importing the trunk to eclipse, I found that eclipse did not load the
hive formatter. Does trunk still have one? If so, where is the location of
it?
Thanks,
Yin
/ConditionalResolverCommonJoin.java
https://reviews.apache.org/r/16172/#comment58602
Let's change it to log the exception instead of printing the stack trace.
- Yin Huai
On Dec. 11, 2013, 2:12 a.m., Navis Ryu wrote:
---
This is an automatically
://reviews.apache.org/r/16172/#comment58622
Seems it is not an error? If so, let's not put it in the ErrorMsg.
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java
https://reviews.apache.org/r/16172/#comment58623
Is this one necessary?
- Yin Huai
On Dec. 18, 2013, 5
Guys,
Seems ConditionalResolverCommonJoin is not working correctly? I created
https://issues.apache.org/jira/browse/HIVE-6668 and set it as a blocker.
thanks,
Yin
On Fri, Mar 14, 2014 at 11:34 AM, Thejas Nair the...@hortonworks.comwrote:
Can you also add HIVE-6647
Congrats Gunther!
On Fri, Dec 27, 2013 at 10:13 AM, Brock Noland br...@cloudera.com wrote:
Congratulations Gunther!
On Fri, Dec 27, 2013 at 9:00 AM, Xuefu Zhang xzh...@cloudera.com wrote:
Many congratulations, Gunther!
--Xuefu
On Thu, Dec 26, 2013 at 8:59 PM, Carl Steinbach
/ConditionalResolverCommonJoin.java
https://reviews.apache.org/r/16172/#comment59277
For the example in the description of HIVE-5945, the same alias $INTNAME
can actually refer to different intermediate tables. So, at here, we will not
update the correct size for an alias $INTNAME.
- Yin Huai
On Dec. 30, 2013, 2
/
Testing
---
Thanks,
Yin Huai
Do we need this?
ql/src/test/queries/clientpositive/correlationoptimizer16.q
https://reviews.apache.org/r/23270/#comment83870
I think correlationoptimizer8 is for cases with UNION ALL. Can we add test
queries in that file?
- Yin Huai
On July 4, 2014, 12:15 a.m., Navis Ryu wrote
Hi,
Based on our language manual (
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF), seems
we do not support == operator. However, in FunctionRegistry, we treat
== as =. I guess we want to make == invalid and throw an exception
when a user uses it?
Thanks,
Yin
Hello All,
When I run hive unit tests, I always can find an error saying the class
of org.apache.hadoop.log.metrics.EventCounter can not be found. Seems the
reason is that in hadoop 0.20.2, the location of EventCounter is
org.apache.hadoop.metrics.jvm.EventCounter, so log4j should load the old
relevant to the patch. Please see
https://issues.apache.org/jira/browse/HIVE-2206?focusedCommentId=13456171page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456171
for details.
Thanks,
Yin Huai
://issues.apache.org/jira/browse/HIVE-2206?focusedCommentId=13456171page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456171
for details.
Thanks,
Yin Huai
, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
to
skewjoinopt17.q, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
to do that? Thanks.
- Yin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7126/#review11858
---
On Sept. 24, 2012, 3:53 p.m., Yin Huai
, skewjoinopt10.q, skewjoinopt15.q to
skewjoinopt17.q, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing (updated)
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing (updated)
---
All tests pass.
Thanks,
Yin Huai
)
---
All tests pass.
Thanks,
Yin Huai
/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/create_view.q 0af3442
ql/src/test/results/clientpositive/create_view.q.out 3b78f1e
Diff: https://reviews.apache.org/r/7222/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3f2
ql/src/test/queries/clientpositive/create_view.q 0af3442
ql/src/test/results/clientpositive/create_view.q.out 3b78f1e
Diff: https://reviews.apache.org/r/7222/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/groupby1.q.xml e1eb209
ql/src/test/results/compiler/plan/groupby2.q.xml 268eb90
ql/src/test/results/compiler/plan/groupby3.q.xml 3e02d15
ql/src/test/results/compiler/plan/groupby5.q.xml 89e1207
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/
Testing
---
All tests pass.
Thanks,
Yin Huai
/plan/groupby2.q.xml 7b07f02
ql/src/test/results/compiler/plan/groupby3.q.xml a6a1986
ql/src/test/results/compiler/plan/groupby5.q.xml 25e3583
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/groupby5.q.xml 632d88e
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
Let me add Reynold to the thread.
On Fri, Dec 18, 2015 at 12:36 PM, Gopal Vijayaraghavan
wrote:
>
> >We have looked into various options, and it looks like the best option is
> >to copy the ANTLR grammar file from Hive into Spark. Because the grammar
> >file is tightly
[
https://issues.apache.org/jira/browse/HIVE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-2206:
---
Attachment: Queries
Two queries (TPC-H Q17 and TPC-H Q18) can be used for testing this optimizer.
Q17
[
https://issues.apache.org/jira/browse/HIVE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054816#comment-13054816
]
Yin Huai commented on HIVE-2206:
The current optimizer can identify correlations with query
[
https://issues.apache.org/jira/browse/HIVE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276409#comment-13276409
]
Yin Huai commented on HIVE-2206:
@anders,
I will try to make this patch more concise
Yin Huai created HIVE-4572:
--
Summary: ColumnPruner cannot preserve RS key columns in
columnExprMap
Key: HIVE-4572
URL: https://issues.apache.org/jira/browse/HIVE-4572
Project: Hive
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-4572:
---
Attachment: HIVE-4572.replay.patch
To see the problem, you can apply the patch HIVE-4572.replay.patch
[
https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-4572:
---
Summary: ColumnPruner cannot preserve RS key columns corresponding to
un-selected join keys in columnExprMap
[
https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-4572:
---
Attachment: HIVE-4572.1.patch.txt
Add a patch
[
https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-4572:
---
Attachment: HIVE-4572.2.patch.txt
Update a new patch. With this one, HIVE-2206 can work
[
https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663236#comment-13663236
]
Yin Huai commented on HIVE-4572:
[~hagleitn] Yes, it is correct.
I have tested
1 - 100 of 638 matches
Mail list logo