str_to_map UDF description fix

2017-01-31 Thread Alexander Pivovarov
Hello Everyone Can anyone look at str_to_map UDF description fix? https://issues.apache.org/jira/browse/HIVE-15746 Thank you Alex

[jira] [Created] (HIVE-15746) Fix default delimiter2 in str_to_map UDF or in method description

2017-01-27 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-15746: -- Summary: Fix default delimiter2 in str_to_map UDF or in method description Key: HIVE-15746 URL: https://issues.apache.org/jira/browse/HIVE-15746 Project

Re: Hadoop-1 is dead, long live Hadoop

2015-10-26 Thread Alexander Pivovarov
Awesome! Looks like cloud.databricks.com run Spark-1.5 clusters with hive-1.2.1 and hadoop-1 (lol). I guess they need to move to hadoop-2 > org.apache.hadoop.util.VersionInfo.getVersion res8: String = 1.2.2-SNAPSHOT On Mon, Oct 26, 2015 at 3:02 PM, Alan Gates wrote: > I've committed HIVE-11378

Re: Review Request 37706: HIVE-11593 Add aes_encrypt and aes_decrypt UDFs

2015-08-26 Thread Alexander Pivovarov
/results/clientpositive/udf_aes_decrypt.q.out PRE-CREATION ql/src/test/results/clientpositive/udf_aes_encrypt.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37706/diff/ Testing --- Thanks, Alexander Pivovarov

Review Request 37706: HIVE-11593 Add aes_encrypt and aes_decrypt UDFs

2015-08-23 Thread Alexander Pivovarov
/udf_aes_encrypt.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37706/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-11593) Add aes_encrypt and aes_decrypt UDFs

2015-08-17 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-11593: -- Summary: Add aes_encrypt and aes_decrypt UDFs Key: HIVE-11593 URL: https://issues.apache.org/jira/browse/HIVE-11593 Project: Hive Issue Type

Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF

2015-08-10 Thread Alexander Pivovarov
sults/clientpositive/vector_bround.q.out PRE-CREATION storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 7d7fb2841bc985c62ecd1781bbde5380647b81ca Diff: https://reviews.apache.org/r/35902/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF

2015-08-10 Thread Alexander Pivovarov
sting --- Thanks, Alexander Pivovarov

Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF

2015-07-26 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35902/#review90283 ------- On July 27, 2015, 6:12 a.m., Alexander Pivovarov wrote: > > --

Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF

2015-07-26 Thread Alexander Pivovarov
itive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3 ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35902/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
ps://reviews.apache.org/r/35963/#review89652 ------- On June 27, 2015, 8:17 p.m., Alexander Pivovarov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 35964: HIVE-7180 BufferedReader is not closed in MetaStoreSchemaInfo

2015-06-27 Thread Alexander Pivovarov
t: https://reviews.apache.org/r/35964/#review89653 --- On June 27, 2015, 8:09 p.m., Alexander Pivovarov wrote: > > --- > This is an automatically generated e-

Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.

2015-06-27 Thread Alexander Pivovarov
hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 109) <https://reviews.apache.org/r/35968/#comment142303> UDF should not throw exceptions in evaluate method ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 122) <https://reviews.apache.org/r/35968/#comme

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
/jdbc/HiveConnection.java 277f6d44d3b3472218526a2933380420676729a3 Diff: https://reviews.apache.org/r/35963/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 35964: HIVE-7180 BufferedReader is not closed in MetaStoreSchemaInfo

2015-06-27 Thread Alexander Pivovarov
/metastore/MetaStoreSchemaInfo.java a5eed6d3c0ff4a229f3209175b8dfcf8bde5e79e Diff: https://reviews.apache.org/r/35964/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
g/r/35963/#review89624 --- On June 27, 2015, 3:23 a.m., Alexander Pivovarov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 35964: HIVE-7180 BufferedReader is not closed in MetaStoreSchemaInfo

2015-06-26 Thread Alexander Pivovarov
://reviews.apache.org/r/35964/diff/ Testing --- Thanks, Alexander Pivovarov

Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-26 Thread Alexander Pivovarov
/hive/jdbc/Utils.java 0e4693b34544fcc4845a7ed0b16dc5299a06455a Diff: https://reviews.apache.org/r/35963/diff/ Testing --- Thanks, Alexander Pivovarov

Re: [ANNOUNCE] New Hive Committers - Jesus Camacho Rodriguez and Chinna Rao Lalam

2015-06-26 Thread Alexander Pivovarov
Congrats! On Jun 26, 2015 1:36 PM, "Hari Subramaniyan" wrote: > Congrats Jesús and Chinna! > > > From: Chao Sun > Sent: Friday, June 26, 2015 12:06 PM > To: dev@hive.apache.org > Cc: jcama...@apache.org; Lalam, Chinna R > Subject: Re: [ANNOUNCE] New Hive

Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF

2015-06-25 Thread Alexander Pivovarov
sting --- Thanks, Alexander Pivovarov

Re: How FuncRoundDoubleToDouble.java is generated?

2015-06-25 Thread Alexander Pivovarov
hive-ant GenVectorCode On Thu, Jun 25, 2015 at 5:20 PM, Alexander Pivovarov wrote: > Hi Everyone > > Can you please explain me how FuncRoundDoubleToDouble is generated? > I tried to find its template and can not find it... > > I need to generate similar class for BROUN

How FuncRoundDoubleToDouble.java is generated?

2015-06-25 Thread Alexander Pivovarov
Hi Everyone Can you please explain me how FuncRoundDoubleToDouble is generated? I tried to find its template and can not find it... I need to generate similar class for BROUND UDF (HIVE-11103) Thank you Alex

[jira] [Created] (HIVE-11116) Can not select data from table which points to remote hdfs location

2015-06-25 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-6: -- Summary: Can not select data from table which points to remote hdfs location Key: HIVE-6 URL: https://issues.apache.org/jira/browse/HIVE-6

[jira] [Created] (HIVE-11103) Add banker's rounding BROUND UDF

2015-06-24 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-11103: -- Summary: Add banker's rounding BROUND UDF Key: HIVE-11103 URL: https://issues.apache.org/jira/browse/HIVE-11103 Project: Hive Issue Type

Re: Review Request 34586: HIVE-10704

2015-06-11 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34586/#review87672 --- Ship it! Ship It! - Alexander Pivovarov On May 27, 2015, 6:33

Re: [ANNOUNCE] New Hive PMC Members - Chao Sun and Gopal Vijayaraghavan

2015-06-10 Thread Alexander Pivovarov
Congratulations to both of you!!! On Wed, Jun 10, 2015 at 3:26 PM, Gopal Vijayaraghavan wrote: > Hi, > > Thanks everyone and Congratulations to Chao! > > Cheers, > Gopal > > On 6/10/15, 2:20 PM, "Carl Steinbach" wrote: > > >I am pleased to announce that Chao Sun and Gopal Vijayaraghavan have be

Re: Review Request 34393: HIVE-10427 - collect_list() and collect_set() should accept struct types as argument

2015-06-04 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34393/#review86692 --- Ship it! Ship It! - Alexander Pivovarov On June 1, 2015, 4:19

Re: Creating branch-1

2015-06-02 Thread Alexander Pivovarov
Hi Alan Is branch-1 on github already? https://github.com/apache/hive/tree/branch-1 On Tue, Jun 2, 2015 at 10:37 AM, Alan Gates wrote: > Ok, I've created branch-1. I've also updated HowToContribute with > information on what patches go where now. Proofreaders and feedback on > clarity are we

Re: hive.optimize.index.filter + ORC + TIMESTAMP throws NPE or IAE depending on hive version

2015-06-01 Thread Alexander Pivovarov
ype. > > > You can try the same with something where hive does the right thing with a > Filter expression > > hive> create temporary table xx(x int) stored as orc; > > hive> insert into xx values (1),(9),(11); > hive> select * from xy where x > Œ9¹; > >

hive.optimize.index.filter + ORC + TIMESTAMP throws NPE or IAE depending on hive version

2015-06-01 Thread Alexander Pivovarov
if hive.optimize.index.filter is enabled then it causes the following the following stacktraces -- create table ts (ts timestamp); insert into table ts values('2015-01-01 00:00:00'); set hive.optimize.index.filter=true; select * from ts where ts

hive.ppd.remove.duplicatefilters description is incorrect. What is the correct one?

2015-06-01 Thread Alexander Pivovarov
I noticed that conf/hive-default.xml.template has the following description hive.ppd.remove.duplicatefilters true Whether to push predicates down into storage handlers. Ignored when hive.optimize.ppd is false. Most probably the description was taken from "hive.optimize.ppd.stora

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

2015-06-01 Thread Alexander Pivovarov
19fe952f5e84755d1e7a8b752997c084dab339b9 service/src/java/org/apache/hive/service/auth/HttpAuthUtils.java 3ef55779a6bde85193ca63ec9683cf9f67d6a39d Diff: https://reviews.apache.org/r/34522/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 34586: HIVE-10704

2015-05-29 Thread Alexander Pivovarov
What if you have table sizes (100, -4, 0) totalSize is 96. But table #2 size is -4, which is bad size. To make code clear I recommend to add new boolean variable isAnyTableHasBadSize and set its value it in the place where you calc totalSize, biggest and maxSize - Alexander Pivo

Re: Review Request 34798: HIVE-10788 - Change sort_array to support non-primitive types

2015-05-29 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34798/#review85852 --- Ship it! Ship It! - Alexander Pivovarov On May 29, 2015, 5:52

Can anyone review HIVE-686 substring_index UDF?

2015-05-29 Thread Alexander Pivovarov
https://issues.apache.org/jira/browse/HIVE-686 https://reviews.apache.org/r/34696/

Re: Slow JIRA

2015-05-28 Thread Alexander Pivovarov
Yes, it's. Need to wait 1-2 min before ticked is opened. On Thu, May 28, 2015 at 1:45 PM, Xuefu Zhang wrote: > Anyone else found JIRA site is extremely slow? Loading a single JIRA takes > a long time, and not to mention doing a search. > > Has this been reported yet? I'm having the problem since

Re: Relativity simple query returns incorrect result

2015-05-28 Thread Alexander Pivovarov
r push-down cases are generally all down to hive.optimize.ppd=true; - > everything becomes clearer when you look at an explain. > > If I had to guess, I¹d say that the new JOIN syntax won¹t have this bug. > > select Š from a,b,c where a.id = b.id, c.x = b.x; > > Cheers, > G

Relativity simple query returns incorrect result

2015-05-28 Thread Alexander Pivovarov
Hi Everyone Couple days ago I stepped on one strange issue - "WHERE col is not null" does not work for one query. Details are here https://issues.apache.org/jira/browse/HIVE-10841 What you think? How critical is it?

[jira] [Created] (HIVE-10841) [WHERE col is not null] does not work for large queries

2015-05-27 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10841: -- Summary: [WHERE col is not null] does not work for large queries Key: HIVE-10841 URL: https://issues.apache.org/jira/browse/HIVE-10841 Project: Hive

Re: [VOTE] Stable releases from branch-1 and experimental releases from master

2015-05-27 Thread Alexander Pivovarov
+1 On May 27, 2015 10:45 AM, "Vikram Dixit K" wrote: > +1 for all the reasons outlined. > > On Tue, May 26, 2015 at 6:13 PM, Thejas Nair > wrote: > > +1 > > - This is great for users who want to take longer to upgrade from > > hadoop-1 and care mainly for bug fixes and incremental features, > >

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-27 Thread Alexander Pivovarov
oning in your example what the expected output would look > > like? > > Alexander Pivovarov wrote: > Not sure I got the issue... > > --- desc output > hive> desc function extended substring_index; > OK > ... > Example: &g

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Alexander Pivovarov
tual select hive> SELECT substring_index('www.apache.org', '.', 2); OK www.apache - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34696/#review85318 ---

Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Alexander Pivovarov
16820ca887320da13a42bebe0876f29eec373c8f ql/src/test/results/clientpositive/udf_substring_index.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34696/diff/ Testing --- Thanks, Alexander Pivovarov

Re: [DISCUSS] Supporting Hadoop-1 and experimental features

2015-05-22 Thread Alexander Pivovarov
s closest to what I'm proposing, though again > dropping support for Hadoop 1 is only a part of it. > > Alan. > > Alexander Pivovarov > May 22, 2015 at 10:03 > Looks like we discussing 3 options: > > 1. Support hadoop 1, 2 and 3 in master branch. > > 2. Supp

Re: [DISCUSS] Supporting Hadoop-1 and experimental features

2015-05-22 Thread Alexander Pivovarov
Looks like we discussing 3 options: 1. Support hadoop 1, 2 and 3 in master branch. 2. Support hadoop 1 in branch-1, hadoop 2 in branch-2, hadoop 3 in branch-3 3. Support hadoop 2 and 3 in master I DO not think option 2 is good solution because it is much more difficuilt to manage 3 active prod

Re: Review Request 34455: HIVE-10550 Dynamic RDD caching optimization for HoS.[Spark Branch]

2015-05-21 Thread Alexander Pivovarov
<https://reviews.apache.org/r/34455/#comment136299> use 2 spaces for indent ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ReduceTran.java <https://reviews.apache.org/r/34455/#comment136300> use 2 spaces for indent - Alexander Pivovarov On May 22, 2015, 6:18 a.m., c

Re: Review Request 34393: HIVE-10427 - collect_list() and collect_set() should accept struct types as argument

2015-05-21 Thread Alexander Pivovarov
tps://reviews.apache.org/r/34393/#comment136097> Is it necessary? - Alexander Pivovarov On May 21, 2015, 5:30 p.m., Chao Sun wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 34393: HIVE-10427 - collect_list() and collect_set() should accept struct types as argument

2015-05-21 Thread Alexander Pivovarov
emove unused imports? import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector.Category; - Alexander Pivovarov On May 21, 2015, 5:30 p.m., Chao Sun wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

2015-05-20 Thread Alexander Pivovarov
visit: https://reviews.apache.org/r/34522/#review84657 --- On May 21, 2015, 2:22 a.m., Alexander Pivovarov wrote: > > --- > This is an automatically generate

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

2015-05-20 Thread Alexander Pivovarov
) signature has "throws IOException". StringBuffer.append() does not have it. This is why line 1829 aggregationKey.append() throw s IOException now which I wrap with RuntimeException - Alexander Pivovarov On May 21, 2015, 2:22 a.m., Alex

Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

2015-05-20 Thread Alexander Pivovarov
3ef55779a6bde85193ca63ec9683cf9f67d6a39d Diff: https://reviews.apache.org/r/34522/diff/ Testing --- Thanks, Alexander Pivovarov

Review Request 34514: HIVE-9875 replace new SimpleDateFormat with DateUtils.getDateFormat

2015-05-20 Thread Alexander Pivovarov
/apache/hadoop/hive/serde2/io/TestTimestampWritable.java 5fee0197d4b3c9c7c395ee252167b22f6fda9f6e Diff: https://reviews.apache.org/r/34514/diff/ Testing --- Thanks, Alexander Pivovarov

Re: [ANNOUNCE] New Hive Committer - Chaoyu Tang

2015-05-20 Thread Alexander Pivovarov
Congrats Chaoyu! On Wed, May 20, 2015 at 3:29 PM, Carl Steinbach wrote: > The Apache Hive PMC has voted to make Chaoyu Tang a committer on the Apache > Hive Project. > > Please join me in congratulating Chaoyu! > > Thanks. > > - Carl >

Re: Review Request 34473: HIVE-10749 Implement Insert statement for parquet

2015-05-20 Thread Alexander Pivovarov
se final ArrayList list = new ArrayList(Collections.nCopies(fields.size(), null)); instead - Alexander Pivovarov On May 20, 2015, 2:54 p.m., cheng xu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 34463: HIVE-10717 Fix failed qtest encryption_insert_partition_static test in Jenkin

2015-05-20 Thread Alexander Pivovarov
/encryption_insert_partition_static.q 9bff0bd34b5ef0cf43f1e6738a6f1bbf5a6f372e ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_static.q.out 8966608d7ec74c66dafc563aa2984efe86cab333 Diff: https://reviews.apache.org/r/34463/diff/ Testing --- Thanks, Alexander Pivovarov

Review Request 34463: HIVE-10717 Fix failed qtest encryption_insert_partition_static test in Jenkin

2015-05-20 Thread Alexander Pivovarov
/clientpositive/encrypted/encryption_insert_partition_static.q.out 96f8b6abdb12f44a1c39d9e9180dbc84b5aa5bee Diff: https://reviews.apache.org/r/34463/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 34443: HIVE-10723 better logging/etc. for stuck metastore

2015-05-19 Thread Alexander Pivovarov
ent135669> maybe use "if (hasTxn)" instead - Alexander Pivovarov On May 19, 2015, 11:23 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To

[jira] [Created] (HIVE-10748) Replace StringBuffer with StringBuilder where possible

2015-05-18 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10748: -- Summary: Replace StringBuffer with StringBuilder where possible Key: HIVE-10748 URL: https://issues.apache.org/jira/browse/HIVE-10748 Project: Hive

Re: Review Request 33968: HIVE-10644 create SHA2 UDF

2015-05-18 Thread Alexander Pivovarov
, Alexander Pivovarov

GenericUDF.getConstantLongValue

2015-05-18 Thread Alexander Pivovarov
Hello Everyone There is a bug in GenericUDF.getConstantLongValue. There are 2 patches available: 1. fix the bug https://issues.apache.org/jira/browse/HIVE-10580 2. delete the method because it's not used https://issues.apache.org/jira/browse/HIVE-10710 Can any committer +1 on one or another sol

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-14 Thread Alexander Pivovarov
> On May 12, 2015, 6:26 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java, > > line 107 > > <https://reviews.apache.org/r/34059/diff/1/?file=955672#file955672line107> > > > > ReduceSinkOpe

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-14 Thread Alexander Pivovarov
> On May 12, 2015, 6:26 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java, > > line 107 > > <https://reviews.apache.org/r/34059/diff/1/?file=955672#file955672line107> > > > > ReduceSinkOpe

fixed couple q tests which failed in recent builds. Need committer review

2015-05-14 Thread Alexander Pivovarov
HIVE-10665 udaf_percentile_approx_23.q HIVE-10706 vectorized_timestamp_funcs.q

Re: JIRA notifications

2015-05-14 Thread Alexander Pivovarov
You can use the following command to create new review. It takes about 3-5 sec $ rbt post -g yes To update the review you can run. $ rbt post -u -g yes On Thu, May 14, 2015 at 10:48 AM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > @Swarnim.. > Generating patch with git diff ne

Review Request 34223: HIVE-10710 Delete GenericUDF.getConstantLongValue

2015-05-14 Thread Alexander Pivovarov
://reviews.apache.org/r/34223/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10710) Delete GenericUDF.getConstantLongValue

2015-05-14 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10710: -- Summary: Delete GenericUDF.getConstantLongValue Key: HIVE-10710 URL: https://issues.apache.org/jira/browse/HIVE-10710 Project: Hive Issue Type

Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality

2015-05-13 Thread Alexander Pivovarov
<https://reviews.apache.org/r/33881/#comment134770> You can use IOUtils.closeQuietly(bw) I do not think we need to log close buffer error - Alexander Pivovarov On May 14, 2015, 5:51 a.m., cheng xu wrote: > > ---

Review Request 34197: HIVE-10706 Make vectorized_timestamp_funcs test more stable

2015-05-13 Thread Alexander Pivovarov
31a96c68b22bd5332fb71b52982de71710df65fa Diff: https://reviews.apache.org/r/34197/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10706) Make vectorized_timestamp_funcs test more stable

2015-05-13 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10706: -- Summary: Make vectorized_timestamp_funcs test more stable Key: HIVE-10706 URL: https://issues.apache.org/jira/browse/HIVE-10706 Project: Hive

Re: Review Request 32807: HIVE-2327 Optimize REGEX UDFs with constant parameter information

2015-05-13 Thread Alexander Pivovarov
, Alexander Pivovarov

Review Request 34183: HIVE-10665 Continue to make udaf_percentile_approx_23.q test more stable

2015-05-13 Thread Alexander Pivovarov
/clientpositive/udaf_percentile_approx_23.q.out 022a884834cb3077b63b98386adbcd879df39fe7 Diff: https://reviews.apache.org/r/34183/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 33788: HIVE-10580 Fix impossible cast in GenericUDF.getConstantLongValue

2015-05-13 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33788/#review83677 --- Ship it! Ship It! - Alexander Pivovarov On May 3, 2015, 5:26

Re: Review Request 33798: HIVE-10590 fix potential NPE in HiveMetaStore.equals

2015-05-13 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33798/#review83662 --- Ship it! Ship It! - Alexander Pivovarov On May 4, 2015, 1:23

Re: Review Request 33878: HIVE-10619 Fix ConcurrentHashMap.get in MetadataListStructObjectInspector.getInstance (52)

2015-05-13 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33878/#review83657 --- Ship it! Ship It! - Alexander Pivovarov On May 6, 2015, 4 a.m

Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality

2015-05-13 Thread Alexander Pivovarov
<https://reviews.apache.org/r/33881/#comment134645> UPPERCASE variables are constants in java. static final beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java <https://reviews.apache.org/r/33881/#comment134643> move bw.close() to finally block - Alexander Pivovarov

Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality

2015-05-13 Thread Alexander Pivovarov
/CliOptionsProcessor.java <https://reviews.apache.org/r/33881/#comment134641> remove spaces pls beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java <https://reviews.apache.org/r/33881/#comment134642> line with spaces - Alexander Pivovarov On May 11, 2015, 3:22 p.m., ch

Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality

2015-05-13 Thread Alexander Pivovarov
tps://reviews.apache.org/r/33881/#comment134640> use String.equalsIgnoreCase instead - Alexander Pivovarov On May 11, 2015, 3:22 p.m., cheng xu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 33790: HIVE-10582 variable typo in HiveOpConverter (714) and SemanticAnalyzer (7496)

2015-05-12 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33790/#review83566 --- Ship it! Ship It! - Alexander Pivovarov On May 3, 2015, 5:48

Re: Review Request 33968: HIVE-10644 create SHA2 UDF

2015-05-12 Thread Alexander Pivovarov
/33968/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 33937: HIVE-10641 create CRC32 UDF

2015-05-12 Thread Alexander Pivovarov
/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 ql/src/test/results/clientpositive/udf_crc32.q.out PRE-CREATION Diff: https://reviews.apache.org/r/33937/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 33927: HIVE-10639 create SHA1 UDF

2015-05-12 Thread Alexander Pivovarov
/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/33927/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 33992: HIVE-10657 Remove copyBytes operation from MD5 UDF

2015-05-12 Thread Alexander Pivovarov
: https://reviews.apache.org/r/33992/diff/ Testing --- Thanks, Alexander Pivovarov

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-11 Thread Alexander Pivovarov
scUtils.java <https://reviews.apache.org/r/34059/#comment134350> Remove this line and add String type declaration 3 lines below. Do not confuse GC. ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java <https://reviews.apache.org/r/34059/#comment134351> it will be false

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-11 Thread Alexander Pivovarov
y internally Just call get(rs) one time, check thet result is not null and remove the second get(rs) - Alexander Pivovarov On May 11, 2015, 9:48 p.m., Jason Dere wrote: > > --- > This is an automatically generated e-

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-11 Thread Alexander Pivovarov
. HashSet algo relies on hashCode/equals methods - Alexander Pivovarov On May 11, 2015, 9:48 p.m., Jason Dere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-11 Thread Alexander Pivovarov
a/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValue.java <https://reviews.apache.org/r/34059/#comment134336> It is not necessary but I do not see a reason why the visibility of this method should be reduced. Should it be public as all others? - Alexander Pivovarov On May

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

2015-05-11 Thread Alexander Pivovarov
lacement) because it is not using Pattern.compile().matcher().replaceAll API Can you use replace('.', '_') instead of replace(".", "_")? - Alexander Pivovarov On May 11, 2015, 9:48 p.m., Jason Dere wrote: > >

Re: [ANNOUNCE] New Hive Committers - Cheng Xu, Dong Chen, and Hari Sankar Sivarama Subramaniyan

2015-05-11 Thread Alexander Pivovarov
Congrats guys! On Mon, May 11, 2015 at 1:54 PM, Carl Steinbach wrote: > The Apache Hive PMC has voted to make Cheng Xu, Dong Chen, and Hari Sankar > Sivarama Subramaniyan committers on the Apache Hive Project. > > Please join me in congratulating Cheng, Dong, and Hari! > > Thanks. > > - Carl >

[jira] [Created] (HIVE-10665) Continue to make udaf_percentile_approx_23.q test more stable

2015-05-09 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10665: -- Summary: Continue to make udaf_percentile_approx_23.q test more stable Key: HIVE-10665 URL: https://issues.apache.org/jira/browse/HIVE-10665 Project

Review Request 33992: HIVE-10657 Remove copyBytes operation from MD5 UDF

2015-05-08 Thread Alexander Pivovarov
--- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10657) Remove copyBytes operation from MD5 UDF

2015-05-08 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10657: -- Summary: Remove copyBytes operation from MD5 UDF Key: HIVE-10657 URL: https://issues.apache.org/jira/browse/HIVE-10657 Project: Hive Issue Type

Re: Review Request 33927: HIVE-10639 create SHA1 UDF

2015-05-08 Thread Alexander Pivovarov
/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/33927/diff/ Testing --- Thanks, Alexander Pivovarov

Review Request 33968: HIVE-10644 create SHA2 UDF

2015-05-07 Thread Alexander Pivovarov
/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 ql/src/test/results/clientpositive/udf_sha2.q.out PRE-CREATION Diff: https://reviews.apache.org/r/33968/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10644) create SHA2 UDF

2015-05-07 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10644: -- Summary: create SHA2 UDF Key: HIVE-10644 URL: https://issues.apache.org/jira/browse/HIVE-10644 Project: Hive Issue Type: Improvement

Review Request 33937: HIVE-10641 create CRC32 UDF

2015-05-06 Thread Alexander Pivovarov
-CREATION Diff: https://reviews.apache.org/r/33937/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10641) create CRC32 UDF

2015-05-06 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10641: -- Summary: create CRC32 UDF Key: HIVE-10641 URL: https://issues.apache.org/jira/browse/HIVE-10641 Project: Hive Issue Type: Improvement

Review Request 33927: HIVE-10639 create SHA1 UDF

2015-05-06 Thread Alexander Pivovarov
-CREATION Diff: https://reviews.apache.org/r/33927/diff/ Testing --- Thanks, Alexander Pivovarov

[jira] [Created] (HIVE-10639) create SHA1 UDF

2015-05-06 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10639: -- Summary: create SHA1 UDF Key: HIVE-10639 URL: https://issues.apache.org/jira/browse/HIVE-10639 Project: Hive Issue Type: Improvement

Re: Review Request 33861: HIVE-10608 Fix useless 'if' stamement in RetryingMetaStoreClient (135)

2015-05-06 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33861/#review82703 --- Ship it! Ship It! - Alexander Pivovarov On May 5, 2015, 8:19

Re: Review Request 33880: HIVE-10621 serde typeinfo equals methods are not symmetric

2015-05-06 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33880/#review82702 --- Ship it! Ship It! - Alexander Pivovarov On May 6, 2015, 4:59

  1   2   3   4   5   6   7   8   >