Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/#review220990 --- Ship it! Ship It! - Karen Coppage On June 8, 2020, 10:58 a.m

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

> On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 1411 (original) > > > > > > Are these originals not needed, or collected elsewhere? > > Peter

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/#review220956 --- LGTM, a few minor suggestions. (Non-binding) ql/src/java/org/apa

Re: Review Request 72553: HIVE-23555 Cancel compaction jobs when hive.compactor.worker.timeout is reached

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72553/#review220905 --- LGTM, one nit:) ql/src/java/org/apache/hadoop/hive/ql/txn/compac

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > Minor comments only. > > Thanks for the patch! Thanks for the review!! > On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > >

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ --- (Updated May 19, 2020, 5:58 a.m.) Review request for hive, Laszlo Pinter and Pe

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > > > > > > Migth want to add asserts here to check non-null argument

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72444/ --- (Updated April 28, 2020, 10:37 a.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

> On April 28, 2020, 8:54 a.m., Peter Vary wrote: > > Thanks for the patch Karen! > > Few questions below. > > > > Thanks, > > Peter Thanks for the review, Peter! Questions are addressed below. > On April 28, 2020, 8:54 a.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/H

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72444/ --- (Updated April 28, 2020, 8:39 a.m.) Review request for hive, Laszlo Pinter and

Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ --- Review request for hive and Laszlo Pinter. Bugs: HIVE-22971 https://issues.

Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/#review220095 --- LGTM, one suggestion below. Also Zoltan Chovan seemed excited abou

Re: Review Request 72193: HIVE-22977: Merge delta files instead of running a query in major/minor compaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72193/#review219795 --- How feasible would it be to launch this process from CompactorMR i

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72145/#review219606 --- Ship it! Ship It! - Karen Coppage On Feb. 17, 2020, 3:30 p.m

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72145/#review219605 --- standalone-metastore/metastore-common/src/main/java/org/apache/ha

Re: Review Request 72105: HIVE-22610: Minor compaction for MM (insert-only) tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72105/ --- (Updated Feb. 12, 2020, 3:23 p.m.) Review request for hive and Laszlo Pinter.

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72063/ --- (Updated Feb. 7, 2020, 8:40 a.m.) Review request for hive and Peter Vary. Cha

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72063/ --- (Updated Feb. 6, 2020, 2:22 p.m.) Review request for hive and Peter Vary. Cha

Re: Review Request 72084: HIVE-21216: Write Parquet INT64 timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72084/ --- (Updated Feb. 6, 2020, 2:12 p.m.) Review request for hive and Marta Kuczora.

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

> On Feb. 4, 2020, 2:03 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 8475 (patched) > > > > > > do we really need this much if-s ? > > > > >

Re: Review Request 72074: HIVE-21215: Read Parquet INT64 timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72074/#review219469 --- Ship it! Ship It! - Karen Coppage On Feb. 3, 2020, 12:31 p.m

Re: Review Request 72074: HIVE-21215: Read Parquet INT64 timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72074/#review219466 --- Thanks for the patch, looks good! Two ideas: 1. It would be nice t

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72063/ --- (Updated Jan. 30, 2020, 3:30 p.m.) Review request for hive and Peter Vary. Bu

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/#review219420 --- Ship it! Ship It! - Karen Coppage On Jan. 29, 2020, 9:20 a.m

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/#review219419 --- - Karen Coppage On Jan. 29, 2020, 9:20 a.m., Laszlo Pinter wrote

Re: Review Request 71271: HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71271/ --- (Updated Aug. 21, 2019, 11:55 a.m.) Review request for hive and Marta Kuczora.

Re: Review Request 71016: HIVE-21578: Introduce SQL:2016 formats FM, FX, and nested strings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71016/ --- (Updated July 26, 2019, 10:01 a.m.) Review request for hive and Marta Kuczora.

Re: Review Request 70920: HIVE-21868: Vectorize CAST...FORMAT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70920/ --- (Updated July 4, 2019, 3:04 p.m.) Review request for hive and Marta Kuczora.

Re: Review Request 70920: HIVE-21868: Vectorize CAST...FORMAT

> On July 3, 2019, 10:51 a.m., Marta Kuczora wrote: > > Thanks a lot Karen for the patch! > > I have some questions, but otherwise the change looks good to me. Thanks very much for the review! > On July 3, 2019, 10:51 a.m., Marta Kuczora wrote: > > common/src/java/org/apache/hadoop/hive/common

Re: Review Request 70841: HIVE-21576: Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70841/ --- (Updated June 14, 2019, 8:30 a.m.) Review request for hive and Gabor Kaszab.

Re: Review Request 70841: HIVE-21576: Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70841/ --- (Updated June 14, 2019, 7:05 a.m.) Review request for hive and Gabor Kaszab.

Review Request 70841: HIVE-21576: Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70841/ --- Review request for hive. Bugs: HIVE-21576 https://issues.apache.org/jira/br

Re: Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69254/ --- (Updated Nov. 19, 2018, 3:12 p.m.) Review request for hive. Changes ---

Re: Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69254/ --- (Updated Nov. 7, 2018, 8:56 a.m.) Review request for hive. Bugs: HIVE-20818

Re: Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

> On Nov. 5, 2018, 8:41 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 3321 (patched) > > > > > > Is the problem only affects CBO, or RBO as well? > > What

Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69254/ --- Review request for hive. Bugs: HIVE-20818 https://issues.apache.org/jira/br

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68710/ --- (Updated Sept. 24, 2018, 2:01 p.m.) Review request for hive and Laszlo Pinter.

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68710/ --- (Updated Sept. 24, 2018, 1:47 p.m.) Review request for hive and Laszlo Pinter.

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

> On Sept. 21, 2018, 3:41 p.m., Andrew Sherman wrote: > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java > > Line 546 (original), 546 (patched) > > > > > > why give a

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68710/ --- (Updated Sept. 21, 2018, 3:31 p.m.) Review request for hive and Laszlo Pinter.