[jira] [Commented] (HIVE-2036) Update bitmap indexes for automatic usage

2011-05-19 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036685#comment-13036685
 ] 

Russell Melick commented on HIVE-2036:
--

To expand a bit on Marquis' comments.

In CompactIndexHandler.getIndexPredicateAnalyzer(), we instantiate a predicate 
analyzer.  My theory is that you're going to want a whole new PredicateAnalyzer 
class to deal with bitmaps, and then you'll instantiate it in a very similar 
way inside BitmapIndexHandler.  You can also see here how we only search for 
columns on which we have indexes.  This is going to need to be modified, since 
it currently only allows columns from a single index.

You may also want to rewrite some of the logic in 
IndexWhereProcessor.process():110.  It currently loops through every index 
available and asks it to do a rewrite.  Perhaps it should loop through every 
index type and try to find the rewrites possible only using indexes of that 
type.

If you look at IndexPredicateAnalyzer:123, you can see where it's making sure 
that all the parent operators are AND operations.  It should be easy to modify 
this to allow OR operations, but I'm not sure that simply allowing them and 
using the current system will maintain logical correctness.  It's probably 
better to start off with just AND's.

The pushedPredicate is the important thing returned by the predicate analyzer.  
The pushed predicate is what it was able to recognize/process.  That's the tree 
you'll want to use to generate the bitmap query.  The residual predicate is 
what it couldn't process. There's a separate JIRA open (HIVE-2115) to use the 
residual to cut down on remaining work.

The query generation lives in the IndexHandlers.generateIndexQuery(...).  
You'll definitely need more logic than the simple call to 
decomposedPredicate.pushedPredicate.getExprString() that is in the 
CompactIndexHandler.

There are a few spots where hive.index.compact.file is used.  These may need 
generalized.  However, Marquis may have already taken care of this with the 
bitmap stuff.  I don't remember what the new name for it was (I think it's 
hive.index.blockfilter.file), but it's probably easiest to look in one of his 
unit tests for it.

The last thing I can think of is that having multiple index types on a single 
table, or queries that use multiple tables may become an issue.  I created 
HIVE-2128 to deal with the multiple tables.

Good luck!

 Update bitmap indexes for automatic usage
 -

 Key: HIVE-2036
 URL: https://issues.apache.org/jira/browse/HIVE-2036
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick
Assignee: Jeffrey Lym

 HIVE-1644 will provide automatic usage of indexes, and HIVE-1803 adds bitmap 
 index support.  The bitmap code will need to be extended after it is 
 committed to enable automatic use of indexing.  Most work will be focused in 
 the BitmapIndexHandler, which needs to generate the re-entrant QL index 
 query.  There may also be significant work in the IndexPredicateAnalyzer to 
 support predicates with OR's, instead of just AND's as it is currently.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-05-01 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Status: Patch Available  (was: Open)

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.19.patch, 
 HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
 HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch, 
 hive.log


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-05-01 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.19.patch

Patch 19 ready for review.

https://reviews.apache.org/r/558/

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.19.patch, 
 HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
 HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch, 
 hive.log


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2138) Exception when no splits returned from index

2011-04-30 Thread Russell Melick (JIRA)
Exception when no splits returned from index


 Key: HIVE-2138
 URL: https://issues.apache.org/jira/browse/HIVE-2138
 Project: Hive
  Issue Type: Bug
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick


Running a query that uses indexing but doesn't return any results give an 
exception.

{code} java.lang.IllegalArgumentException: Can not create a Path from an empty 
string
at org.apache.hadoop.fs.Path.checkPathArg(Path.java:82)
at org.apache.hadoop.fs.Path.init(Path.java:90)
at org.apache.hadoop.util.StringUtils.stringToPath(StringUtils.java:224)
at 
org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:282)
at 
org.apache.hadoop.hive.ql.index.HiveIndexedInputFormat.getSplits(HiveIndexedInputFormat.java:123)
 {code}

This could potentially be fixed by creating a new empty file to use for the 
splits.

Once this is fixed, the index_auto_test_if_used.q can be used.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2138) Exception when no splits returned from index

2011-04-30 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-2138:
-

Attachment: index_auto_test_if_used.q

Attached test file (index_auto_test_if_used) that should test whether indexes 
are used.

 Exception when no splits returned from index
 

 Key: HIVE-2138
 URL: https://issues.apache.org/jira/browse/HIVE-2138
 Project: Hive
  Issue Type: Bug
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick
 Attachments: index_auto_test_if_used.q


 Running a query that uses indexing but doesn't return any results give an 
 exception.
 {code} java.lang.IllegalArgumentException: Can not create a Path from an 
 empty string
 at org.apache.hadoop.fs.Path.checkPathArg(Path.java:82)
 at org.apache.hadoop.fs.Path.init(Path.java:90)
 at org.apache.hadoop.util.StringUtils.stringToPath(StringUtils.java:224)
 at 
 org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:282)
 at 
 org.apache.hadoop.hive.ql.index.HiveIndexedInputFormat.getSplits(HiveIndexedInputFormat.java:123)
  {code}
 This could potentially be fixed by creating a new empty file to use for the 
 splits.
 Once this is fixed, the index_auto_test_if_used.q can be used.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-29 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: hive.log

I've attached the hive.log I get from running

{{{
ant test -Dtestcase=TestCliDriver -Dqfile=index_auto_test_if_used.q
}}}

I still am only seeing input formats of 
org.apache.hadoop.hive.ql.io.HiveInputFormat and 
org.apache.hadoop.hive.ql.io.CombineHiveInputFormat


But, the good news (I guess) is that the splits exception also happens when 
using the index manually

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch, hive.log


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-29 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027283#comment-13027283
 ] 

Russell Melick commented on HIVE-1644:
--

I can send it back out of the index handler, and that seems to function 
correctly.
{{{
  if (newInputPaths.length() == 0) {
return super.getSplits(job, numSplits);
  } else {
FileInputFormat.setInputPaths(job, newInputPaths.toString());
  }
}}}
But, this means that we won't use the index to get the splits, so I don't think 
our test will work anymore.  It will return results from the base table.  This 
feels like the correct behavior in the long term, even though it breaks the 
test.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch, hive.log


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-29 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027294#comment-13027294
 ] 

Russell Melick commented on HIVE-1644:
--

Unfortunately, having an empty array gives out of bounds exceptions.

{{
java.lang.ArrayIndexOutOfBoundsException: 0
[junit] at 
org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:309)
}}

I tried looking through the code at other places we call setInputPaths. In a 
few places, we create a directory by calling

{{
Path dir = new Path(System.getProperty(test.data.dir, .));
FileInputFormat.setInputPaths(job, dir);
}} 


I tried using this, but unfortunately, this also gives an exception.
{{
java.io.IOException: cannot find dir = file:/Users/rmelick/hive/ql/mapred in 
pathToPartitionInfo: 
[pfile:/Users/rmelick/hive/build/ql/test/data/warehouse/temp]
}}

The ql/mapred directory does not exist on my computer, but I also tried 
changing it to just hive/ql, and it also failed with the same exception.  I'm 
not sure if TestFlatFileInputFormat:146 is creating the temp file like you were 
thinking.  I haven't tried doing it like that.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch, hive.log


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-28 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.18.patch

patch 18

I moved that logic into a helper method, but I'm not seeing the settings being 
changed in build/ql/tmp/hive.log

When I have the unit test use a predicate like key=86 instead of key  45 AND 
key  55, I see the following error
{{{
  java.lang.IllegalArgumentException: Can not create a Path from an empty string
at org.apache.hadoop.fs.Path.checkPathArg(Path.java:82)
at org.apache.hadoop.fs.Path.init(Path.java:90)
at org.apache.hadoop.util.StringUtils.stringToPath(StringUtils.java:224)
at 
org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:282)
at 
org.apache.hadoop.hive.ql.index.HiveIndexedInputFormat.getSplits(HiveIndexedInputFormat.java:123)
at org.apache.hadoop.mapred.JobClient.writeOldSplits(JobClient.java:810)
...
}}}

It seems like this is causing a problem when there are no blocks to return.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.17.patch, HIVE-1644.18.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-23 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.16.patch

Patch 16

One last problem.  It doesn't appear the index is actually used.  I tried 
looking a little bit at the hadoop logs, but I don't really know what I'm 
looking for.  I left a comment on the reviewboard.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
 HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
 HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2129) Display indexing information for TableScanOperator in plan

2011-04-22 Thread Russell Melick (JIRA)
Display indexing information for TableScanOperator in plan
--

 Key: HIVE-2129
 URL: https://issues.apache.org/jira/browse/HIVE-2129
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick


Show the indexInputFormat and indexIntermediateFile in the plan, to indicate 
that the table scan's input is being filtered by the intermediate file.  But, 
we only want to do this when these values are non-null (could use the 
usesIndex() function), so that all the old tests aren't messed up.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2130) Cost based choice for rewrite during Automatic Indexing

2011-04-22 Thread Russell Melick (JIRA)
Cost based choice for rewrite during Automatic Indexing
---

 Key: HIVE-2130
 URL: https://issues.apache.org/jira/browse/HIVE-2130
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick


After processing a predicate, there are potentially multiple index rewrites 
possible.  Currently, we just choose the first one.  However, there are 
probably heuristics for choosing certain rewrites over others, based on 
potential time savings. See IndexWhereProcessor for a good place to do this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-16 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.14.patch

Include new unit tests.  Also asked a few more questions on the review board.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.14.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, 
 HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, 
 HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-15 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.13.patch

I have several questions on the review board.  I also fixed the minor issues, 
but have not yet created the new unit tests.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
 HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
 HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2115) Process residual predicate during automatic index query

2011-04-15 Thread Russell Melick (JIRA)
Process residual predicate during automatic index query
---

 Key: HIVE-2115
 URL: https://issues.apache.org/jira/browse/HIVE-2115
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick


During automatic use of indexes, we analyze the query predicate to pull out 
what we can use the index on.  Not all of the predicate can necessarily be 
processed with a single index.  Currently, we return the residual predicate 
from the IndexHandler but do not process it further.  We run the full original 
predicate on the index table.  Ideally, we would want to only run the residual 
predicate so we don't have to do as much processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-06 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.12.patch

Includes check to make sure that all partitions in the query exist on the index 
table.

Review board available at https://reviews.apache.org/r/558/

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-04-06 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Affects Version/s: (was: 0.7.0)
   0.8.0
 Release Note: Enables automatic use of Compact indexes by setting 
hive.optimize.autoindex=true
   Status: Patch Available  (was: In Progress)

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-31 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014394#comment-13014394
 ] 

Russell Melick commented on HIVE-1644:
--

I'm having trouble getting the partitions from an Index.  I do not know how to 
get back to the index table, so I cannot use getPartCols()

I would like to do something like this, but I don't know how to get the 
indexTable.

{code:java}
for (Index index : indexes.get(part.getTable())) {
Table indexTable;
indexTable = ???
ListFieldSchema indexPartitions = indexTable.getPartCols();
for (FieldSchema col : part.getCols()) {
  if (! indexPartitions.contains(col)) {
return null;
  }
}
  }
{code}

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.11.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, 
 HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, 
 HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2081) Prevent automatic indexing from creating worse queries

2011-03-29 Thread Russell Melick (JIRA)
Prevent automatic indexing from creating worse queries
--

 Key: HIVE-2081
 URL: https://issues.apache.org/jira/browse/HIVE-2081
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.8.0
Reporter: Russell Melick


We want to make sure that automatically using indexes doesn't make the query 
worse.  For example, after scanning the index table, it might still need to 
scan the whole base table.  In this case, we would much rather just kill the 
index job and go back and scan the whole base table.

This can be done by adding a conditional task and a backup task. You can detect 
whether the index is good or not by monitoring the index job's number of input 
records and number of output records, and comparing them. As an initial 
example, if the ratio is 50, do not use the index, and go back to scanning the 
whole base table.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-23 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.10.patch

Yongqiang, I think I fixed the double processing by using a different regular 
expression.  I use FIL%SEL% instead of just FIL%.  I have also fixed the other 
comments.  After you look over it, I think it's ready for a reviewboard.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
 HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
 HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-17 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.8.patch

HIVE-1644.8.patch

Fixed unit tests per John and Yonqiang.  Cleaned up comments.  Ready for 
review.  I still have a few questions that are probably best answered in the 
review:

 * When we have multiple indexes, and we get different tasks lists from 
querying each index, what should we do?  Right now we use all tasks 
(IndexWhereProcessor.java:57)
 * Is it possible to improve the regex we use so that it only matches WHERE 
clauses?  Right now we use FIL to get to the WHERE 
(IndexWhereTaskDispatcher.java:141)
 * What comparison operators should we support?  Right now it's only , , and 
=.  We don't have = or = (CompactIndexHandler.java:272)

Should I put this into the reviewboard?

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, 
 HIVE-1644.8.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-08 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.7.patch

HIVE-1744.7.patch:

@Yongqiang, I fixed the problems in GenMRTableScal1.java, and think I have 
dealt with most of your comments.  I'm confused about what you mean with the 
combinehiveinputformat.

@John, I made a first attempt at factoring SemanticAnalyzer calls into the 
ParseContext, but would appreciate your input.  This patch will also fail the 
unit test index_opt_where_simple.q as it stands.  However, if you remove the 
lines that attempt to use manual indexing, it succeeds.  The test that succeeds 
looks like

{code:sql}
CREATE INDEX src_index ON TABLE src(key) as 'COMPACT' WITH DEFERRED REBUILD;
ALTER INDEX src_index ON src REBUILD;

SET hive.optimize.autoindex=true;
EXPLAIN SELECT key, value FROM src WHERE key=86 ORDER BY key;
SELECT key, value FROM src WHERE key=86 ORDER BY key;

DROP INDEX src_index on src;
{code}

It appears as if our regular expression that identifies WHERE clauses by 
looking for FIL operators (filters) may not be specific enough.  I think the 
remaining errors might be caused by trying to generate index queries for both 
the {{{SELECT ... FROM src}}} (as desired), and the {{{SELECT ... FROM 
default__src_src_index__}}} that we generated, which is a problem.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-05 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.5.patch

HIVE-1644.5.path

I have moved the processing into the PhysicalOptimizer and refactored some of 
the code into IndexWhereTaskDispatcher.  It follows the patterns of 
SkewJoinResolver more closely.

However, this will not run.  In IndexWhereProcessor.rewriteForIndex(...) [line 
110], we call back to the IndexHandler like before.  But, for some reason, the 
parseContext we're getting from the physicalContext in IndexWhereResolver does 
not have a link back to a SemanticAnalyzer.  Any ideas?

I do think that this is correctly making the tasks dependent though.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-03-05 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.6.patch

New patch fixes the NPE by linking the SemanticAnalyzer into the parseContext 
per John's comment.

Also updated unit test to turn off automatic indexing so it doesn't crash when 
manually using index.  Should probably check somewhere in the code instead.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, 
 HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-25 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.3.patch

Much cleaner patch, which includes moving the re-entrant QL generation into the 
IndexHandler.  Still nothing to figure out the tmp file name.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch, HIVE-1644.3.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-24 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999206#comment-12999206
 ] 

Russell Melick commented on HIVE-1644:
--

Make sure we update the admin configuration page 
(http://wiki.apache.org/hadoop/Hive/AdminManual/Configuration) with the new 
default autoindex property.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-22 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.2.patch

Includes modification of MapReduce tasks to use index input format and broken 
temp file name.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-22 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998155#comment-12998155
 ] 

Russell Melick commented on HIVE-1644:
--

We also spoke about changing the re-entrant query construction to live within 
the IndexHandler class.  Unfortunately, the Index object can only give us 
access to the Handler's name as a string, not an instance of it 
(IndexWhereProcessor.rewriteForIndex).  I looked through the codebase some to 
figure out how classes are loaded from strings, and found several examples of 
using Class.forName(...).  Any suggestions here?

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch, HIVE-1644.2.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Work started: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-15 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-1644 started by Russell Melick.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick

 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HIVE-1644) use filter pushdown for automatically accessing indexes

2011-02-15 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1644:
-

Attachment: HIVE-1644.1.patch

I'm having trouble joining the operator trees together.  Within
org.apache.hadoop.hive.ql.optimizer.index.IndexWhereProcessor,
I'm working within rewriteForIndex(...).  I added a unit test called
index_opt_where.q, which is what I'll be using for examples.

After line 139, I have 2 parseContexts: 1 is the original parse context
of the normal query 

(SELECT * FROM src WHERE key=86 ORDER BY key), 

and the other is the parseContext of the reentrant query used to
generate the temporary table.

(INSERT OVERWRITE DIRECTORY /tmp/index_result_where1 SELECT
`_bucketname` ,  `_offsets` FROM default__src_src_index__ WHERE key=86)

I don't really know how to join the operator trees from these
parseContexts together.  I tried just setting the topOps of the original
query to include the topOps of the reentrant query.  I ran into null
pointer exceptions when it went to optimize using other Transforms.

I then tried add the topOps of the original query as the child of the
very bottom child node of the reentrant query, and then setting that
combined operator tree as the topOp of the original parseContext.  That
gave me trouble.  For some reason, the IndexWhereProcessor.process(...)
method is called twice, and the second time, it would try to use the
reentrant topOp table name (default__src_src_index...) to lookup the
tblScan operator, but the new topOp only had src as a TableScan. The new
topOp was the reentrant query, and that doesn't scan it default__src...
table, it creates it.

I've attached a patch, in hopes that it will reasonably easy to see what
I'm talking about.  There are lot of hacks in it (it always uses
indexOptimizing as an Optimization, and the query reconstruction is
bad), but it's stuff I didn't want to worry about until I could get it
working.

 use filter pushdown for automatically accessing indexes
 ---

 Key: HIVE-1644
 URL: https://issues.apache.org/jira/browse/HIVE-1644
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Attachments: HIVE-1644.1.patch


 HIVE-1226 provides utilities for analyzing filters which have been pushed 
 down to a table scan.  The next step is to use these for selecting available 
 indexes and generating access plans for those indexes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES

2010-11-11 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Attachment: HIVE-1497.7.patch

Pluralized col_names in the FORMATTED column header

 support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES
 

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, HIVE-1497.6.patch, 
 HIVE-1497.7.patch, hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES

2010-11-11 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Status: Patch Available  (was: Open)

 support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES
 

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, HIVE-1497.6.patch, 
 HIVE-1497.7.patch, HIVE-1497.8.patch, hive-1497.p1.patch, hive-1497.p2.patch, 
 hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES

2010-11-10 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Attachment: HIVE-1497.6.patch

 * Removed commented out code
 * Added a test case with index comment
 * Added FORMATTED keyword to optionally show column headers
 * Added test case for compound index

Yongqiang, I'm not sure why we want to take out the line
{nopanel}
setFetchTask(createFetchTask(showIndexesDesc.getSchema()));
{nopanel}
The other functions in the SemanticAnalyzer have similar function calls.

John, we get the column headers directly from the schema we set inside of 
ShowIndexesDesc, so it would be difficult to pluralize col_name.  Do you know 
what other show commands do?

 support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES
 

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, HIVE-1497.6.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES

2010-11-10 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Status: Patch Available  (was: Open)

 support COMMENT clause on CREATE INDEX, and add new command for SHOW INDEXES
 

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, HIVE-1497.6.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-04 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12928140#action_12928140
 ] 

Russell Melick commented on HIVE-1497:
--

Should also update the Index wiki:

http://wiki.apache.org/hadoop/Hive/IndexDev

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-02 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Attachment: HIVE-1497.4.patch

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, hive-1497.p1.patch, 
 hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-10-27 Thread Russell Melick (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Russell Melick updated HIVE-1497:
-

Attachment: hive-1497.p3.patch

Coding complete, but unit tests not added yet.  Does not deal with partitions 
either.

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: hive-1497.p1.patch, hive-1497.p2.patch, 
 hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.