Re: Review Request 71267: HIVE-22087: Transform Database object on getDatabase() to return location based on client capabilities.

/hive_metastore.thrift Lines 1938 (patched) <https://reviews.apache.org/r/71267/#comment304501> To future proof that, it would have better better to have a GetDatabaseResponse as well similar to get_catalog. That can be a smaller follo wup patch - Thejas Nair On Aug. 14, 2019, 6:

Re: Avoiding merge commits

+1 On Mon, Mar 11, 2019 at 8:22 AM Owen O'Malley wrote: > I'm +1 for avoiding merge commits on master and release branches. > > .. Owen > > > On Mon, Mar 11, 2019 at 7:47 AM Ashutosh Chauhan > wrote: > > > Hi, > > With advent of gitbox/github integration, folks have started using merge > >

Re: Force push of branch-2.3

+1 On Wed, Mar 27, 2019 at 9:45 AM Owen O'Malley wrote: > All, >The branch-2.3 currently does not have either the rel/release-2.3.3 or > rel/release-2.3.4 tag on it. There is only one commit after the 2.3.4 tag > that back ports HIVE-20126. If no one objects, I’d like to force push >

Re: [ANNOUNCE] New committer: Mahesh Behera

Congrats Mahesh! Very well deserved! On Fri, Nov 16, 2018 at 6:24 PM Ashutosh Chauhan wrote: > > Apache Hive's Project Management Committee (PMC) has invited Mahesh > Behera to become a committer, and we are pleased to announce that he has > accepted. > Mahesh, welcome, thank you for your

Re: HIVE-20420 Provide a fallback authorizer when no other authorizer is in use

This was for CVE-2018-11777. You can find more details in description of CVE-2018-11777 On Wed, Nov 14, 2018 at 3:40 AM Oleksiy S wrote: > > Guys, could you help with this new feature? HIVE-20420 > > I see no docs, no use cases, just nothing. Thanks. > > -- > Oleksiy

Re: [VOTE] Apache Hive 2.3.4 Release Candidate 0

+1 Verified signatures, build src tar On Wed, Oct 31, 2018 at 2:45 PM Daniel Dai wrote: > > Apache Hive 2.3.4 Release Candidate 0 is available here: > > http://people.apache.org/~daijy/apache-hive-2.3.4-rc-0/ > > Maven artifacts are available here: > >

Re: [VOTE] Apache Hive 3.1.1 Release Candidate 0

* Verified signatures and checksums. * Reviewed git rc tag contents * Build src tar.gz * Untarred bin.tar.gz and ran queries +1 to the release On Wed, Oct 24, 2018 at 4:59 PM Daniel Dai wrote: > > Apache Hive 3.1.1 Release Candidate 0 is available here: > >

Re: Apache Hive 3.1. release preparation

Hi Vihang, I don't think we need to serialize these releases at this time. The metastore is still being released as part of hive as well at this time. Maybe as part of the Hive 3.1 release process, ie after branching, during stabilization/voting you can verify that metastore in standalone mode is

Re: Ptest timeouts

+ Vihang On Tue, Jun 19, 2018 at 1:55 AM, Prasanth Jayachandran wrote: > Precommit tests have started to timeout again. Could it be because of disk > space issue? Should we need restart again? Sometimes >90% disk usage may also > result in unhealthy node where no containers can be launched. >

Re: Cleaning up old version in dist

+1 On Thu, Jun 7, 2018 at 11:13 AM, Alan Gates wrote: > Apache asks that we keep at most 2 current versions in dist, to minimize > the space we take up on distribution mirrors. Since we are running > multiple lines and a have a couple of separately releasable modules we'll > have more than 2

Re: Metastore thrift api permission

This covers metastore api authorization - https://cwiki.apache.org/confluence/display/Hive/Storage+Based+Authorization+in+the+Metastore+Server On Tue, May 29, 2018 at 8:29 AM, 侯宗田 wrote: > Hello,everyone: > I am using HMS thrift api to get metadata of hive table, it is ok in my local > host.

Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work with information schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67102/#review203274 --- Ship it! Ship It! - Thejas Nair On May 15, 2018, 9:04 p.m

Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work with information schema

Lines 992 (patched) <https://reviews.apache.org/r/67102/#comment285140> how about using AuthorizationPreEventListener.class.getName() or so ? - Thejas Nair On May 15, 2018, 9:04 p.m., Daniel Dai

Re: [VOTE] Stricter commit guidelines

+1 On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez wrote: > After work has been done to ignore most of the tests that were failing > consistently/intermittently [1], I wanted to start this vote to gather > support from the community to be stricter wrt committing

Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work with information schema

rMetastoreSecurity - Thejas Nair On May 11, 2018, 9:55 p.m., Daniel Dai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67102/ >

Re: Apache Hive 3.0.0 release preparation

estigate and find out root cause of these failures. If its >> determined that its a corner case and fix is non-trivial then we may >> release note it under known issues. But ideally we should fix these >> failures. >> Cutting a branch should make it easier since branch is expected to r

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

erence shold be removed from this class ql/src/java/org/apache/hadoop/hive/ql/metadata/JarUtils.java Lines 143 (patched) <https://reviews.apache.org/r/66571/#comment283781> how about using java8 style and skip finally block - try (ZipFile zip = new ZipFile(jar)) {

Re: Proposal: Apply SQL based authorization functions in the metastore.

Hi Elliot, One scenario where Storage based authorization doesn't work is the case of object stores such as S3. In those scenarios, the tool/platform that is accessing the data won't have any restrictions on data access either. I am not sure how the data access would be secured in such cases,

Re: ptest queue

Option 3 seems reasonable. I believe that used to be the state a while back (maybe 12 months back or so). When 2nd ptest for same jira runs, it checks if the latest patch has already been run. On Wed, Apr 25, 2018 at 7:37 AM, Peter Vary wrote: > I would vote for version 3.

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

privileges for the object and adds the newly granted privileges for it. - Thejas Nair On April 13, 2018, 10:30 p.m., Daniel Dai wrote: > > --- > This is an automaticall

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

/OracleDatabaseAccessor.java Lines 23 (patched) <https://reviews.apache.org/r/66571/#comment282154> Adding a prefix to it like "dummy_rownum_col_rn1938392" might help with debugging later! - Thejas Nair On April 13, 2018, 10:30 p.m.,

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

2916 (patched) <https://reviews.apache.org/r/66571/#comment282104> The syncrhonizer could be eventually moved to metastore as well. I think its better to name both synchronizer variables as "hive." instead of "hive.server2." - Thejas Nair On April 11, 20

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

discovery enabled ? We could assume that if HIVE_SERVER2_PRIVILEGE_SYNCHRONIZER=true and namespace is set, zookeeper is setup appropriately. service/src/java/org/apache/hive/service/server/HiveServer2.java Lines 905 (patched) <https://reviews.apache.org/r/66571/#comment282005> call variable authorizer (n

Re: Review Request 66571: HIVE-19161: Add authorizations to information schema

e/metastore/ObjectStore.java Lines 6108 (patched) <https://reviews.apache.org/r/66571/#comment281981> can you add a comment for this block (ie optimization done in that) ? - Thejas Nair On April 11,

Re: Review Request 66503: HIVE-19126: CachedStore: Use memory estimation to limit cache size during prewarm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66503/#review201041 --- Ship it! Ship It! - Thejas Nair On April 11, 2018, 10:53

Re: contributor role

Hi Antal, Are you referring to contributor role in Jira ? I think you should be able to assign jiras to yourself without that. ie, anyone with jira account should be equivalent to a contributor. Are you facing any issues with that ? Thanks, Thejas On Tue, Apr 10, 2018 at 9:52 AM, Antal

Re: Review Request 66503: HIVE-19126: CachedStore: Use memory estimation to limit cache size during prewarm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66503/#review200783 --- Ship it! Ship It! - Thejas Nair On April 10, 2018, 12:25

Re: Review Request 66503: HIVE-19126: CachedStore: Use memory estimation to limit cache size during prewarm

SizeVar(conf, ConfVars.LLAP_IO_MEMORY_MAX_SIZE); to get a type of size can you please check if MetastoreConf.getLongVar(conf, ConfVars.CACHED_RAW_STORE_MAX_CACHE_MEMORY) does the conversion to bytes ? - Thejas Nair On April 9, 2018, 10:42 p.m., Vaibhav Gu

Re: Review Request 66503: HIVE-19126: CachedStore: Use memory estimation to limit cache size during prewarm

iews.apache.org/r/66503/#comment281593> In master the Validator impls have been moved to separate classes (recent commit I suppose). Can yo u also please add SizeValidator as a seperate class ? - Thejas Nair On April 9, 2018, 9:57 a.m., Vaib

Re: Apache Hive 3.0.0 release preparation

That needs to be cleaned up. There are far too many right now, its just not handful of flaky tests. On Fri, Apr 6, 2018 at 2:48 AM, Peter Vary wrote: > Hi Team, > > I am new to the Hive release process and it is not clear to me how the > failing tests are handled. Do we

Re: Documenting standalone metastore

Sounds good to me. We have done something similar in past for HiveServer1 vs HiveServer2, ReplicationV1 vs V2 etc . On Mon, Apr 2, 2018 at 10:42 AM, Alan Gates wrote: > I've started looking at what will be required to document the new > standalone metastore. I started by

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

ween having two connection xml files which behave almost > > the same way. If its a hard requirement, I guess you can still do by > > defining a new key like you are doing currently for beeline-site.xml > > > > Is there a use-case which will not work in my suggestion

Re: [VOTE] Apache Hive 2.3.3 Release Candidate 0

+1 Verified signature & checksum of src and bin tar.gz. Build source and ran commands from binary. On Thu, Mar 29, 2018 at 4:37 PM, Alan Gates wrote: > +1. Did a build in an empty repo, ran rat, checked the key signature and > sha256, checked for any binary objects in the

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

he end ? If the application is in sequence by the jdbc driver, then we don't have to bother overriding it, the last values get picked up. (if jdbc driver already does that) - Thejas Nair On March 28, 2018, 8:27 p.m., Vaibhav Gumashta

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66185/ > --- > > (Updated March 28, 2018, 8:27 p.m.) > > > Review request for hive, Thejas Nair and Vihang Ka

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

156-157 (patched) <https://reviews.apache.org/r/66185/#comment280870> String host = getMergedProperty(userConnectionProperties, jdbcConnectionParams, HS2ConnectionFileParser.HOST_PROPERTY_KEY, null /*default value*/); would be enable code re-use between this and defaultDb value extraction.

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

156-157 (patched) <https://reviews.apache.org/r/66185/#comment280870> String host = getMergedProperty(userConnectionProperties, jdbcConnectionParams, HS2ConnectionFileParser.HOST_PROPERTY_KEY, null /*default value*/); would be enable code re-use between this and defaultDb value extraction.

Re: hive dist area questions

They are related to old CVEs. They provided a way to fix the security issue without having to upgrade Hive. We don't need them in the release mirrors as they are very old and and we have had several releases with the fixes. Owen and I discussed offline, and they been removed from main download

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

iews.apache.org/r/66185/#comment280184> A nit - Adding following method would keep this simpler/easier to read - getParsedUrlFromConfigFile(String filename) { return getParsedUrlFromConfigFile(filename, null); } Or perhaps another method for the named url case

Re: Hive 3.0 release

Hi Igor, For many of the steps in release management, you need to be a Hive committer. Thanks, Thejas On Tue, Mar 20, 2018 at 10:59 PM, Кривенко Ігор wrote: > Are there any requirements for being RM ? > May i be Release manager for 3.0? > > Thanks, > Igor Kryvenko > >

Re: Hive 3.0 release

+1 On Tue, Mar 20, 2018 at 4:46 PM, Ashutosh Chauhan wrote: > Hi all, > > It's almost a year since we branched off branch-2 Since then there are more > than 1700 commits which master has received. There are lots of new features > hidden in these commits. I think its about

Re: information_schema in metastore

INFORMATION_SCHEMA is part of the SQL92 standard. This is a feature supported and widely used in most mature RDBMs. The idea is to enable that for Hive as well. https://issues.apache.org/jira/browse/HIVE-1010 On Fri, Mar 2, 2018 at 10:59 AM, Vihang Karajgaonkar wrote: > I

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

/metastore/cache/CachedStore.java Line 292 (original), 200 (patched) <https://reviews.apache.org/r/65634/#comment278193> It would be more accurate to say "Processed " rather than "Cached " since the count includes tables that were skipped. - Thejas Nair On Feb. 13,

Re: reverting test-breaking changes

+1 I agree, this makes sense. The number of failures keeps increasing. A 24 hour heads up in either case before revert would be good. On Thu, Feb 22, 2018 at 2:45 AM, Peter Vary wrote: > I agree with Zoltan. The continuously braking tests make it very hard to > spot real

Re: Yetus JDK version

+ Peter, Adam (The Yetus experts) On Thu, Feb 1, 2018 at 9:49 AM, Alan Gates wrote: > Ok, looking briefly at it, it looks like if we changed > testutils/…/TestScripts.java line 76 to set javaHome to 1.8 instead of 1.7 > that we’ll be running ptest with 1.8. I’m not

Re: Review Request 65271: JDBC: Provide a way for JDBC users to pass cookie info via connection string

/HttpRequestInterceptorBase.java Line 91 (original), 96 (patched) <https://reviews.apache.org/r/65271/#comment276342> A nit - I think using "+=" is more readable for appends - cookieHeaderKeyValues += ";" + entry.getKey() + "=" + entry.getValue(); - T

Re: Branch for "Per Table Write ID" implementation

+1 Makes sense to split the changes into multiple smaller patches that are easier to review, and creating this branch would help with that. On Tue, Jan 9, 2018 at 10:55 PM, Sankar Hariappan < shariap...@hortonworks.com> wrote: > Hi all, > > "Hive Replication” feature is advancing to support

Re: Review Request 64925: HIVE-18349: Misc metastore changes for debuggability

/metastore/HiveMetaStore.java Lines 1635 (patched) <https://reviews.apache.org/r/64925/#comment273644> looks like this success boolean is not tracking success of commit. Exception is already being thrown from above stack. - Thejas Nair On Jan. 3, 2018, 8:09 p.m., Prasanth_J

Re: Review Request 64925: HIVE-18349: Misc metastore changes for debuggability

d from drop_table_..) - Thejas Nair On Jan. 3, 2018, 8:09 p.m., Prasanth_J wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

ng the old API does not handle the original > > exceptions differently than the TExceptions then it should work as > expected. > > > > > On Dec 14, 2017, at 10:50 PM, Thejas Nair <thejas.n...@gmail.com> > wrote: > > > > > > This direction looks good to

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

This direction looks good to me. If the new exceptions are inheriting from TException the applications would still work. But would it still work if we old metastore client library is used with a newer version of metastore server running with these changes ? On Wed, Dec 13, 2017 at 4:02 AM, Peter

Re: adding a label that would trigger HiveQA?

+1 It would be great if label could be added automatically and it gets removed after HiveQA run On Fri, Nov 10, 2017 at 5:05 PM, Sergey Shelukhin wrote: > Resubmitting the same patch for HiveQA as patches are constantly getting > dropped is getting old. > I wonder if we

Re: Integrating Yetus with Precommit job

+1 Yes, I think this can help us catch many issues early on, it will be very useful! On Mon, Nov 6, 2017 at 7:43 AM, Adam Szita wrote: > Hi all, > > As a next step of test subsystem improvements we would like to have the > Yetus check integrated with the ptest framework.

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189945 --- Ship it! Ship It! - Thejas Nair On Nov. 2, 2017, 6:25 p.m

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

ession/SessionManager.java Lines 508 (patched) <https://reviews.apache.org/r/63458/#comment267174> safer to check - if( connectionCount >= limit ) - Thejas Nair On Nov. 2, 2017, 8:08 a.m., Prasanth_J wrote: > > --- >

Re: Client compatibility for MetaStoreFilterHook

Hi Alex, Sorry about the delay in responding. I have replied in the jira. Thanks, Thejas On Mon, Oct 30, 2017 at 5:41 PM, Alexander Kolbasov wrote: > Looking at https://issues.apache.org/jira/browse/HIVE-9350 (Add ability > for > HiveAuthorizer implementations to filter

Re: Review Request 62695: HIVE-17649: Export/Import: Move export data write to a task

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62695/#review186914 --- Ship it! Ship It! - Thejas Nair On Oct. 2, 2017, 10:55 p.m

Re: Review Request 62695: HIVE-17649: Export/Import: Move export data write to a task

/TableExport.java Line 62 (original), 62 (patched) <https://reviews.apache.org/r/62695/#comment263781> can you also remove this member variable? - Thejas Nair On Oct. 2, 2017, 8:27 p.m., Vaibhav Gumashta wrote: > > --- > This is a

Re: [Announce] New committer: Sankar Hariappan

Congrats Sankar! On Fri, Sep 29, 2017 at 11:36 AM, Peter Vary wrote: > Congratulations Sankar! > > > On Sep 29, 2017, at 7:56 PM, Ashutosh Chauhan > wrote: > > > > The Project Management Committee (PMC) for Apache Hive has invited Sankar > > Harriapan

Re: [Announce] New committer: Anishek Agarwal

Congrats Anishek! On Fri, Sep 29, 2017 at 11:36 AM, Peter Vary wrote: > Congratulations Anishek! > > > On Sep 29, 2017, at 7:55 PM, Ashutosh Chauhan > wrote: > > > > The Project Management Committee (PMC) for Apache Hive has invited > Anishek > >

Re: Review Request 62695: HIVE-17649: Export/Import: Move export data write to a task

<https://reviews.apache.org/r/62695/#comment263533> the authEntitites computation can be skipped with this change. right ? - Thejas Nair On Sept. 29, 2017, 5:31 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically gener

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

.org/r/62373/#comment262479> why revert this approach of tracking the mapping using the hashmap ? That looks like more optimized route and cleaner as well. - Thejas Nair On Sept. 23, 2017, 7:53 a.m., Teddy Choi wrote: > > -

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

return. - Thejas Nair On Sept. 20, 2017, 9:24 a.m., Teddy Choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62373/ >

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

try { CuratorFramework zooKeeperClient = getZkClient(connParams); List serverHosts = getServerHosts(zooKeeperClient); .. .. - Thejas Nair On Sept. 20, 2017, 12:31 a.m., Teddy Choi wrote: > > --- > This is an automatica

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

che.org/r/62373/#comment262125> can you remove these whitespaces that show up as red - Thejas Nair On Sept. 20, 2017, 12:31 a.m., Teddy Choi wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

before it, as it is part of the setup for a specific zk node that got picked. - Thejas Nair On Sept. 20, 2017, 12:31 a.m., Teddy Choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

t.java Lines 633 (patched) <https://reviews.apache.org/r/62373/#comment262111> Add a comment that this is internal api to be used for testing ? You can use @VisibleForTesting annotation. - Thejas Nair On Sept. 19, 2017, 9:28 a.m.

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

e next line is quite obvious. itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java Lines 1473 (patched) <https://reviews.apache.org/r/62373/#comment262106> let the exception propogate to uncaughtexceptionhandler ? - Thejas Nair On Sept. 19,

Re: Review Request 62373: [HIVE-17483] HS2 kill command to kill queries using query id

ing a hashmap of queryid to operation will help with performance, and also the case of killing from same connection. - Thejas Nair On Sept. 18, 2017, 4:57 a.m., Teddy Choi wrote: > > --- > This is an automatically generated

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

/SharedCache.java Line 266 (original) <https://reviews.apache.org/r/59205/#comment248479> don't we need this removePartitionColStatsFromCache call ? - Thejas Nair On May 16, 2017, 8:10 a.m., Vaibhav Gumashta

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> On May 15, 2017, 8:19 a.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 281 (original), 284 (patched) > > <https://reviews.apache.org/r/59205/diff/2-5/?file=1717962#file1717962line285

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

atched) <https://reviews.apache.org/r/59205/#comment248226> isDatabaseCacheDirty.set(true); - this needs to be set after obtaining the lock Otherwise, you can have case where it gets reset by background thread before actual update. (Same with this call in other places) -

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59205/ > --- > > (Updated May 14, 2017, 5:19 a.m.) > > > Review request for hive, Daniel Dai and Thejas Nair

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017, 5:19 a.m.) > > > Review request for hive, Daniel Dai and Thejas Nair. > > > Bugs: HIVE-16579 > https://issues.apache.org/jira/browse/HIVE-16579 > > > Repository: hive-git > > > Description > --- > > https://issues.apache.org/jira/brow

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

from cache, if its there in cache. Otherwise, assume its not there (yet). This can be done as part of follow up jira if necessary. - Thejas Nair On May 14, 2017, 5:19 a.m., Vaibhav Gumashta wrote: > > --- > This is an automatically

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

/MetaStoreDirectSql.java Lines 1387 (patched) <https://reviews.apache.org/r/59205/#comment248174> There is no order-by in the SQL query above. Is it guaranteed that the list is ordered ? Should we add a "order by" to above SQL query ? - Thejas Nair On May 14, 2017, 5:19 a.m., Vaibha

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

906 (original), 906 (patched) <https://reviews.apache.org/r/59205/#comment248058> Lets keep default time in seconds, just as before. - Thejas Nair On May 11, 2017, 9:07 p.m., Vaibhav Gumashta wrote: > > --- > This is a

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 0

I meant to say +1 to fixing HIVE-16577 before release. On Thu, May 4, 2017 at 6:43 PM, Thejas Nair <thejas.n...@gmail.com> wrote: > +1. Yes, we should fix HIVE-16577 > > On Wed, May 3, 2017 at 12:37 PM, Vihang Karajgaonkar <vih...@cloudera.com> > wrote: > >>

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 0

+1. Yes, we should fix HIVE-16577 On Wed, May 3, 2017 at 12:37 PM, Vihang Karajgaonkar wrote: > I think we need to fix HIVE-16577 before releasing 2.3.0. The metastore > schema initialization script for mssql is broken since 2.2.0. > > Also, I noticed that JIRA shows 2.2.0

Re: ptest not running?

he.org/jira/browse/INFRA-13985 > > On Tue, Apr 25, 2017 at 11:54 AM, Thejas Nair <thejas.n...@gmail.com> > wrote: > > > Looks like nothing is getting scheduled since yesterday evening, even > with > > the manual launch > > > > https://builds.apache.org/j

Re: ptest not running?

Looks like nothing is getting scheduled since yesterday evening, even with the manual launch https://builds.apache.org/job/PreCommit-HIVE-Build/ Can someone with access please take a look ? On Mon, Apr 24, 2017 at 5:26 PM, Eugene Koifman wrote: > Something is not

Re: [VOTE] Apache Hive 1.2.2 Release Candidate 0

+1 (binding) - Verified signature and checksum - Build from source - Ran simple queries in local mode with binary tar.gz - Checked RELEASE_NOTES file. Traditionally this file has had the set of patches fixed in previous releases as well ( ie, each new release was adding entries to the top of the

Re: [DISCUSS] split metastore and service

Also, thanks for the email thread to bring peoples attention to this change. On Tue, Mar 28, 2017 at 6:35 PM, Thejas Nair <thejas.n...@gmail.com> wrote: > +1 > Thanks for looking into this! > > > On Tue, Mar 28, 2017 at 11:26 AM, Eugene Koifman <ekoif...@hortonworks.com &

Re: [DISCUSS] split metastore and service

+1 Thanks for looking into this! On Tue, Mar 28, 2017 at 11:26 AM, Eugene Koifman wrote: > +1 reduce the number of uber jars > > > On 3/27/17, 1:05 PM, "Sergey Shelukhin" wrote: > > Splitting the metastore would also allow us to get rid of

Re: Backward incompatible changes

+1 There are some features that are incomplete and what I would not recommend for any real production use.The 'legacy authorization mode' is a great example of that - https://cwiki.apache.org/confluence/display/Hive/Hive+Default+Authorization+-+Legacy+Mode . It is inherently insecure mode that

Re: [VOTE] Drop support for Java7 in master branch

/access.redhat.com/articles/1299013 > > .. Owen > > On Tue, Feb 28, 2017 at 10:49 AM, Siddharth Seth <ss...@apache.org> wrote: > > > +1 > > > > On Mon, Feb 27, 2017 at 8:54 PM, Thejas Nair <thejas.n...@gmail.com> > > wrote: > > > >

Re: [VOTE] Drop support for Java7 in master branch

t; rajat.khandel...@inmobi.com> wrote: > > > +1 > > > > On Tue, Feb 28, 2017 at 10:37 AM, Prasanth Jayachandran < > > pjayachand...@hortonworks.com> wrote: > > > > > +1 > > > > > > Thanks > > > Prasanth >

[VOTE] Drop support for Java7 in master branch

There was a [DISCUSS] thread on the topic of moving to jdk8 for unit tests [1], and many people also expressed the opinion that we should drop JDK 7 support in Hive. Public updates by Oracle was stopped on Apr 2015 [2]. This vote thread proposes to dropping JDK 7 support in the next Apache Hive

Re: Precommit jenkins is failing

+ Sergio, Any idea what might be causing this ? Will you be able to take a look ? On Mon, Jan 16, 2017 at 12:42 PM, Deepak Jaiswal wrote: > Is there anyone who is looking into this? > > On 1/13/17, 10:46 AM, "Wei Zheng" wrote: > > [INFO]

Re: [DISCUSS] Separate release of storage-api

+1 I agree that using an independent version number for this release is the better option. Regarding the mapping, I see it like a dependency on a third party library. Its based on what is in the pom.xml . On Wed, Jan 11, 2017 at 9:36 AM, Alan Gates wrote: > 90% of the

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review160177 --- Ship it! Ship It! - Thejas Nair On Dec. 27, 2016, 4:44 p.m

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

.java (line 172) <https://reviews.apache.org/r/54826/#comment231176> trailing whitespaces metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 232) <https://reviews.apache.org/r/54826/#comment231167> check for DEBUG enabled, but logging is at INF

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java (line 225) <https://reviews.apache.org/r/54826/#comment230775> can you add a debug level log message for when files get deleted ? - Thejas Nair On Dec. 16, 2016, 11:14 p.m., Daniel Dai wrote: > > ---

Re: Review Request 54771: Capture additional metadata to replicate a simple insert at destination

/listener/TestDbNotificationListener.java (line 1206) <https://reviews.apache.org/r/54771/#comment230671> can you add a verifyInsertJSON method or so ? looks like we can avoid the many repeating lines that way. - Thejas Nair On Dec. 19, 2016, 5:30 p.m., Vaibhav Gumashta

Re: Review Request 54771: Capture additional metadata to replicate a simple insert at destination

/InsertEvent.java (line 52) <https://reviews.apache.org/r/54771/#comment230420> do we still need the old constructor ? - Thejas Nair On Dec. 15, 2016, 9:55 a.m., Vaibhav Gumashta wrote: > > --- > This is an automatically g

Re: Review Request 54771: Capture additional metadata to replicate a simple insert at destination

p, then the size will be non zero and there will be a mismatch. - Thejas Nair On Dec. 15, 2016, 9:55 a.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [VOTE] Apache Hive 2.1.1 Release Candidate 1

+1 (Looks like I have the final word! :) ) Verified checksum and signature for both packages. Build from source and ran some simple queries. Also examined LICENSE, NOTICE, and RELEASE_NOTES files. I see that the RELEASE_NOTES file this time contains only the changes in latest release, in the past

Re: [VOTE] Apache Hive 2.1.1 Release Candidate 0

ice, since we fall in the temporary exclusion > period? > > *This project includes software licensed under the JSON license.* > > -- > Jesús > > > > > > > On 11/29/16, 9:39 AM, "Thejas Nair" <thejas.n...@gmail.com> wrote: > > >This is the right li

Re: [VOTE] Apache Hive 2.1.1 Release Candidate 0

This is the right link - http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201611.mbox/%3C0CE2E8C9-D9B7-404D-93EF-A1F8B07189BF%40apache.org%3E On Tue, Nov 29, 2016 at 12:29 AM, Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > I am cancelling the vote then. > >

Re: Review Request 53915: Extend JSONMessageFactory to store additional information about metadata objects on different table events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53915/#review156688 --- Ship it! Ship It! - Thejas Nair On Nov. 22, 2016, 11:02 p.m

  1   2   3   4   5   6   7   8   9   >