[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-08 Thread Namit Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969562#action_12969562
 ] 

Namit Jain commented on HIVE-1837:
--

OK, the changes look good.

+1

 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-07 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969000#action_12969000
 ] 

Ashutosh Chauhan commented on HIVE-1837:


You get this feature for free when you move to secure Hadoop. A mapreduce job 
by default gets a token which expires in 24 hrs. So, usually MR job spawned by 
Hive query will fail after that time. Job may request renewal upto 7 days. 
Beyond that, special provisions are required. So, timeout is inherently built 
into secure hadoop.

 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-07 Thread Namit Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969093#action_12969093
 ] 

Namit Jain commented on HIVE-1837:
--

@Ashutosh, we cant wait for this feature till secure hadoop is available.
Once Hive is migrated to that, we can change the implementation of this feature.

@Yongqiang, can you add the new parameter definition in hive-default.xml ?
Also, can you make the thread sleep time (10 min.) configurable ?
Can you add a new test for the same - I mean, have a very small timeout and 
thread sleep time,
and a custom script which is sleeping indefinitely ? 



 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-07 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969141#action_12969141
 ] 

He Yongqiang commented on HIVE-1837:


it is still very difficult to add a testcase. It's because there is a 
System.exit(-1) in the monitor thread. The test process will exit.

 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-07 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969146#action_12969146
 ] 

Ashutosh Chauhan commented on HIVE-1837:


One way to get around System.exit() problem in testcase is to create your own 
SecurityManager and use that. In your SecurityManager override checkExit() and 
throw an exception. This way whenever System.exit() is encountered, an 
exception will be thrown. In your testcase you can catch the exception and then 
do the asserts that you want. I did very similar things while writing junit 
tests for Howl. 

 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1837) optional timeout for hive clients

2010-12-07 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969151#action_12969151
 ] 

He Yongqiang commented on HIVE-1837:


Cool, Thanks Ashutosh! I will try that.

 optional timeout for hive clients
 -

 Key: HIVE-1837
 URL: https://issues.apache.org/jira/browse/HIVE-1837
 Project: Hive
  Issue Type: New Feature
Reporter: Namit Jain
Assignee: He Yongqiang
 Attachments: hive-1837.1.patch, hive-1837.2.patch


 It would be a good idea to have a optional timeout for hive clients.
 We encountered a query today, which seemed to have run by mistake, and it was 
 running for about a month.
 This was holding zookeeper locks, and making the whole debugging more complex 
 than it should be.
 It would be a good idea to have a timeout for a hive client.
 @Ning, I remember there was some issue with the Hive client having a timeout 
 of 1 day with HiPal.
 Do you remember the details ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.