Re: Review Request 31209: HIVE-9727

2015-03-26 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31209/#review77923
---

Ship it!


Ship It!

- John Pullokkaran


On March 6, 2015, 9:20 p.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31209/
 ---
 
 (Updated March 6, 2015, 9:20 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9727
 https://issues.apache.org/jira/browse/HIVE-9727
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 GroupingID translation from Calcite
 
 
 Diffs
 -
 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
  345b64af8514466c84e9899e9c019b679b761ba6 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
  ea5918110fa1255f105c646c08e7d307afb3f94b 
   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
 47a209f4d79fb4d73f8bd69f8edc18cd834bf940 
 
 Diff: https://reviews.apache.org/r/31209/diff/
 
 
 Testing
 ---
 
 Existing tests (groupby*.q)
 
 
 Thanks,
 
 Jesús Camacho Rodríguez
 




Re: Review Request 31209: HIVE-9727

2015-03-06 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31209/
---

(Updated March 6, 2015, 9:20 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9727
https://issues.apache.org/jira/browse/HIVE-9727


Repository: hive-git


Description
---

GroupingID translation from Calcite


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
 345b64af8514466c84e9899e9c019b679b761ba6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 ea5918110fa1255f105c646c08e7d307afb3f94b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
47a209f4d79fb4d73f8bd69f8edc18cd834bf940 

Diff: https://reviews.apache.org/r/31209/diff/


Testing
---

Existing tests (groupby*.q)


Thanks,

Jesús Camacho Rodríguez



Re: Review Request 31209: HIVE-9727

2015-02-20 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31209/
---

(Updated Feb. 20, 2015, 7:42 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9727
https://issues.apache.org/jira/browse/HIVE-9727


Repository: hive-git


Description
---

GroupingID translation from Calcite


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
 345b64af8514466c84e9899e9c019b679b761ba6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 ea5918110fa1255f105c646c08e7d307afb3f94b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
47a209f4d79fb4d73f8bd69f8edc18cd834bf940 

Diff: https://reviews.apache.org/r/31209/diff/


Testing
---

Existing tests (groupby*.q)


Thanks,

Jesús Camacho Rodríguez



Review Request 31209: HIVE-9727

2015-02-19 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31209/
---

Review request for hive and John Pullokkaran.


Bugs: HIVE-9727
https://issues.apache.org/jira/browse/HIVE-9727


Repository: hive-git


Description
---

GroupingID translation from Calcite


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
 345b64af8514466c84e9899e9c019b679b761ba6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 ea5918110fa1255f105c646c08e7d307afb3f94b 

Diff: https://reviews.apache.org/r/31209/diff/


Testing
---

Existing tests (groupby*.q)


Thanks,

Jesús Camacho Rodríguez