Re: Review Request 69215: HIVE-20778 Join reordering may not be triggered if all joins in plan are created by decorrelation logic

2018-11-01 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69215/#review210257
---


Ship it!




Ship It!

- Jesús Camacho Rodríguez


On Oct. 30, 2018, 5:28 p.m., Vineet Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69215/
> ---
> 
> (Updated Oct. 30, 2018, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-20778
> https://issues.apache.org/jira/browse/HIVE-20778
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Trigger join reordering for subqueries
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 82e975a50d 
>   ql/src/test/queries/clientpositive/subquery_notin.q a2d93dfd86 
>   ql/src/test/queries/clientpositive/subquery_select.q 80618c777b 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out d106cd325a 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out 
> 801416d563 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out f240468558 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out 9bec309c9c 
>   ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out ac505a5c1e 
>   ql/src/test/results/clientpositive/llap/optimize_join_ptp.q.out a68275b9e9 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out 12e8c54480 
>   ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 4f41f246f1 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out d8d42ee10b 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out d981733bd3 
>   ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out fab963b1fd 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 166bd60ce2 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 854d215a23 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out a0bc64ebf1 
>   ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 
> a9180bcdc6 
>   ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out 
> 3b8ee96a40 
>   ql/src/test/results/clientpositive/semijoin5.q.out c047c6d265 
>   
> ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_3.q.out
>  c2d821d653 
>   ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 
> f5a4c9ad86 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 535f01b1fd 
>   ql/src/test/results/clientpositive/spark/subquery_multi.q.out 5f7b2661fa 
>   ql/src/test/results/clientpositive/spark/subquery_notin.q.out 39080da5c9 
>   ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 0fefcbe408 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out b3252f5415 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out ad7c8a3fc7 
>   ql/src/test/results/clientpositive/spark/subquery_views.q.out 8a7e4c7d18 
>   ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 
> 9f80711c65 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out dd31d4ab6a 
>   ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 70cdd7ae5b 
> 
> 
> Diff: https://reviews.apache.org/r/69215/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>



Review Request 69215: HIVE-20778 Join reordering may not be triggered if all joins in plan are created by decorrelation logic

2018-10-30 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69215/
---

Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.


Bugs: HIVE-20778
https://issues.apache.org/jira/browse/HIVE-20778


Repository: hive-git


Description
---

Trigger join reordering for subqueries


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 82e975a50d 
  ql/src/test/queries/clientpositive/subquery_notin.q a2d93dfd86 
  ql/src/test/queries/clientpositive/subquery_select.q 80618c777b 
  ql/src/test/results/clientpositive/constant_prop_3.q.out d106cd325a 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out 
801416d563 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out f240468558 
  ql/src/test/results/clientpositive/llap/lineage3.q.out 9bec309c9c 
  ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out ac505a5c1e 
  ql/src/test/results/clientpositive/llap/optimize_join_ptp.q.out a68275b9e9 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 12e8c54480 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 4f41f246f1 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out d8d42ee10b 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out d981733bd3 
  ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out fab963b1fd 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 166bd60ce2 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 854d215a23 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out a0bc64ebf1 
  ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 
a9180bcdc6 
  ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out 
3b8ee96a40 
  ql/src/test/results/clientpositive/semijoin5.q.out c047c6d265 
  
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_3.q.out
 c2d821d653 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out f5a4c9ad86 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 535f01b1fd 
  ql/src/test/results/clientpositive/spark/subquery_multi.q.out 5f7b2661fa 
  ql/src/test/results/clientpositive/spark/subquery_notin.q.out 39080da5c9 
  ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 0fefcbe408 
  ql/src/test/results/clientpositive/spark/subquery_scalar.q.out b3252f5415 
  ql/src/test/results/clientpositive/spark/subquery_select.q.out ad7c8a3fc7 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 8a7e4c7d18 
  ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 
9f80711c65 
  ql/src/test/results/clientpositive/subquery_notin_having.q.out dd31d4ab6a 
  ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 70cdd7ae5b 


Diff: https://reviews.apache.org/r/69215/diff/1/


Testing
---


Thanks,

Vineet Garg