Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-14 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72499/ --- (Updated May 14, 2020, 7:14 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-14 Thread Rajesh Balamohan
> On May 14, 2020, 4:31 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > > Lines 646-651 (patched) > > > > > > Is this logic needed? You

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-14 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72499/ --- (Updated May 14, 2020, 7:09 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-13 Thread Ashutosh Chauhan
> On May 14, 2020, 4:31 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > > Lines 610 (patched) > > > > > > What's the reason for time based

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-13 Thread Rajesh Balamohan
> On May 14, 2020, 4:31 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > > Lines 638 (patched) > > > > > > Bound this queue by number of

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-13 Thread Rajesh Balamohan
> On May 14, 2020, 4:31 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > > Lines 610 (patched) > > > > > > What's the reason for time based

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-13 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72499/#review220748 ---

Re: Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-12 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72499/ --- (Updated May 12, 2020, 12:06 p.m.) Review request for hive, Ashutosh Chauhan

Review Request 72499: HIVE-23446:LLAP: Reduce IPC connection misses to AM for short queries

2020-05-12 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72499/ --- Review request for hive, Ashutosh Chauhan and Gopal V. Bugs: HIVE-23446