[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547919#comment-13547919
]
Hudson commented on HIVE-3126:
--
Integrated in Hive-trunk-hadoop2 #54 (See
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422323#comment-13422323
]
Hudson commented on HIVE-3126:
--
Integrated in Hive-trunk-h0.21 #1567 (See
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421569#comment-13421569
]
Kanna Karanam commented on HIVE-3126:
-
@Carl, @Ashutosh - can you please review the
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421853#comment-13421853
]
Ashutosh Chauhan commented on HIVE-3126:
@Kanna: Thanks, Kanna. I will take a look.
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421895#comment-13421895
]
Carl Steinbach commented on HIVE-3126:
--
Looks good to me. Kanna, thanks for making all
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421913#comment-13421913
]
Ashutosh Chauhan commented on HIVE-3126:
+1 Will commit if tests pass.
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421947#comment-13421947
]
Kanna Karanam commented on HIVE-3126:
-
Thanks Ashutosh, Carl. This JIRA helps
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418816#comment-13418816
]
Kanna Karanam commented on HIVE-3126:
-
@Carl – I added some follow up comments. can you
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418064#comment-13418064
]
Ashutosh Chauhan commented on HIVE-3126:
Changes look good to me. Carl, do you have
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413450#comment-13413450
]
Ashutosh Chauhan commented on HIVE-3126:
[~kanna...@microsoft.com] : I left some
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413448#comment-13413448
]
Hudson commented on HIVE-3126:
--
Integrated in Hive-trunk-h0.21 #1539 (See
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413455#comment-13413455
]
Ashutosh Chauhan commented on HIVE-3126:
Looks like I referenced wrong jura-id in
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407492#comment-13407492
]
Kanna Karanam commented on HIVE-3126:
-
@Carl. Please let me know if you have any
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402890#comment-13402890
]
Carl Steinbach commented on HIVE-3126:
--
@Kanna: I added some more comments on
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402370#comment-13402370
]
Kanna Karanam commented on HIVE-3126:
-
Updated the patch after addressing most of the
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401554#comment-13401554
]
Kanna Karanam commented on HIVE-3126:
-
@Carl- I am still investigating some unit test
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400188#comment-13400188
]
Kanna Karanam commented on HIVE-3126:
-
Code review request is at
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400282#comment-13400282
]
Kanna Karanam commented on HIVE-3126:
-
Thanks Carl. I will look into it.
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399738#comment-13399738
]
Carl Steinbach commented on HIVE-3126:
--
@Kanna: Please create a review request.
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393554#comment-13393554
]
Edward Capriolo commented on HIVE-3126:
---
Will tests generated on windows run on linux
[
https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393657#comment-13393657
]
Kanna Karanam commented on HIVE-3126:
-
Hi Edward – It is a good point. Hive development
21 matches
Mail list logo