[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944236#comment-13944236
]
Lefty Leverenz commented on HIVE-3501:
--
For the record: This adds
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468662#comment-13468662
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
Thanks Carl. Please let me know
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469133#comment-13469133
]
Namit Jain commented on HIVE-3501:
--
@Carl, let me know if you are swamped with other
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467523#comment-13467523
]
Carl Steinbach commented on HIVE-3501:
--
+1. Will commit if tests pass.
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467931#comment-13467931
]
Carl Steinbach commented on HIVE-3501:
--
@Sambavi: Please change the status of this
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467943#comment-13467943
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
Oops sorry. Just hit submit
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468145#comment-13468145
]
Carl Steinbach commented on HIVE-3501:
--
@Sambavi: I'm a little behind schedule on
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467312#comment-13467312
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
Updated code review and patch
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467446#comment-13467446
]
Namit Jain commented on HIVE-3501:
--
very minor comment ?
Otherwise, looks good.
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467460#comment-13467460
]
Carl Steinbach commented on HIVE-3501:
--
I added a couple minor comments too. Looks
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467482#comment-13467482
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
Thanks for the feedback, updated
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466534#comment-13466534
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
Fixed for review comments.
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466537#comment-13466537
]
Namit Jain commented on HIVE-3501:
--
[~sambavi], is it ready for review ?
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466539#comment-13466539
]
Namit Jain commented on HIVE-3501:
--
comments on phabricator.
Track table
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465913#comment-13465913
]
Kevin Wilfong commented on HIVE-3501:
-
One last comment on the diff, otherwise looks
[
https://issues.apache.org/jira/browse/HIVE-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461615#comment-13461615
]
Sambavi Muthukrishnan commented on HIVE-3501:
-
16 matches
Mail list logo