[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638130#comment-13638130 ] Hudson commented on HIVE-4130: -- Integrated in Hive-trunk-hadoop2 #169 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/169/]) HIVE-4130 : Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs (Harish Butani via Ashutosh Chauhan) (Revision 1470312) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1470312 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java * /hive/trunk/ql/src/test/queries/clientpositive/windowing_expressions.q * /hive/trunk/ql/src/test/results/clientpositive/windowing_expressions.q.out Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.12.0 Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch, HIVE-4130.D10233.3.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638590#comment-13638590 ] Hudson commented on HIVE-4130: -- Integrated in Hive-trunk-h0.21 #2074 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2074/]) HIVE-4130 : Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs (Harish Butani via Ashutosh Chauhan) (Revision 1470312) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1470312 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java * /hive/trunk/ql/src/test/queries/clientpositive/windowing_expressions.q * /hive/trunk/ql/src/test/results/clientpositive/windowing_expressions.q.out Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.12.0 Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch, HIVE-4130.D10233.3.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637308#comment-13637308 ] Ashutosh Chauhan commented on HIVE-4130: [~rhbutani] There are few minor comments on this jira. If you have time and can take a look at it that will be great. It wil be good to include this in 0.11 Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637483#comment-13637483 ] Phabricator commented on HIVE-4130: --- ashutoshc has accepted the revision HIVE-4130 [jira] Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs. +1 will commit if tests pass REVISION DETAIL https://reviews.facebook.net/D10233 BRANCH HIVE-4130 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch, HIVE-4130.D10233.3.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632928#comment-13632928 ] Phabricator commented on HIVE-4130: --- ashutoshc has requested changes to the revision HIVE-4130 [jira] Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs. Couple more comments. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:98 Shouldn't the default value of amt be 1 ? ql/src/test/queries/clientpositive/windowing_expressions.q:38 It will be good to add a testcase which exercises non-default values like sum(lag(p_retailprice,3,29.43)) REVISION DETAIL https://reviews.facebook.net/D10233 BRANCH HIVE-4130 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
[ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631911#comment-13631911 ] Phabricator commented on HIVE-4130: --- ashutoshc has requested changes to the revision HIVE-4130 [jira] Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs. Mostly looks good. Some comments. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:60 This catch block is no longer required I think. Now that we ascertain arguments.length 1 there cant be NPE here. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:66 Bit confused here. In case of this exception, isnt it better to just throw exception, instead of setting amt to max. What do you think? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:113 This can be removed. We have same code down below. REVISION DETAIL https://reviews.facebook.net/D10233 BRANCH HIVE-4130 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs - Key: HIVE-4130 URL: https://issues.apache.org/jira/browse/HIVE-4130 Project: Hive Issue Type: Bug Components: PTF-Windowing Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-4130.D10233.1.patch - support a default value arg - both amt and defaultValue args can be optional -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
