[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052196#comment-14052196
]
Lefty Leverenz commented on HIVE-4209:
--
*hive.cache.expr.evaluation* is documented in the wiki here:
* [Configuration Properties -- hive.cache.expr.evaluation |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.cache.expr.evaluation]
I also added a comment to HIVE-6586 explaining that the current patch for
HIVE-6037 (HIVE-6037-0.13.0) truncates the description of
*hive.cache.expr.evaluation*.
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Fix For: 0.12.0
Attachments: HIVE-4209.6.patch.txt, HIVE-4209.D9585.1.patch,
HIVE-4209.D9585.2.patch, HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch,
HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653381#comment-13653381
]
Hudson commented on HIVE-4209:
--
Integrated in Hive-trunk-h0.21 #2094 (See
[https://builds.apache.org/job/Hive-trunk-h0.21/2094/])
HIVE-4209 Cache evaluation result of deterministic expression and reuse it
(Navis via namit) (Revision 1480597)
Result = FAILURE
navis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1480597
Files :
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/conf/hive-default.xml.template
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorHead.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorRef.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeNullEvaluator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Fix For: 0.12.0
Attachments: HIVE-4209.6.patch.txt, HIVE-4209.D9585.1.patch,
HIVE-4209.D9585.2.patch, HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch,
HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647155#comment-13647155
]
Navis commented on HIVE-4209:
-
[~namit] Running test, my notebook has shutdown twice by overheat. Recent cool
patches seemed added some hot tests. Might take some more time.
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.6.patch.txt, HIVE-4209.D9585.1.patch,
HIVE-4209.D9585.2.patch, HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch,
HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13645175#comment-13645175
]
Namit Jain commented on HIVE-4209:
--
Thanks [~navis]
Looks good. Can you commit it if tests pass ?
+1
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.6.patch.txt, HIVE-4209.D9585.1.patch,
HIVE-4209.D9585.2.patch, HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch,
HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13645176#comment-13645176
]
Phabricator commented on HIVE-4209:
---
njain has accepted the revision HIVE-4209 [jira] Cache evaluation result of
deterministic expression and reuse it.
REVISION DETAIL
https://reviews.facebook.net/D9585
BRANCH
HIVE-4209
ARCANIST PROJECT
hive
To: JIRA, njain, navis
Cc: njain
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.6.patch.txt, HIVE-4209.D9585.1.patch,
HIVE-4209.D9585.2.patch, HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch,
HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13641556#comment-13641556
]
Namit Jain commented on HIVE-4209:
--
Can you refresh one more time - sorry, the parallel test framework is not
applying the patch cleanly.
? conf/hive-default.xml.template.orig
M conf/hive-default.xml.template
? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java.orig
M common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java
A +ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorHead.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeNullEvaluator.java
A +ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorRef.java
M
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java
M
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java
M ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java
M ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
Can you rebase the patch so that there no +, the patch does not apply cleanly
in that case.
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.D9585.1.patch, HIVE-4209.D9585.2.patch,
HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch, HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642502#comment-13642502
]
Navis commented on HIVE-4209:
-
[~namit] I've made some classes from the copy of other, which seemed to make
problems. I think I should remake the branch. (same on HIVE-3781)
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.D9585.1.patch, HIVE-4209.D9585.2.patch,
HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch, HIVE-4209.D9585.5.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640354#comment-13640354
]
Phabricator commented on HIVE-4209:
---
njain has commented on the revision HIVE-4209 [jira] Cache evaluation result
of deterministic expression and reuse it.
Can you change the default to true ?
In hive-default.xml.template, can you explain the types of
queries/expressions that will benefit
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:638 Can you explain
this new parameter in hive-default.xml.template ?
REVISION DETAIL
https://reviews.facebook.net/D9585
To: JIRA, navis
Cc: njain
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.D9585.1.patch, HIVE-4209.D9585.2.patch,
HIVE-4209.D9585.3.patch, HIVE-4209.D9585.4.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4209) Cache evaluation result of deterministic expression and reuse it
[
https://issues.apache.org/jira/browse/HIVE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608650#comment-13608650
]
Navis commented on HIVE-4209:
-
Applied to SEL and FIL operator. Running test.
Cache evaluation result of deterministic expression and reuse it
Key: HIVE-4209
URL: https://issues.apache.org/jira/browse/HIVE-4209
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-4209.D9585.1.patch
For example,
{noformat}
select key from src where key + 1 100 AND key + 1 200 limit 3;
{noformat}
key + 1 need not to be evaluated twice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
