[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896303#comment-13896303
]
Justin Coffey commented on HIVE-5783:
-
Thanks to all, and especially [~brocknoland] for
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897020#comment-13897020
]
Brock Noland commented on HIVE-5783:
Note: Although I don't believe JIRA will allow us
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895499#comment-13895499
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895737#comment-13895737
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895782#comment-13895782
]
Xuefu Zhang commented on HIVE-5783:
---
I believe that the above failed test is flaky, and
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13894366#comment-13894366
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893949#comment-13893949
]
Xuefu Zhang commented on HIVE-5783:
---
It seems two things are needed in order to commit
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893993#comment-13893993
]
Brock Noland commented on HIVE-5783:
Thanks Xuefu, I am updating the patch.
I will
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893999#comment-13893999
]
Xuefu Zhang commented on HIVE-5783:
---
[~brocknoland] Thanks for sharing the link. It's
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893997#comment-13893997
]
Brock Noland commented on HIVE-5783:
I attached the updated patch with and without
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892391#comment-13892391
]
Xuefu Zhang commented on HIVE-5783:
---
+1 to the latest patch.
Native Parquet Support in
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890845#comment-13890845
]
Brock Noland commented on HIVE-5783:
FYI I created HIVE-6368 to document Parquet in
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890952#comment-13890952
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890969#comment-13890969
]
Brock Noland commented on HIVE-5783:
Those failures shouldn't be related, but
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891105#comment-13891105
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891114#comment-13891114
]
Brock Noland commented on HIVE-5783:
I am able to produce that failure myself so I am
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891260#comment-13891260
]
Xuefu Zhang commented on HIVE-5783:
---
I left two minor comments on RB.
Native Parquet
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891276#comment-13891276
]
Brock Noland commented on HIVE-5783:
Thank you Xuefu! I had a question about one of
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891881#comment-13891881
]
Hive QA commented on HIVE-5783:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889509#comment-13889509
]
Brock Noland commented on HIVE-5783:
That test failure is unrelated to the patch.
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890138#comment-13890138
]
Xuefu Zhang commented on HIVE-5783:
---
Some comments are posted on RB.
Native Parquet
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890146#comment-13890146
]
Brock Noland commented on HIVE-5783:
Thanks Xuefu. Justin, I can address these items
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887447#comment-13887447
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886117#comment-13886117
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882350#comment-13882350
]
Brock Noland commented on HIVE-5783:
Those failures are covered by HIVE-6293.
Native
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882125#comment-13882125
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881208#comment-13881208
]
Brock Noland commented on HIVE-5783:
Uploaded the latest patch rebased on trunk.
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881418#comment-13881418
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881424#comment-13881424
]
Brock Noland commented on HIVE-5783:
Those tests failed due to HIVE-5728 (which was
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881624#comment-13881624
]
Carl Steinbach commented on HIVE-5783:
--
I noticed that this SerDe doesn't support
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879960#comment-13879960
]
Justin Coffey commented on HIVE-5783:
-
We have unfortunately found a bug in
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879972#comment-13879972
]
Brock Noland commented on HIVE-5783:
Thank you for the report Justin!
Native Parquet
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877345#comment-13877345
]
Lefty Leverenz commented on HIVE-5783:
--
What documentation will this need? Is
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877485#comment-13877485
]
Hive QA commented on HIVE-5783:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877509#comment-13877509
]
Justin Coffey commented on HIVE-5783:
-
[~leftylev], if you'd like I can give this a
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877610#comment-13877610
]
Brock Noland commented on HIVE-5783:
[~leftylev], good call.
I think we should create
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876712#comment-13876712
]
Justin Coffey commented on HIVE-5783:
-
Sorry for the spam in posts. Latest patch is
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876922#comment-13876922
]
Brock Noland commented on HIVE-5783:
Thank you very much Justin!! I have rebased the
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876924#comment-13876924
]
Brock Noland commented on HIVE-5783:
RB item has been updated:
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877171#comment-13877171
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877178#comment-13877178
]
Brock Noland commented on HIVE-5783:
Failure was unrelated to the current patch:
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875930#comment-13875930
]
Justin Coffey commented on HIVE-5783:
-
Hi [~cwsteinbach]. Actually, that looks like
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874626#comment-13874626
]
Justin Coffey commented on HIVE-5783:
-
After much delay, here is the patch. This
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874655#comment-13874655
]
Remus Rusanu commented on HIVE-5783:
[~jcoffey]: can you add a reviewboard link? ty
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874666#comment-13874666
]
Justin Coffey commented on HIVE-5783:
-
[~rusanu]: like so?
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874905#comment-13874905
]
Brock Noland commented on HIVE-5783:
Awesome, thank you very much guys!
Native
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875122#comment-13875122
]
Brock Noland commented on HIVE-5783:
RB link: https://reviews.apache.org/r/17061/
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875208#comment-13875208
]
Brock Noland commented on HIVE-5783:
When we commit this change we need to give credit
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875419#comment-13875419
]
Carl Steinbach commented on HIVE-5783:
--
I noticed that many of the source files
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875572#comment-13875572
]
Remus Rusanu commented on HIVE-5783:
[~cwsteinbach] I have no say in this, I'm not
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851661#comment-13851661
]
Justin Coffey commented on HIVE-5783:
-
Yes this is true. We are refactoring to merge
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850557#comment-13850557
]
Brock Noland commented on HIVE-5783:
Thanks Resmus for creating HIVE-5998.
Eric, I
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846797#comment-13846797
]
Eric Hanson commented on HIVE-5783:
---
Could somebody put the patch on ReviewBoard? That's
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844116#comment-13844116
]
Justin Coffey commented on HIVE-5783:
-
[~cwsteinbach] all sounds good. Regarding test
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844212#comment-13844212
]
Remus Rusanu commented on HIVE-5783:
If Parquet native goes in, is a perfect candidate
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843425#comment-13843425
]
Justin Coffey commented on HIVE-5783:
-
Hi [~cwsteinbach], so on the parquet-hive side,
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843428#comment-13843428
]
Justin Coffey commented on HIVE-5783:
-
(sorry, errant trackpad submit on the last
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843432#comment-13843432
]
Brock Noland commented on HIVE-5783:
bq. we're good to submit a new patch with direct
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843444#comment-13843444
]
Brock Noland commented on HIVE-5783:
bq. I would actually like to that up that change
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843918#comment-13843918
]
Carl Steinbach commented on HIVE-5783:
--
bq. on the parquet-hive side, we're good to
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842562#comment-13842562
]
Brock Noland commented on HIVE-5783:
Hi Carl,
FWIW I discussed this with the Parquet
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842804#comment-13842804
]
Carl Steinbach commented on HIVE-5783:
--
[~brocknoland] Up to this point we have
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841601#comment-13841601
]
Edward Capriolo commented on HIVE-5783:
---
Why does support need to be build directly
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841606#comment-13841606
]
Xuefu Zhang commented on HIVE-5783:
---
[~jcoffey] Thanks for your contribution. I can help
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841620#comment-13841620
]
Brock Noland commented on HIVE-5783:
bq. I don't see any new files as expected.
It
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841618#comment-13841618
]
Brock Noland commented on HIVE-5783:
bq. Why does support need to be build directly
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841666#comment-13841666
]
Justin Coffey commented on HIVE-5783:
-
[~appodictic], regarding the support being built
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841674#comment-13841674
]
Edward Capriolo commented on HIVE-5783:
---
{quote}
regarding the support being built
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841681#comment-13841681
]
Justin Coffey commented on HIVE-5783:
-
{quote}
I think that was done before maven. I am
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841692#comment-13841692
]
Xuefu Zhang commented on HIVE-5783:
---
[~jcoffey] To rebase, we need to specify external
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841693#comment-13841693
]
Edward Capriolo commented on HIVE-5783:
---
{quote}
I would normally agree with this,
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841822#comment-13841822
]
Hive QA commented on HIVE-5783:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841855#comment-13841855
]
Carl Steinbach commented on HIVE-5783:
--
[~jcoffey] Would you and your coworkers be
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820168#comment-13820168
]
Justin Coffey commented on HIVE-5783:
-
Thanks [~cwsteinbach] and [~ehans]. Regarding
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819170#comment-13819170
]
Eric Hanson commented on HIVE-5783:
---
One thing you may want to consider is adding a
[
https://issues.apache.org/jira/browse/HIVE-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817609#comment-13817609
]
Carl Steinbach commented on HIVE-5783:
--
[~jcoffey] I added you to the list of Hive
76 matches
Mail list logo
